Feature Request: Add custom label during update

[Schurtzypoo]

Hello - I'd like to propose a feature that I think would be useful. It would be awesome if when brupop begins an upgrade it could apply a custom label to the node it's targeting, such as Karpenter's do-not-disrupt label. In some circumstances I've seen Karpenter mark a node for termination because it's underutilized due to being drained by brupop.

[Schurtzypoo]

It could then remove that label once the update has concluded.

[maherthomsi]

Hey @Schurtzypoo

We will be discussing this feature as an option and will keep this issue open. Any future updates will be posted here.

Thank you for reaching out!

[maherthomsi]

Hi @Schurtzypoo

Because Karpenter is a node orchestrator, and Brupop does do some node orchestration during updates, we’ve noticed some odd behaviors with using both together and it often involves some coordination each tool doesn’t have built in.

That said, we don’t currently have this on our roadmap since we usually recommend against mixing Karpenter and Brupop, but this seems like a great feature that could help when using both together! We would review any PRs that aim to add this hook to add labels during the update workflow. It makes sense that it would apply the label while pulling it out of service and then remove it once the node is back up and running. I could see this being useful just for debugging nodes that get “stuck” during an upgrade as well since the label would remain until it is done.