chore: fix clippy lints

Signed-off-by: Gavin Inglis <giinglis@amazon.com>

Author: ginglis13

sources/api/datastore/src/deserialization/pairs.rs

@@ -353,9 +353,7 @@ where
             } else {
                 // No dot, so we have a scalar; hand the data to a scalar deserializer.
                 trace!(
-                    "Key '{}' is scalar, getting '{}' from input to deserialize",
-                    struct_name,
-                    path
+                    "Key '{struct_name}' is scalar, getting '{path}' from input to deserialize"
                 );
                 let val = self.map.get(&path)?;
                 Some((

sources/api/datastore/src/key.rs

@@ -314,7 +314,7 @@ impl Key {
         // Push final segment (keys don't end with a dot, which is when we normally push)
         segments.push(segment);
 
-        trace!("Parsed key name '{}' to segments {:?}", name, segments);
+        trace!("Parsed key name '{name}' to segments {segments:?}");
         Ok(segments)
     }
 
@@ -348,7 +348,7 @@ impl Key {
 
         // Join the (possibly quoted) segments with our separator.
         let name = outputs.join(KEY_SEPARATOR_STR);
-        trace!("Encoded key '{}' from segments {:?}", name, segments);
+        trace!("Encoded key '{name}' from segments {segments:?}");
         Ok(name)
     }
 

sources/api/datastore/src/lib.rs

@@ -205,15 +205,15 @@ pub trait DataStore {
         committed: &Committed,
     ) -> Result<HashMap<Key, String>> {
         let keys = self.list_populated_keys(&find_prefix, committed)?;
-        trace!("Found populated keys: {:?}", keys);
+        trace!("Found populated keys: {keys:?}");
         if keys.is_empty() {
             return Ok(HashMap::new());
         }
 
         let mut result = HashMap::new();
         for key in keys {
             // Already confirmed key via listing keys, so an error is more serious.
-            trace!("Pulling value from datastore for key: {}", key);
+            trace!("Pulling value from datastore for key: {key}");
             let value = self
                 .get_key(&key, committed)?
                 .context(error::ListedKeyNotPresentSnafu { key: key.name() })?;
@@ -238,7 +238,7 @@ pub trait DataStore {
         S2: AsRef<str>,
     {
         let meta_map = self.list_populated_metadata(&find_prefix, committed, metadata_key_name)?;
-        trace!("Found populated metadata: {:?}", meta_map);
+        trace!("Found populated metadata: {meta_map:?}");
         if meta_map.is_empty() {
             return Ok(HashMap::new());
         }

sources/api/datastore/src/serialization/mod.rs

@@ -51,13 +51,13 @@ impl ser::Serializer for &MapKeySerializer {
     fn serialize_str(self, value: &str) -> Result<String> {
         // Make sure string is valid as a key.
         let key = Key::from_segments(KeyType::Data, &[value]).map_err(|e| {
-            debug!("MapKeySerializer got invalid key name: {}", value);
+            debug!("MapKeySerializer got invalid key name: {value}");
             error::InvalidKeySnafu {
                 msg: format!("{e}"),
             }
             .into_error(NoSource)
         })?;
-        trace!("MapKeySerializer got OK key: {}", key);
+        trace!("MapKeySerializer got OK key: {key}");
         Ok(key.to_string())
     }
 

sources/api/datastore/src/serialization/pairs.rs

@@ -204,7 +204,7 @@ impl<'a> ser::Serializer for Serializer<'a> {
         let prefix = match self.prefix {
             p @ Some(_) => p,
             None => {
-                trace!("Had no prefix, starting with struct name: {}", name);
+                trace!("Had no prefix, starting with struct name: {name}");
                 let key = Key::from_segments(KeyType::Data, &[&name]).map_err(|e| {
                     error::InvalidKeySnafu {
                         msg: format!("struct '{name}' not valid as Key: {e}"),

sources/bottlerocket-release/src/lib.rs

@@ -88,7 +88,7 @@ impl BottlerocketRelease {
                     value = &value[..value.len() - 1];
                 }
 
-                debug!("Found os-release value {}={}", key, value);
+                debug!("Found os-release value {key}={value}");
                 Some((key.to_owned(), value.to_owned()))
             })
             .collect();