Skip to content

Commit 1ddccc8

Browse files
committed
fix: clippy + fmt + debug -> warn on write for env key
1 parent 410b667 commit 1ddccc8

File tree

1 file changed

+21
-13
lines changed

1 file changed

+21
-13
lines changed

tools/pubsys/src/repo/env_key_source.rs

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,11 @@ pub enum Error {
1515
#[snafu(display("Environment variable '{}' not found", var_name))]
1616
EnvVarNotFound { var_name: String },
1717

18-
#[snafu(display("Failed to parse key from environment variable '{}': {}", var_name, source))]
18+
#[snafu(display(
19+
"Failed to parse key from environment variable '{}': {}",
20+
var_name,
21+
source
22+
))]
1923
KeyParse {
2024
var_name: String,
2125
source: Box<dyn std::error::Error + Send + Sync>,
@@ -24,29 +28,33 @@ pub enum Error {
2428

2529
#[async_trait]
2630
impl KeySource for EnvKeySource {
27-
async fn as_sign(&self) -> std::result::Result<Box<dyn Sign>, Box<dyn std::error::Error + Send + Sync>> {
31+
async fn as_sign(
32+
&self,
33+
) -> std::result::Result<Box<dyn Sign>, Box<dyn std::error::Error + Send + Sync>> {
2834
debug!("Reading key from environment variable: {}", self.var_name);
2935

3036
// Get the key data from the environment variable
31-
let key_data = env::var(&self.var_name)
32-
.map_err(|_| Error::EnvVarNotFound {
33-
var_name: self.var_name.clone(),
34-
})?;
37+
let key_data = env::var(&self.var_name).map_err(|_| Error::EnvVarNotFound {
38+
var_name: self.var_name.clone(),
39+
})?;
3540

3641
// Parse the key data into a signer
37-
let key = parse_keypair(key_data.as_bytes())
38-
.map_err(|e| Error::KeyParse {
39-
var_name: self.var_name.clone(),
40-
source: Box::new(e),
41-
})?;
42+
let key = parse_keypair(key_data.as_bytes()).map_err(|e| Error::KeyParse {
43+
var_name: self.var_name.clone(),
44+
source: Box::new(e),
45+
})?;
4246

4347
Ok(Box::new(key))
4448
}
4549

46-
async fn write(&self, _value: &str, _key_id_hex: &str) -> std::result::Result<(), Box<dyn std::error::Error + Send + Sync>> {
50+
async fn write(
51+
&self,
52+
_value: &str,
53+
_key_id_hex: &str,
54+
) -> std::result::Result<(), Box<dyn std::error::Error + Send + Sync>> {
4755
// We don't support writing keys back to environment variables
4856
// as this wouldn't persist beyond the current process
49-
debug!("Writing keys back to environment variables is not supported");
57+
warn!("Writing keys back to environment variables is not supported");
5058
Ok(())
5159
}
5260
}

0 commit comments

Comments
 (0)