Skip to content

Commit 3bc08f3

Browse files
authored
Merge pull request #553 from cartermckinnon/develop
fix(buildsys): start bypass container in main thread
2 parents 1592805 + ecac01c commit 3bc08f3

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

tools/buildsys/src/builder.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -624,6 +624,7 @@ impl DockerBuild {
624624
"run \
625625
--name {tag}-bypass \
626626
--rm \
627+
--detach \
627628
--init \
628629
--net host \
629630
--pid host \
@@ -648,6 +649,10 @@ impl DockerBuild {
648649
// Clean up the stopped bypass container if it exists.
649650
let _ = docker(&rm_bypass, Retry::No);
650651

652+
// Start the bypass container that will serve the project root file
653+
// descriptor.
654+
docker(&run_bypass, Retry::No)?;
655+
651656
let runtime = tokio::runtime::Runtime::new().context(error::AsyncRuntimeSnafu)?;
652657

653658
// Spawn a background task to share the file descriptors for the output directory.
@@ -659,12 +664,6 @@ impl DockerBuild {
659664
.await
660665
});
661666

662-
// Spawn a background task for the bypass container that will serve the project root file
663-
// descriptor.
664-
runtime.spawn(async move {
665-
let _ = docker(&run_bypass, Retry::No);
666-
});
667-
668667
// Build the image, which builds the artifacts we want.
669668
// Work around transient, known failure cases with Docker.
670669
let build_result = docker(

0 commit comments

Comments
 (0)