Skip to content

Commit da2d4ab

Browse files
authored
fix: prevent exception when updating a bottle's dependecy list view (#4045)
When calling `DetailsDependenciesView.update()`, addition of new dependency rows were scheduled by calling `GLib.idle_add(new_dependency, dep, plain=True)`, which (AFAIU) was wrong for the following reasons: * `GLib.idle_add()` doesn't support keyword arguments other than "priority" (as an alias for `GLib.idle_add(priority, func, *args)`). This ended up raising "unknown keyword argument" exceptions. * When a `DependencyEntryRow`, is created with `plain=True` then the dependency argument must be a string, not a tuple.
1 parent 6edfc00 commit da2d4ab

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

bottles/frontend/views/bottle_dependencies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,6 @@ def process_dependencies():
138138
for dep in self.config.Installed_Dependencies:
139139
if dep in dependencies:
140140
dep = (dep, dependencies[dep])
141-
GLib.idle_add(new_dependency, dep, plain=True)
141+
GLib.idle_add(new_dependency, dep)
142142

143143
RunAsync(process_dependencies, callback=callback)

0 commit comments

Comments
 (0)