[Bug]: Command line is not escaping quote character for xfce-terminal

[uben0]

Describe the bug

When trying to open the command line on a bottle, if xfce-terminal is the chosen terminal emulator, the invoked command is not properly escaped as it can be seen here:

Command: xfce4-terminal -e 'sh -c '/home/evvie/.local/share/bottles/runners/soda-9.0-1/bin/wine64 cmd'' 
xfce4-terminal: Unknown option "cmd"

Because, here

Bottles/bottles/backend/utils/terminal.py

Line 106 in 9605655

command = " ".join(self.terminal) % "'sh -c %s'" % f"{command}"

the string interpolation is not escaping the quotes.

To Reproduce

• Ensure you only have xfce-terminal
• Launch Bottle from a terminal to see the logs
• Create a new bottle
• Click on Tool > Command Line

Package

Flatpak from Flathub

Distribution

NixOs with Xfce

Debugging Information

Official Package: false
Version: '51.17'
DE/WM: xfce
Display:
    X.org: true
    X.org (port): :0.0
    Wayland: false
Graphics:
    vendors:
        amd:
            vendor: amd
            envs:
                DRI_PRIME: '1'
            icd: /run/opengl-driver/share/vulkan/icd.d/radeon_icd.x86_64.json
    prime:
        integrated: null
        discrete: null
Kernel:
    Type: Linux
    Version: 6.12.11
Disk:
    Total: 8033767424
    Free: 8033767424
RAM:
    MemTotal: 15.0GiB
    MemAvailable: 11.7GiB
Bottles_envs: null
Tools and Libraries:
    cabextract: true
    p7zip: true
    patool: true
    glibc_min: '2.40'
    icoextract: true
    pefile: true
    orjson: true
    markdown: true
    ImageMagick: true
    FVS: true
    xdpyinfo: true

Troubleshooting Logs

Additional context

No response

[cortices]

I'm having the same issue with the version of bottles distributed via nixpkgs:

14:52:32 (INFO) Command: xfce4-terminal -e 'sh -c '/home/sparky/.local/share/bottles/runners/caffe-9.7/bin/wine64 cmd'' 
xfce4-terminal: Unknown option "cmd"

My current workaround is to install kitty, as it has priority over xfce4-terminal in the list.

[IamKayrox]

My current workaround is to install kitty, as it has priority over xfce4-terminal in the list.

When using kitty it immediately closes for me. I can see kitty open for a second, it displays some lines and then closes. Bottles isn't outputting anything other than:

[0.343] The output buffer does not support sRGB color encoding, colors will be incorrect.

[github-actions]

This issue has been automatically closed as part of a cleanup process to help the team manage issues more effectively.

If the problem still persists, feel free to comment and we will gladly reopen it.