downloader: Accept Url's directly instead of parsing them

Author: cyberphantom52

src/downloader/manager.rs

@@ -42,25 +42,17 @@ impl DownloadManager {
         manager
     }
 
-    pub fn download(
-        &self,
-        url: impl TryInto<Url>,
-        destination: impl AsRef<Path>,
-    ) -> Result<DownloadBuilder, Error> {
-        let url = url
-            .try_into()
-            .map_err(|_| Error::Download(DownloadError::InvalidUrl))?;
-        Ok(DownloadBuilder::new(self, url, destination))
+    pub fn download(&self, url: Url, destination: impl AsRef<Path>) -> DownloadBuilder {
+        DownloadBuilder::new(self, url, destination)
     }
 
     pub fn download_with_config(
         &self,
         url: Url,
         destination: impl AsRef<Path>,
         config: DownloadConfig,
-    ) -> Result<DownloadBuilder, Error> {
-        self.download(url, destination)
-            .map(|builder| builder.with_config(config))
+    ) -> DownloadBuilder {
+        self.download(url, destination).with_config(config)
     }
 
     pub async fn set_max_parallel_downloads(&self, limit: usize) -> Result<(), Error> {

src/error.rs

@@ -27,6 +27,6 @@ pub enum DownloadError {
     ManagerShutdown,
     #[error("File already exists: {path}")]
     FileExists { path: PathBuf },
-    #[error("Invalid URL")]
-    InvalidUrl,
+    #[error("Invalid URL: {0}")]
+    InvalidUrl(#[from] url::ParseError),
 }