Skip to content

Commit c9c68bb

Browse files
hao.pengbougou
authored andcommitted
fix SEL severity parsing issue
1 parent bd08d4c commit c9c68bb

File tree

2 files changed

+42
-3
lines changed

2 files changed

+42
-3
lines changed

types_event.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ func (typ EventReadingType) EventSeverity(sensorType SensorType, eventData Event
172172
return EventSeverityInfo
173173

174174
case EventReadingTypeThreshold:
175-
if eventDir {
175+
if !eventDir {
176176
if v, ok := event.AssertionSeverityMap[sensorType]; ok {
177177
return v
178178
}
@@ -191,14 +191,14 @@ func (typ EventReadingType) EventSeverity(sensorType SensorType, eventData Event
191191
}
192192

193193
case EventReadingTypeSensorSpecific:
194-
if eventDir {
194+
if !eventDir {
195195
return event.AssertionSeverity
196196
}
197197
return event.DeassertionSeverity
198198

199199
default:
200200
if typ >= 0x02 && typ <= 0x0c {
201-
if eventDir {
201+
if !eventDir {
202202
if v, ok := event.AssertionSeverityMap[sensorType]; ok {
203203
return v
204204
}

types_sel_test.go

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
package ipmi
2+
3+
import (
4+
"encoding/hex"
5+
"testing"
6+
)
7+
8+
func TestParseSEL(t *testing.T) {
9+
type args struct {
10+
msg []byte
11+
}
12+
s, _ := hex.DecodeString("4d150290b3c66741000409010b03ffff")
13+
tests := []struct {
14+
name string
15+
args args
16+
wantSeverity EventSeverity
17+
wantErr bool
18+
}{
19+
{
20+
name: "SEL",
21+
args: args{
22+
msg: s,
23+
},
24+
wantSeverity: EventSeverityCritical,
25+
},
26+
}
27+
for _, tt := range tests {
28+
t.Run(tt.name, func(t *testing.T) {
29+
sel, err := ParseSEL(tt.args.msg)
30+
if (err != nil) != tt.wantErr {
31+
t.Errorf("ParseSEL() error = %v, wantErr %v", err, tt.wantErr)
32+
return
33+
}
34+
if sel.Standard.EventSeverity() != tt.wantSeverity {
35+
t.Errorf("ParseSEL() = %v, want %v", sel.Standard.EventSeverity(), tt.wantSeverity)
36+
}
37+
})
38+
}
39+
}

0 commit comments

Comments
 (0)