Mobile first open hotfix (#610)

* Updated the index.tsx for first sign in bug.

* Fixed the bug of the profile form not being present after the first sign in.

Author: Kerem-Kurt

heatHMobile/__test__/interestFormService.test.ts

@@ -13,11 +13,16 @@ jest.mock('@/services/apiClient', () => ({
 describe('interestFormService', () => {
   beforeEach(() => jest.clearAllMocks());
 
-  it('checkFirstLogin returns backend value on success', async () => {
-    (apiClient.get as jest.Mock).mockResolvedValueOnce({ data: true });
+  it('checkFirstLogin returns true if form is missing (backend returns false)', async () => {
+    (apiClient.get as jest.Mock).mockResolvedValueOnce({ data: false });
     await expect(interestFormService.checkFirstLogin()).resolves.toBe(true);
   });
 
+  it('checkFirstLogin returns false if form exists (backend returns true)', async () => {
+    (apiClient.get as jest.Mock).mockResolvedValueOnce({ data: true });
+    await expect(interestFormService.checkFirstLogin()).resolves.toBe(false);
+  });
+
   it('checkFirstLogin returns false on 404/403', async () => {
     const err404 = { isAxiosError: true, response: { status: 404 } } as any;
     (axios.isAxiosError as any) = () => true;

heatHMobile/app/auth/sign-in.tsx

@@ -34,17 +34,18 @@ export default function SignInScreen() {
     try {
       await authService.login({ username: email, password: password });
 
-      // Check if this is the user's first login
+      // Check if this is the user's first login (needs to fill profile)
       try {
-        const isFirstLogged = await interestFormService.checkFirstLogin();
+        // returns true if form NOT submitted (first login)
+        const isFirstLogin = await interestFormService.checkFirstLogin();
 
-        if (isFirstLogged) {
-          router.replace('/(tabs)' as any);
-        } else {
+        if (isFirstLogin) {
           router.replace('/first-login-profile' as any);
-
+        } else {
+          router.replace('/(tabs)' as any);
         }
       } catch (firstLoginError) {
+        // If check fails, default to tabs
         router.replace('/(tabs)' as any);
       }
     } catch (error: any) {

heatHMobile/app/index.tsx

@@ -18,15 +18,18 @@ export default function Index() {
       console.log('Token:', token ? 'Found' : 'Not found');
 
       if (token) {
-        // Check if this is the user's first login
+        // Check if this is the user's first login (needs to fill profile)
         try {
-          const isFirstLogged = await interestFormService.checkFirstLogin();
-          if (isFirstLogged) {
-            router.replace('/(tabs)' as any);
-          } else {
+          // returns true if form NOT submitted (first login)
+          const isFirstLogin = await interestFormService.checkFirstLogin();
+          
+          if (isFirstLogin) {
             router.replace('/first-login-profile' as any);
+          } else {
+            router.replace('/(tabs)' as any);
           }
         } catch (firstLoginError) {
+          // If check fails, default to tabs
           router.replace('/(tabs)' as any);
         }
       } else {

heatHMobile/services/interestFormService.ts

@@ -17,7 +17,9 @@ export const interestFormService = {
     try {
       const response = await apiClient.get('/interest-form/check-first-login');
       console.log('Check first login response:', response.data);
-      return response.data;
+      // Backend returns true if form EXISTS.
+      // We want true if form is MISSING (is first login).
+      return !response.data;
     } catch (err) {
       // If endpoint not found or form doesn't exist/forbidden, treat as not first login
       if (axios.isAxiosError(err) && (err.response?.status === 404 || err.response?.status === 403)) {