Incorrect `<CaseResultSvg />` icons for "successful" and "failed" tests

[adwait-godbole]

2024-08-08.23-09-53.mp4

Not sure why this wasn't caught much earlier on, but anyways, here as one can see in the above video, although the background/border colors are correct for all the 4 states ("successful", "failed", "errored" and "skipped"), the check and cross icons have incorrectly gotten swapped for "successful" and "failed" results.

[Julian]

There are 2 separate things we show (and need to show, though how we do so is of course miprovable), the tick marks originally were "is the instance valid or invalid" not "is that answer correct or not". Are you still saying they're incorrect now?

[adwait-godbole]

Hmm I think its the onHover text of the icon that caught my eye, If I hover on the cross icon it says "Correct Result" whereas if I hover on the tick icon it says "Incorrect Result". Should these texts say something else/something more clear as per what you're saying?

[Julian]

I again am not sure (in that I haven't checked and can't tell whether you have yet) whether there's a bug there or just lack of clarity -- it may so happen you moused over one thing which is a successful test and one which failed -- and it so happened the two tests also differed on whether the instance was valid or invalid, so that the hover had nothing to do with the tick mark.

But yes, probably showing something in the hover which says both what the validation result is and whether that's the correct one is going to be lots clearer.