Summary details shows incorrect instance for float values

[DannyvdSluijs]

I've been working on getting my implementation better with Draft 4 (yes I know that draft is old but i don't think that is the issue here).

I was looking at https://bowtie.report/#/dialects/draft4?language=php, clicking on the details button for justinrainbow-json-schema (There is no direct link due to it opening as a dialog). Where it shows Unsuccessful Tests:justinrainbow-json-schemaPHP and directly on the top left there is a test named Case: enum with 0 does not match false with a subtitle Test: float zero is valid. The instance shows a integer zero: 0where float zero 0.0 was expected.

The same can be seen when going back to https://bowtie.report/#/dialects/draft4?language=php and search the same test case (enum with 0 does not match false) and click on the test called float zero is valid the instance is displayed as 0 instead of the expected 0.0.

---

The original test case from JSON-Schema-Test-Suite can be found here showing the expected float-zero.

{
     "description": "float zero is valid",
       "data": 0.0,
      "valid": true
}

❓ I'm not 100% sure the issue should be reported here, just let me know if I need to report it somewhere else or if more explanation is needed.

[Julian]

Thanks yes here is the right place, that's probably some Javascript issue where we're being bitten by Javascript itself not having floats (and we should instead be rendering the JSON literally via some non-lossy mechanism).

I doubt I'll have time to look into this anytime soon myself given it's just a presentation bug but PR certainly welcome.

[DannyvdSluijs]

I’m willing to see if I can make a PR. A few pointers would very welcome to make some headway.

[Julian]

Probably the bug is here:

bowtie/frontend/src/data/parseReportData.ts

Line 15 in 707ff44

lines.map((line) => JSON.parse(line) as Record<string, unknown>),

and the fix is to use some more preserving-way of parsing JSON in JS which doesn't throw away the exact number representation.

[Julian]

Maybe in very slightly further detail, you can use bowtie suite yourself to generate a report -- the output of which you can "upload" to a local copy of the UI via the "upload a local report" option in the Dialects dropdown -- and then be able to play with that line to see how it's being parsed).

[DannyvdSluijs]

At this point I can confirm what you're expecting is the case. In the JSON decoded string I can see the correct instance value (with 0.0) and inspecting the object as result form the JSON.parse() call the decimal art gets dropped and only the 0 remains.

This is also reproducible with the following snippet: console.log(JSON.parse('{"instance": 0.0}')); which results in { "instance": 0 }. And it is highlighted here as well.