check that all values in a list of coordinates are either a binary or a number

Author: bdebinska

lib/value_formatters.ex

@@ -84,15 +84,35 @@ defmodule ValueFormatters do
 
   defp determine_value_type(value) do
     case value do
-      %Date{} -> "date"
-      %DateTime{} -> "date"
-      %NaiveDateTime{} -> "date"
-      %Time{} -> "date"
-      [lat, _lng, _radius] when is_number(lat) or is_binary(lat) -> "coordinates"
-      [lat, _lng] when is_number(lat) or is_binary(lat) -> "coordinates"
-      %{"lat" => _lat, "lng" => _lng, "radius" => _radius} -> "coordinates"
-      %{"lat" => _lat, "lng" => _lng} -> "coordinates"
-      _ -> "The type of value #{inspect(value)} is not supported."
+      %Date{} ->
+        "date"
+
+      %DateTime{} ->
+        "date"
+
+      %NaiveDateTime{} ->
+        "date"
+
+      %Time{} ->
+        "date"
+
+      [lat, lng, radius]
+      when (is_number(lat) or is_binary(lat)) and
+             (is_number(lng) or is_binary(lng)) and (is_number(radius) or is_binary(radius)) ->
+        "coordinates"
+
+      [lat, lng]
+      when (is_number(lat) or is_binary(lat)) and (is_number(lng) or is_binary(lng)) ->
+        "coordinates"
+
+      %{"lat" => _lat, "lng" => _lng, "radius" => _radius} ->
+        "coordinates"
+
+      %{"lat" => _lat, "lng" => _lng} ->
+        "coordinates"
+
+      _ ->
+        "The type of value #{inspect(value)} is not supported."
     end
   end
 

test/value_formatters_test.exs

@@ -563,6 +563,15 @@ defmodule ValueFormattersTest do
                {:ok, "123.1345°, 34.123°, 2 m"}
     end
 
+    test "mixed coordinates with radius" do
+      assert ValueFormatters.to_string(
+               [123.1345, "34.123", 2],
+               %{"format" => "coordinates"},
+               @opts
+             ) ==
+               {:ok, "123.1345°, 34.123°, 2 m"}
+    end
+
     test "inference object with radius" do
       assert ValueFormatters.to_string(
                %{"lat" => 43.1298, "lng" => 54.1234, "radius" => 1},
@@ -644,6 +653,12 @@ defmodule ValueFormattersTest do
                  "Unsupported format The type of value [%{\"foo\" => \"bar\"}, %{\"bar\" => \"foo\"}, %{\"baz\" => \"qux\"}] is not supported."
                }
     end
+
+    test "doesn't format an array with only one map" do
+      assert ValueFormatters.to_string([123, 456, %{"foo" => "bar"}], %{}, @opts) ==
+               {:error,
+                "Unsupported format The type of value [123, 456, %{\"foo\" => \"bar\"}] is not supported."}
+    end
   end
 
   describe "render" do