refactor: Update code with Rector (#1465)

Author: theofidry

rector.php

@@ -22,7 +22,6 @@
     ])
     ->withSkip([
         \Rector\Php81\Rector\FuncCall\NullToStrictStringFuncCallArgRector::class,
-        \Rector\Php73\Rector\FuncCall\JsonThrowOnErrorRector::class,
         \Rector\Php55\Rector\String_\StringClassNameToClassConstantRector::class => [
             __DIR__.'/src/Configuration/Configuration.php',
         ],

src/Annotation/DocblockAnnotationParser.php

@@ -28,19 +28,19 @@
 /**
  * @private
  */
-final class DocblockAnnotationParser
+final readonly class DocblockAnnotationParser
 {
     /**
      * @var array<string, mixed>
      */
-    private readonly array $ignoredAnnotationsAsKeys;
+    private array $ignoredAnnotationsAsKeys;
 
     /**
      * @param string[] $ignoredAnnotations
      */
     public function __construct(
-        private readonly DocBlockFactoryInterface $factory,
-        private readonly Formatter $tagsFormatter,
+        private DocBlockFactoryInterface $factory,
+        private Formatter $tagsFormatter,
         array $ignoredAnnotations,
     ) {
         $this->ignoredAnnotationsAsKeys = array_flip($ignoredAnnotations);

src/Compactor/Placeholder.php

@@ -18,12 +18,12 @@
 use function array_keys;
 use function str_replace;
 
-final class Placeholder implements Compactor
+final readonly class Placeholder implements Compactor
 {
     /**
      * @var scalar[]
      */
-    private readonly array $placeholders;
+    private array $placeholders;
 
     /**
      * @param scalar[] $placeholders

src/Composer/ComposerProcessFactory.php

@@ -50,7 +50,7 @@ public static function create(
      */
     public function __construct(
         private readonly Closure $composerExecutableFactory,
-        private ?string $verbosity,
+        private readonly ?string $verbosity,
         private readonly bool $ansi,
         private readonly array $defaultEnvironmentVariables,
     ) {

src/Configuration/Configuration.php

@@ -30,13 +30,11 @@
 use KevinGH\Box\Composer\Artifact\ComposerJson;
 use KevinGH\Box\Composer\Artifact\ComposerLock;
 use KevinGH\Box\Composer\ComposerConfiguration;
-use KevinGH\Box\Json\Json;
 use KevinGH\Box\MapFile;
 use KevinGH\Box\Phar\CompressionAlgorithm;
 use KevinGH\Box\Phar\SigningAlgorithm;
 use KevinGH\Box\PhpScoper\ConfigurationFactory as PhpScoperConfigurationFactory;
 use KevinGH\Box\PhpScoper\SerializableScoper;
-use Phar;
 use RuntimeException;
 use SplFileInfo;
 use stdClass;

src/DockerFileGenerator.php

@@ -30,7 +30,7 @@
 /**
  * @private
  */
-final class DockerFileGenerator
+final readonly class DockerFileGenerator
 {
     private const FILE_TEMPLATE = <<<'Dockerfile'
         FROM php:__BASE_PHP_IMAGE_TOKEN__
@@ -56,12 +56,12 @@ final class DockerFileGenerator
         '*' => 'to-define-manually',
     ];
 
-    private readonly string $image;
+    private string $image;
 
     /**
      * @var string[]
      */
-    private readonly array $extensions;
+    private array $extensions;
 
     /**
      * Creates a new instance of the generator.
@@ -87,7 +87,7 @@ public static function createForRequirements(array $requirements, string $source
     public function __construct(
         string $image,
         array $extensions,
-        private readonly string $sourcePhar,
+        private string $sourcePhar,
     ) {
         Assert::inArray($image, self::PHP_DOCKER_IMAGES);
         Assert::allString($extensions);

src/Phar/PharDiff.php

@@ -21,11 +21,11 @@
 /**
  * @internal
  */
-final class PharDiff
+final readonly class PharDiff
 {
-    private readonly PharInfo $pharInfoA;
-    private readonly PharInfo $pharInfoB;
-    private readonly DifferFactory $differFactory;
+    private PharInfo $pharInfoA;
+    private PharInfo $pharInfoB;
+    private DifferFactory $differFactory;
 
     public function __construct(string $pathA, string $pathB)
     {

src/PhpScoper/ExcludedFilesScoper.php

@@ -19,12 +19,12 @@
 use function array_key_exists;
 use function func_get_args;
 
-final class ExcludedFilesScoper implements PhpScoperScoper
+final readonly class ExcludedFilesScoper implements PhpScoperScoper
 {
-    private readonly array $excludedFilePathsAsKeys;
+    private array $excludedFilePathsAsKeys;
 
     public function __construct(
-        private readonly PhpScoperScoper $decoratedScoper,
+        private PhpScoperScoper $decoratedScoper,
         string ...$excludedFilePaths,
     ) {
         $this->excludedFilePathsAsKeys = array_flip($excludedFilePaths);

tests/Console/ApplicationTest.php

@@ -97,20 +97,20 @@ public function test_get_helper_menu(): void
 
         $quietSilentSegment = self::isSymfonyConsole72OrHigher()
             ? <<<'EOF'
-                  --silent          Do not output any message
-              -q, --quiet           Only errors are displayed. All other output is suppressed
-            EOF
+                      --silent          Do not output any message
+                  -q, --quiet           Only errors are displayed. All other output is suppressed
+                EOF
             : <<<'EOF'
-              -q, --quiet           Do not output any message
-            EOF;
+                  -q, --quiet           Do not output any message
+                EOF;
 
         $expected = <<<EOF
 
                 ____
                / __ )____  _  __
-              / __  / __ \| |/_/
+              / __  / __ \\| |/_/
              / /_/ / /_/ />  <
-            /_____/\____/_/|_|
+            /_____/\\____/_/|_|
 
 
             Box version x.x-dev@151e40a
@@ -120,7 +120,7 @@ public function test_get_helper_menu(): void
 
             Options:
               -h, --help            Display help for the given command. When no command is given display help for the list command
-            $quietSilentSegment
+            {$quietSilentSegment}
               -V, --version         Display this application version
                   --ansi|--no-ansi  Force (or disable --no-ansi) ANSI output
               -n, --no-interaction  Do not ask any interactive question