fix: Fix managing network errors (box/box-codegen#798) (#1377)

Author: box-sdk-build

.codegen.json

@@ -1 +1 @@
-{ "engineHash": "02b749b", "specHash": "623b811", "version": "0.1.0" }
+{ "engineHash": "d090a8d", "specHash": "623b811", "version": "0.1.0" }

src/main/java/com/box/sdkgen/box/errors/BoxSDKError.java

@@ -11,17 +11,20 @@ public class BoxSDKError extends RuntimeException {
   public String name;
 
   public BoxSDKError(String message) {
+    super(message);
     this.message = message;
     this.name = "BoxSDKError";
   }
 
   public BoxSDKError(String message, Exception error) {
+    super(message, error);
     this.message = message;
     this.error = error;
     this.name = "BoxSDKError";
   }
 
   protected BoxSDKError(Builder builder) {
+    super(builder.message, builder.error);
     this.message = builder.message;
     this.timestamp = builder.timestamp;
     this.error = builder.error;

src/main/java/com/box/sdkgen/networking/boxnetworkclient/BoxNetworkClient.java

@@ -77,7 +77,7 @@ public FetchResponse fetch(FetchOptions options) {
 
     boolean authenticationNeeded = false;
     Request request;
-    FetchResponse fetchResponse = null;
+    FetchResponse fetchResponse = new FetchResponse.Builder(0, new TreeMap<>()).build();
     Exception exceptionThrown = null;
 
     int attemptNumber = 1;
@@ -140,9 +140,6 @@ public FetchResponse fetch(FetchOptions options) {
         if (response != null) {
           response.close();
         }
-
-        fetchResponse =
-            new FetchResponse.Builder(0, new TreeMap<>(String.CASE_INSENSITIVE_ORDER)).build();
       }
 
       shouldRetry =
@@ -167,8 +164,7 @@ public FetchResponse fetch(FetchOptions options) {
         continue;
       }
 
-      if (fetchResponse != null
-          && fetchResponse.getStatus() >= 300
+      if (fetchResponse.getStatus() >= 300
           && fetchResponse.getStatus() < 400
           && fetchOptions.followRedirects) {
         if (!fetchResponse.getHeaders().containsKey("Location")) {
@@ -189,9 +185,7 @@ public FetchResponse fetch(FetchOptions options) {
                 .build());
       }
 
-      if (fetchResponse != null
-          && fetchResponse.getStatus() >= 200
-          && fetchResponse.getStatus() < 400) {
+      if (fetchResponse.getStatus() >= 200 && fetchResponse.getStatus() < 400) {
         return fetchResponse;
       }
 
@@ -313,7 +307,7 @@ private static void throwOnUnsuccessfulResponse(
       String rawResponseBody,
       Exception exceptionThrown,
       DataSanitizer dataSanitizer) {
-    if (fetchResponse == null) {
+    if (fetchResponse.getStatus() == 0 && exceptionThrown != null) {
       throw new BoxSDKError(exceptionThrown.getMessage(), exceptionThrown);
     }
     try {

src/main/java/com/box/sdkgen/serialization/json/JsonManager.java

@@ -93,7 +93,7 @@ public static String sanitizedValue() {
   }
 
   public static JsonNode sanitizeSerializedData(JsonNode sd, Map<String, String> keysToSanitize) {
-    if (!sd.isObject()) {
+    if (sd == null || !sd.isObject()) {
       return sd;
     }
     Map<String, JsonNode> sanitizedDictionary = new HashMap<>();