Skip to content

Commit 44c4aed

Browse files
committed
fix: use Locale.ROOT for casing operations to prevent issues with non-US locales
1 parent 48c485f commit 44c4aed

17 files changed

+24
-23
lines changed

src/main/java/com/box/sdk/BoxAIItem.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ public enum Type {
111111
}
112112

113113
static BoxAIItem.Type fromJSONValue(String jsonValue) {
114-
return BoxAIItem.Type.valueOf(jsonValue.toUpperCase());
114+
return BoxAIItem.Type.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
115115
}
116116

117117
String toJSONValue() {

src/main/java/com/box/sdk/BoxAPIResponse.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -306,7 +306,8 @@ public String toString() {
306306
headers.entrySet()
307307
.stream()
308308
.filter(Objects::nonNull)
309-
.forEach(e -> builder.append(format("%s: [%s]%s", e.getKey().toLowerCase(), e.getValue(), lineSeparator)));
309+
.forEach(e -> builder.append(format("%s: [%s]%s", e.getKey().toLowerCase(java.util.Locale.ROOT),
310+
e.getValue(), lineSeparator)));
310311

311312
String bodyString = this.bodyToString();
312313
if (bodyString != null && !bodyString.equals("")) {

src/main/java/com/box/sdk/BoxCollaboration.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ public Status getStatus() {
520520
*/
521521
public void setStatus(Status status) {
522522
this.status = status;
523-
this.addPendingChange("status", status.name().toLowerCase());
523+
this.addPendingChange("status", status.name().toLowerCase(java.util.Locale.ROOT));
524524
}
525525

526526
/**
@@ -604,7 +604,7 @@ protected void parseJSONMember(JsonObject.Member member) {
604604
this.expiresAt = BoxDateFormat.parse(value.asString());
605605
break;
606606
case "status":
607-
String statusString = value.asString().toUpperCase();
607+
String statusString = value.asString().toUpperCase(java.util.Locale.ROOT);
608608
this.status = Status.valueOf(statusString);
609609

610610
break;

src/main/java/com/box/sdk/BoxCollaborator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public enum CollaboratorType {
4040
}
4141

4242
static CollaboratorType fromJSONValue(String jsonValue) {
43-
return CollaboratorType.valueOf(jsonValue.toUpperCase());
43+
return CollaboratorType.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
4444
}
4545

4646
String toJSONValue() {
@@ -69,7 +69,7 @@ public enum GroupType {
6969
}
7070

7171
static GroupType fromJSONValue(String jsonValue) {
72-
return GroupType.valueOf(jsonValue.toUpperCase());
72+
return GroupType.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
7373
}
7474

7575
String toJSONValue() {

src/main/java/com/box/sdk/BoxFile.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1706,7 +1706,7 @@ public enum Permission {
17061706
}
17071707

17081708
static Permission fromJSONValue(String jsonValue) {
1709-
return Permission.valueOf(jsonValue.toUpperCase());
1709+
return Permission.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
17101710
}
17111711

17121712
String toJSONValue() {

src/main/java/com/box/sdk/BoxFileRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,7 @@ public enum Status {
151151
}
152152

153153
static Status fromJSONString(String jsonValue) {
154-
return Status.valueOf(jsonValue.toUpperCase());
154+
return Status.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
155155
}
156156

157157
String toJSONString() {

src/main/java/com/box/sdk/BoxFolder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1387,7 +1387,7 @@ public enum SyncState {
13871387
}
13881388

13891389
static SyncState fromJSONValue(String jsonValue) {
1390-
return SyncState.valueOf(jsonValue.toUpperCase());
1390+
return SyncState.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
13911391
}
13921392

13931393
String toJSONValue() {
@@ -1441,7 +1441,7 @@ public enum Permission {
14411441
}
14421442

14431443
static Permission fromJSONValue(String jsonValue) {
1444-
return Permission.valueOf(jsonValue.toUpperCase());
1444+
return Permission.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
14451445
}
14461446

14471447
String toJSONValue() {

src/main/java/com/box/sdk/BoxGroupMembership.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public enum Permission {
161161
}
162162

163163
static Permission fromJSONValue(String jsonValue) {
164-
return Permission.valueOf(jsonValue.toUpperCase());
164+
return Permission.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
165165
}
166166

167167
String toJSONValue() {

src/main/java/com/box/sdk/BoxSensitiveDataSanitizer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,6 @@ static JsonObject sanitizeJsonBody(JsonObject originalBody) {
6666
}
6767

6868
private static boolean isSensitiveKey(@NotNull String key) {
69-
return SENSITIVE_KEYS.contains(key.toLowerCase());
69+
return SENSITIVE_KEYS.contains(key.toLowerCase(java.util.Locale.ROOT));
7070
}
7171
}

src/main/java/com/box/sdk/BoxSharedLink.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ public void setPermissions(Permissions permissions) {
227227
}
228228

229229
private Access parseAccessValue(JsonValue value) {
230-
String accessString = value.asString().toUpperCase();
230+
String accessString = value.asString().toUpperCase(java.util.Locale.ROOT);
231231
return Access.valueOf(accessString);
232232
}
233233

0 commit comments

Comments
 (0)