fix: use Locale.ROOT to prevent issues with non-US locales (#1306)

mwwoda · web-flow · commit f083092d5fda · 2025-04-29T09:23:55.000+02:00
diff --git a/.github/workflows/build-main.yml b/.github/workflows/build-main.yml
@@ -15,9 +15,9 @@ jobs:
     name: Java ${{ matrix.java }} (${{ matrix.distribution }})
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Setup Java
-        uses: actions/setup-java@v2
+        uses: actions/setup-java@v4
         with:
           distribution: ${{ matrix.distribution }}
           java-version: ${{ matrix.java }}
diff --git a/.github/workflows/integration-tests.yml b/.github/workflows/integration-tests.yml
@@ -13,9 +13,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Setup Java
-        uses: actions/setup-java@v2
+        uses: actions/setup-java@v4
         with:
           distribution: 'temurin'
           java-version: '8'
diff --git a/.github/workflows/spell-check-lint.yml b/.github/workflows/spell-check-lint.yml
@@ -9,9 +9,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout current repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
       - name: Checkout spellchecker
-        uses: actions/checkout@v2
+        uses: actions/checkout@v4
         with:
           ref: refs/heads/main
           repository: box/box-sdk-spellchecker
diff --git a/src/main/java/com/box/sdk/BoxAIItem.java b/src/main/java/com/box/sdk/BoxAIItem.java
@@ -111,7 +111,7 @@ public enum Type {
         }
 
         static BoxAIItem.Type fromJSONValue(String jsonValue) {
-            return BoxAIItem.Type.valueOf(jsonValue.toUpperCase());
+            return BoxAIItem.Type.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
diff --git a/src/main/java/com/box/sdk/BoxAPIResponse.java b/src/main/java/com/box/sdk/BoxAPIResponse.java
@@ -306,7 +306,8 @@ public String toString() {
         headers.entrySet()
             .stream()
             .filter(Objects::nonNull)
-            .forEach(e -> builder.append(format("%s: [%s]%s", e.getKey().toLowerCase(), e.getValue(), lineSeparator)));
+            .forEach(e -> builder.append(format("%s: [%s]%s", e.getKey().toLowerCase(java.util.Locale.ROOT),
+                e.getValue(), lineSeparator)));
 
         String bodyString = this.bodyToString();
         if (bodyString != null && !bodyString.equals("")) {
diff --git a/src/main/java/com/box/sdk/BoxCollaboration.java b/src/main/java/com/box/sdk/BoxCollaboration.java
@@ -520,7 +520,7 @@ public Status getStatus() {
          */
         public void setStatus(Status status) {
             this.status = status;
-            this.addPendingChange("status", status.name().toLowerCase());
+            this.addPendingChange("status", status.name().toLowerCase(java.util.Locale.ROOT));
         }
 
         /**
@@ -604,7 +604,7 @@ protected void parseJSONMember(JsonObject.Member member) {
                         this.expiresAt = BoxDateFormat.parse(value.asString());
                         break;
                     case "status":
-                        String statusString = value.asString().toUpperCase();
+                        String statusString = value.asString().toUpperCase(java.util.Locale.ROOT);
                         this.status = Status.valueOf(statusString);
 
                         break;
diff --git a/src/main/java/com/box/sdk/BoxCollaborator.java b/src/main/java/com/box/sdk/BoxCollaborator.java
@@ -40,7 +40,7 @@ public enum CollaboratorType {
         }
 
         static CollaboratorType fromJSONValue(String jsonValue) {
-            return CollaboratorType.valueOf(jsonValue.toUpperCase());
+            return CollaboratorType.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
@@ -69,7 +69,7 @@ public enum GroupType {
         }
 
         static GroupType fromJSONValue(String jsonValue) {
-            return GroupType.valueOf(jsonValue.toUpperCase());
+            return GroupType.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
diff --git a/src/main/java/com/box/sdk/BoxFile.java b/src/main/java/com/box/sdk/BoxFile.java
@@ -1706,7 +1706,7 @@ public enum Permission {
         }
 
         static Permission fromJSONValue(String jsonValue) {
-            return Permission.valueOf(jsonValue.toUpperCase());
+            return Permission.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
diff --git a/src/main/java/com/box/sdk/BoxFileRequest.java b/src/main/java/com/box/sdk/BoxFileRequest.java
@@ -151,7 +151,7 @@ public enum Status {
         }
 
         static Status fromJSONString(String jsonValue) {
-            return Status.valueOf(jsonValue.toUpperCase());
+            return Status.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONString() {
diff --git a/src/main/java/com/box/sdk/BoxFolder.java b/src/main/java/com/box/sdk/BoxFolder.java
@@ -1387,7 +1387,7 @@ public enum SyncState {
         }
 
         static SyncState fromJSONValue(String jsonValue) {
-            return SyncState.valueOf(jsonValue.toUpperCase());
+            return SyncState.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
@@ -1441,7 +1441,7 @@ public enum Permission {
         }
 
         static Permission fromJSONValue(String jsonValue) {
-            return Permission.valueOf(jsonValue.toUpperCase());
+            return Permission.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
diff --git a/src/main/java/com/box/sdk/BoxGroupMembership.java b/src/main/java/com/box/sdk/BoxGroupMembership.java
@@ -161,7 +161,7 @@ public enum Permission {
         }
 
         static Permission fromJSONValue(String jsonValue) {
-            return Permission.valueOf(jsonValue.toUpperCase());
+            return Permission.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
diff --git a/src/main/java/com/box/sdk/BoxSensitiveDataSanitizer.java b/src/main/java/com/box/sdk/BoxSensitiveDataSanitizer.java
@@ -66,6 +66,6 @@ static JsonObject sanitizeJsonBody(JsonObject originalBody) {
     }
 
     private static boolean isSensitiveKey(@NotNull String key) {
-        return SENSITIVE_KEYS.contains(key.toLowerCase());
+        return SENSITIVE_KEYS.contains(key.toLowerCase(java.util.Locale.ROOT));
     }
 }
diff --git a/src/main/java/com/box/sdk/BoxSharedLink.java b/src/main/java/com/box/sdk/BoxSharedLink.java
@@ -227,7 +227,7 @@ public void setPermissions(Permissions permissions) {
     }
 
     private Access parseAccessValue(JsonValue value) {
-        String accessString = value.asString().toUpperCase();
+        String accessString = value.asString().toUpperCase(java.util.Locale.ROOT);
         return Access.valueOf(accessString);
     }
 
diff --git a/src/main/java/com/box/sdk/BoxUploadEmail.java b/src/main/java/com/box/sdk/BoxUploadEmail.java
@@ -93,7 +93,7 @@ public enum Access {
         }
 
         static Access fromJSONValue(String jsonValue) {
-            return Access.valueOf(jsonValue.toUpperCase());
+            return Access.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
diff --git a/src/main/java/com/box/sdk/BoxUser.java b/src/main/java/com/box/sdk/BoxUser.java
@@ -818,7 +818,7 @@ public enum Role {
         }
 
         static Role fromJSONValue(String jsonValue) {
-            return Role.valueOf(jsonValue.toUpperCase());
+            return Role.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
@@ -857,7 +857,7 @@ public enum Status {
         }
 
         static Status fromJSONValue(String jsonValue) {
-            return Status.valueOf(jsonValue.toUpperCase());
+            return Status.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
@@ -956,7 +956,7 @@ public Role getRole() {
          */
         public void setRole(Role role) {
             this.role = role;
-            this.addPendingChange("role", role.name().toLowerCase());
+            this.addPendingChange("role", role.name().toLowerCase(java.util.Locale.ROOT));
         }
 
         /**
@@ -1050,7 +1050,7 @@ public Status getStatus() {
          */
         public void setStatus(Status status) {
             this.status = status;
-            this.addPendingChange("status", status.name().toLowerCase());
+            this.addPendingChange("status", status.name().toLowerCase(java.util.Locale.ROOT));
         }
 
         /**
diff --git a/src/main/java/com/box/sdk/BoxZipDownloadStatus.java b/src/main/java/com/box/sdk/BoxZipDownloadStatus.java
@@ -120,7 +120,7 @@ public enum State {
         }
 
         static State fromJSONValue(String jsonValue) {
-            return State.valueOf(jsonValue.toUpperCase());
+            return State.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONValue() {
diff --git a/src/main/java/com/box/sdk/MetadataQuery.java b/src/main/java/com/box/sdk/MetadataQuery.java
@@ -282,7 +282,7 @@ static OrderBy fromJson(JsonValue jsonValue) {
             if (jsonValue.isObject()) {
                 JsonObject object = jsonValue.asObject();
                 String fieldName = object.get(FIELD_KEY).asString();
-                String direction = object.get(DIRECTION).asString().toLowerCase();
+                String direction = object.get(DIRECTION).asString().toLowerCase(java.util.Locale.ROOT);
                 if (!DIRECTION_ASCENDING.equals(direction) && !DIRECTION_DESCENDING.equals(direction)) {
                     throw new RuntimeException(
                         String.format("Unsupported sort direction [%s] for field [%s]", direction, fieldName)
diff --git a/src/main/java/com/box/sdk/RetentionPolicyParams.java b/src/main/java/com/box/sdk/RetentionPolicyParams.java
@@ -179,7 +179,7 @@ public enum RetentionType {
         }
 
         static RetentionType fromJSONString(String jsonValue) {
-            return RetentionType.valueOf(jsonValue.toUpperCase());
+            return RetentionType.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));
         }
 
         String toJSONString() {
diff --git a/src/main/java/com/box/sdk/internal/utils/JsonUtils.java b/src/main/java/com/box/sdk/internal/utils/JsonUtils.java
@@ -76,7 +76,7 @@ public static void addIfNotNull(JsonObject jsonObject, String propertyName, Long
      */
     public static void addIfNotNull(JsonObject jsonObject, String propertyName, Enum propertyValue) {
         if (propertyValue != null) {
-            jsonObject.add(propertyName, propertyValue.name().toLowerCase());
+            jsonObject.add(propertyName, propertyValue.name().toLowerCase(java.util.Locale.ROOT));
         }
     }
 
diff --git a/src/test/java/com/box/sdk/BoxTaskTest.java b/src/test/java/com/box/sdk/BoxTaskTest.java
@@ -136,7 +136,7 @@ public void testCreateTaskWithActionCompleteSucceeds() {
         BoxTask.Info taskInfo = file.addTask(BoxTask.Action.COMPLETE, taskMessage, null,
             BoxTask.CompletionRule.ALL_ASSIGNEES);
 
-        assertEquals(BoxTask.Action.COMPLETE.toString().toLowerCase(), taskInfo.getTaskType());
+        assertEquals(BoxTask.Action.COMPLETE.toString().toLowerCase(java.util.Locale.ROOT), taskInfo.getTaskType());
         assertEquals(fileID, taskInfo.getItem().getID());
         assertEquals(taskID, taskInfo.getID());
         assertEquals(taskMessage, taskInfo.getMessage());
diff --git a/src/test/java/com/box/sdk/BoxUserTest.java b/src/test/java/com/box/sdk/BoxUserTest.java
@@ -30,6 +30,7 @@
 import java.util.Collection;
 import java.util.HashMap;
 import java.util.Iterator;
+import java.util.Locale;
 import java.util.Map;
 import org.hamcrest.CoreMatchers;
 import org.junit.Before;
@@ -89,8 +90,7 @@ public void downloadAvatar() throws IOException {
         assertArrayEquals(fileByteArray, output.toByteArray());
     }
 
-    @Test
-    public void testGetCurrentUserInfoSucceeds() {
+    private void getCurrentUserTest() {
         final String userURL = "/2.0/users/me";
         final String userInfoURL = "/2.0/users/12345";
         final String userName = "Test User";
@@ -113,6 +113,17 @@ public void testGetCurrentUserInfoSucceeds() {
         assertEquals(userphoneNumber, info.getPhone());
     }
 
+    @Test
+    public void testGetCurrentUserInfoSucceeds() {
+        getCurrentUserTest();
+    }
+
+    @Test
+    public void testGetCurrentUserInfoOnNonUsLocaleSucceeds() {
+        Locale.setDefault(new Locale("tr", "TR"));
+        getCurrentUserTest();
+    }
+
     @Test
     public void testGetUserInfoByIDSucceeds() {
         final String userID = "12345";

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ public enum Type {`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`static BoxAIItem.Type fromJSONValue(String jsonValue) {`
`114`		`- return BoxAIItem.Type.valueOf(jsonValue.toUpperCase());`
	`114`	`+ return BoxAIItem.Type.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`String toJSONValue() {`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public enum CollaboratorType {`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`static CollaboratorType fromJSONValue(String jsonValue) {`
`43`		`- return CollaboratorType.valueOf(jsonValue.toUpperCase());`
	`43`	`+ return CollaboratorType.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`String toJSONValue() {`
`@@ -69,7 +69,7 @@ public enum GroupType {`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`static GroupType fromJSONValue(String jsonValue) {`
`72`		`- return GroupType.valueOf(jsonValue.toUpperCase());`
	`72`	`+ return GroupType.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`String toJSONValue() {`
Original file line number	Diff line number	Diff line change
`@@ -1706,7 +1706,7 @@ public enum Permission {`
`1706`	`1706`	`}`
`1707`	`1707`
`1708`	`1708`	`static Permission fromJSONValue(String jsonValue) {`
`1709`		`- return Permission.valueOf(jsonValue.toUpperCase());`
	`1709`	`+ return Permission.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));`
`1710`	`1710`	`}`
`1711`	`1711`
`1712`	`1712`	`String toJSONValue() {`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ public enum Status {`
`151`	`151`	`}`
`152`	`152`
`153`	`153`	`static Status fromJSONString(String jsonValue) {`
`154`		`- return Status.valueOf(jsonValue.toUpperCase());`
	`154`	`+ return Status.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`String toJSONString() {`
Original file line number	Diff line number	Diff line change
`@@ -1387,7 +1387,7 @@ public enum SyncState {`
`1387`	`1387`	`}`
`1388`	`1388`
`1389`	`1389`	`static SyncState fromJSONValue(String jsonValue) {`
`1390`		`- return SyncState.valueOf(jsonValue.toUpperCase());`
	`1390`	`+ return SyncState.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));`
`1391`	`1391`	`}`
`1392`	`1392`
`1393`	`1393`	`String toJSONValue() {`
`@@ -1441,7 +1441,7 @@ public enum Permission {`
`1441`	`1441`	`}`
`1442`	`1442`
`1443`	`1443`	`static Permission fromJSONValue(String jsonValue) {`
`1444`		`- return Permission.valueOf(jsonValue.toUpperCase());`
	`1444`	`+ return Permission.valueOf(jsonValue.toUpperCase(java.util.Locale.ROOT));`
`1445`	`1445`	`}`
`1446`	`1446`
`1447`	`1447`	`String toJSONValue() {`