From c30b069872770e97858c0cd5cc8f04c00ecfcc6a Mon Sep 17 00:00:00 2001 From: mwwoda <84077698+mwwoda@users.noreply.github.com> Date: Tue, 11 Mar 2025 10:56:41 +0100 Subject: [PATCH 1/3] fix: trim content-length header value --- src/main/java/com/box/sdk/BinaryBodyUtils.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/box/sdk/BinaryBodyUtils.java b/src/main/java/com/box/sdk/BinaryBodyUtils.java index 31a31f59c..0d038aa1c 100644 --- a/src/main/java/com/box/sdk/BinaryBodyUtils.java +++ b/src/main/java/com/box/sdk/BinaryBodyUtils.java @@ -101,9 +101,10 @@ private static long getContentLengthFromAPIResponse(BoxAPIResponse response) { if (headerValue != null) { try { - length = Long.parseLong(headerValue); + length = Long.parseLong(headerValue.trim()); } catch (NumberFormatException e) { - throw new RuntimeException("Invalid content length: " + headerValue); + throw new RuntimeException("Invalid content length: " + headerValue.trim() + "with: " + + headerValue.trim().length() + "number of characters."); } } } From 8d4b486760ea4400e85e3b608c736c0316d9f4b1 Mon Sep 17 00:00:00 2001 From: mwwoda <84077698+mwwoda@users.noreply.github.com> Date: Tue, 11 Mar 2025 10:57:30 +0100 Subject: [PATCH 2/3] add whitespace --- src/main/java/com/box/sdk/BinaryBodyUtils.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/box/sdk/BinaryBodyUtils.java b/src/main/java/com/box/sdk/BinaryBodyUtils.java index 0d038aa1c..6212b0b8e 100644 --- a/src/main/java/com/box/sdk/BinaryBodyUtils.java +++ b/src/main/java/com/box/sdk/BinaryBodyUtils.java @@ -103,8 +103,8 @@ private static long getContentLengthFromAPIResponse(BoxAPIResponse response) { try { length = Long.parseLong(headerValue.trim()); } catch (NumberFormatException e) { - throw new RuntimeException("Invalid content length: " + headerValue.trim() + "with: " - + headerValue.trim().length() + "number of characters."); + throw new RuntimeException("Invalid content length: " + headerValue.trim() + " with: " + + headerValue.trim().length() + " number of characters."); } } } From 123124c53b0fb41ff1e736fd43fdd26aa08bd85f Mon Sep 17 00:00:00 2001 From: mwwoda <84077698+mwwoda@users.noreply.github.com> Date: Tue, 11 Mar 2025 16:37:01 +0100 Subject: [PATCH 3/3] extract to a variable --- src/main/java/com/box/sdk/BinaryBodyUtils.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/box/sdk/BinaryBodyUtils.java b/src/main/java/com/box/sdk/BinaryBodyUtils.java index 6212b0b8e..2873d8c00 100644 --- a/src/main/java/com/box/sdk/BinaryBodyUtils.java +++ b/src/main/java/com/box/sdk/BinaryBodyUtils.java @@ -100,11 +100,12 @@ private static long getContentLengthFromAPIResponse(BoxAPIResponse response) { } if (headerValue != null) { + String trimmedHeaderValue = headerValue.trim(); try { - length = Long.parseLong(headerValue.trim()); + length = Long.parseLong(trimmedHeaderValue); } catch (NumberFormatException e) { - throw new RuntimeException("Invalid content length: " + headerValue.trim() + " with: " - + headerValue.trim().length() + " number of characters."); + throw new RuntimeException("Invalid content length: " + trimmedHeaderValue + " with: " + + trimmedHeaderValue.length() + " number of characters."); } } }