Skip to content

Commit 578d9b4

Browse files
fix: remove unused parameter from SignRequest (box/box-openapi#489) (#411)
1 parent d9cff4c commit 578d9b4

File tree

10 files changed

+11
-39
lines changed

10 files changed

+11
-39
lines changed

.codegen.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{ "engineHash": "5604447", "specHash": "c9d7bb5", "version": "1.8.0" }
1+
{ "engineHash": "264bdc9", "specHash": "6886603", "version": "1.8.0" }

box_sdk_gen/managers/sign_requests.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,6 @@ def create_sign_request(
245245
prefill_tags: Optional[List[SignRequestPrefillTag]] = None,
246246
days_valid: Union[Optional[int], NullValue] = None,
247247
external_id: Union[Optional[str], NullValue] = None,
248-
is_phone_verification_required_to_view: Union[Optional[bool], NullValue] = None,
249248
template_id: Union[Optional[str], NullValue] = None,
250249
external_system_name: Union[Optional[str], NullValue] = None,
251250
extra_headers: Optional[Dict[str, Optional[str]]] = None
@@ -290,8 +289,6 @@ def create_sign_request(
290289
:type days_valid: Union[Optional[int], NullValue], optional
291290
:param external_id: This can be used to reference an ID in an external system that the sign request is related to., defaults to None
292291
:type external_id: Union[Optional[str], NullValue], optional
293-
:param is_phone_verification_required_to_view: Forces signers to verify a text message prior to viewing the document. You must specify the phone number of signers to have this setting apply to them., defaults to None
294-
:type is_phone_verification_required_to_view: Union[Optional[bool], NullValue], optional
295292
:param template_id: When a signature request is created from a template this field will indicate the id of that template., defaults to None
296293
:type template_id: Union[Optional[str], NullValue], optional
297294
:param external_system_name: Used as an optional system name to appear in the signature log next to the signers who have been assigned the `embed_url_external_id`., defaults to None
@@ -317,7 +314,6 @@ def create_sign_request(
317314
'prefill_tags': prefill_tags,
318315
'days_valid': days_valid,
319316
'external_id': external_id,
320-
'is_phone_verification_required_to_view': is_phone_verification_required_to_view,
321317
'template_id': template_id,
322318
'external_system_name': external_system_name,
323319
}

box_sdk_gen/schemas/event.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,14 @@ class EventEventTypeField(str, Enum):
6969
DOWNLOAD = 'DOWNLOAD'
7070
EDIT = 'EDIT'
7171
EDIT_USER = 'EDIT_USER'
72+
EDR_CROWDSTRIKE_DEVICE_DETECTED = 'EDR_CROWDSTRIKE_DEVICE_DETECTED'
73+
EDR_CROWDSTRIKE_NO_BOX_TOOLS = 'EDR_CROWDSTRIKE_NO_BOX_TOOLS'
74+
EDR_CROWDSTRIKE_BOX_TOOLS_OUTDATED = 'EDR_CROWDSTRIKE_BOX_TOOLS_OUTDATED'
75+
EDR_CROWDSTRIKE_DRIVE_OUTDATED = 'EDR_CROWDSTRIKE_DRIVE_OUTDATED'
76+
EDR_CROWDSTRIKE_ACCESS_ALLOWED_NO_CROWDSTRIKE_DEVICE = (
77+
'EDR_CROWDSTRIKE_ACCESS_ALLOWED_NO_CROWDSTRIKE_DEVICE'
78+
)
79+
EDR_CROWDSTRIKE_ACCESS_REVOKED = 'EDR_CROWDSTRIKE_ACCESS_REVOKED'
7280
EMAIL_ALIAS_CONFIRM = 'EMAIL_ALIAS_CONFIRM'
7381
EMAIL_ALIAS_REMOVE = 'EMAIL_ALIAS_REMOVE'
7482
ENABLE_TWO_FACTOR_AUTH = 'ENABLE_TWO_FACTOR_AUTH'

box_sdk_gen/schemas/sign_request.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,6 @@ def __init__(
8989
prefill_tags: Optional[List[SignRequestPrefillTag]] = None,
9090
days_valid: Optional[int] = None,
9191
external_id: Optional[str] = None,
92-
is_phone_verification_required_to_view: Optional[bool] = None,
9392
template_id: Optional[str] = None,
9493
external_system_name: Optional[str] = None,
9594
**kwargs
@@ -142,8 +141,6 @@ def __init__(
142141
:type days_valid: Optional[int], optional
143142
:param external_id: This can be used to reference an ID in an external system that the sign request is related to., defaults to None
144143
:type external_id: Optional[str], optional
145-
:param is_phone_verification_required_to_view: Forces signers to verify a text message prior to viewing the document. You must specify the phone number of signers to have this setting apply to them., defaults to None
146-
:type is_phone_verification_required_to_view: Optional[bool], optional
147144
:param template_id: When a signature request is created from a template this field will indicate the id of that template., defaults to None
148145
:type template_id: Optional[str], optional
149146
:param external_system_name: Used as an optional system name to appear in the signature log next to the signers who have been assigned the `embed_url_external_id`., defaults to None
@@ -161,7 +158,6 @@ def __init__(
161158
prefill_tags=prefill_tags,
162159
days_valid=days_valid,
163160
external_id=external_id,
164-
is_phone_verification_required_to_view=is_phone_verification_required_to_view,
165161
template_id=template_id,
166162
external_system_name=external_system_name,
167163
**kwargs

box_sdk_gen/schemas/sign_request_base.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ def __init__(
2424
prefill_tags: Optional[List[SignRequestPrefillTag]] = None,
2525
days_valid: Optional[int] = None,
2626
external_id: Optional[str] = None,
27-
is_phone_verification_required_to_view: Optional[bool] = None,
2827
template_id: Optional[str] = None,
2928
external_system_name: Optional[str] = None,
3029
**kwargs
@@ -52,8 +51,6 @@ def __init__(
5251
:type days_valid: Optional[int], optional
5352
:param external_id: This can be used to reference an ID in an external system that the sign request is related to., defaults to None
5453
:type external_id: Optional[str], optional
55-
:param is_phone_verification_required_to_view: Forces signers to verify a text message prior to viewing the document. You must specify the phone number of signers to have this setting apply to them., defaults to None
56-
:type is_phone_verification_required_to_view: Optional[bool], optional
5754
:param template_id: When a signature request is created from a template this field will indicate the id of that template., defaults to None
5855
:type template_id: Optional[str], optional
5956
:param external_system_name: Used as an optional system name to appear in the signature log next to the signers who have been assigned the `embed_url_external_id`., defaults to None
@@ -71,8 +68,5 @@ def __init__(
7168
self.prefill_tags = prefill_tags
7269
self.days_valid = days_valid
7370
self.external_id = external_id
74-
self.is_phone_verification_required_to_view = (
75-
is_phone_verification_required_to_view
76-
)
7771
self.template_id = template_id
7872
self.external_system_name = external_system_name

box_sdk_gen/schemas/sign_request_create_request.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ def __init__(
4242
prefill_tags: Optional[List[SignRequestPrefillTag]] = None,
4343
days_valid: Optional[int] = None,
4444
external_id: Optional[str] = None,
45-
is_phone_verification_required_to_view: Optional[bool] = None,
4645
template_id: Optional[str] = None,
4746
external_system_name: Optional[str] = None,
4847
**kwargs
@@ -83,8 +82,6 @@ def __init__(
8382
:type days_valid: Optional[int], optional
8483
:param external_id: This can be used to reference an ID in an external system that the sign request is related to., defaults to None
8584
:type external_id: Optional[str], optional
86-
:param is_phone_verification_required_to_view: Forces signers to verify a text message prior to viewing the document. You must specify the phone number of signers to have this setting apply to them., defaults to None
87-
:type is_phone_verification_required_to_view: Optional[bool], optional
8885
:param template_id: When a signature request is created from a template this field will indicate the id of that template., defaults to None
8986
:type template_id: Optional[str], optional
9087
:param external_system_name: Used as an optional system name to appear in the signature log next to the signers who have been assigned the `embed_url_external_id`., defaults to None
@@ -102,7 +99,6 @@ def __init__(
10299
prefill_tags=prefill_tags,
103100
days_valid=days_valid,
104101
external_id=external_id,
105-
is_phone_verification_required_to_view=is_phone_verification_required_to_view,
106102
template_id=template_id,
107103
external_system_name=external_system_name,
108104
**kwargs

box_sdk_gen/schemas/sign_request_create_signer.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ def __init__(
2525
redirect_url: Optional[str] = None,
2626
declined_redirect_url: Optional[str] = None,
2727
login_required: Optional[bool] = None,
28-
verification_phone_number: Optional[str] = None,
2928
password: Optional[str] = None,
3029
signer_group_id: Optional[str] = None,
3130
suppress_notifications: Optional[bool] = None,
@@ -63,13 +62,8 @@ def __init__(
6362
:param login_required: If set to true, the signer will need to log in to a Box account
6463
before signing the request. If the signer does not have
6564
an existing account, they will have the option to create
66-
a free Box account. Cannot be selected in combination with
67-
`verification_phone_number`., defaults to None
65+
a free Box account., defaults to None
6866
:type login_required: Optional[bool], optional
69-
:param verification_phone_number: If set, this phone number will be used to verify the signer
70-
via two-factor authentication before they are able to sign the document.
71-
Cannot be selected in combination with `login_required`., defaults to None
72-
:type verification_phone_number: Optional[str], optional
7367
:param password: If set, the signer is required to enter the password before they are able
7468
to sign a document. This field is write only., defaults to None
7569
:type password: Optional[str], optional
@@ -93,7 +87,6 @@ def __init__(
9387
self.redirect_url = redirect_url
9488
self.declined_redirect_url = declined_redirect_url
9589
self.login_required = login_required
96-
self.verification_phone_number = verification_phone_number
9790
self.password = password
9891
self.signer_group_id = signer_group_id
9992
self.suppress_notifications = suppress_notifications

box_sdk_gen/schemas/sign_request_signer.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ def __init__(
6666
redirect_url: Optional[str] = None,
6767
declined_redirect_url: Optional[str] = None,
6868
login_required: Optional[bool] = None,
69-
verification_phone_number: Optional[str] = None,
7069
password: Optional[str] = None,
7170
signer_group_id: Optional[str] = None,
7271
suppress_notifications: Optional[bool] = None,
@@ -117,13 +116,8 @@ def __init__(
117116
:param login_required: If set to true, the signer will need to log in to a Box account
118117
before signing the request. If the signer does not have
119118
an existing account, they will have the option to create
120-
a free Box account. Cannot be selected in combination with
121-
`verification_phone_number`., defaults to None
119+
a free Box account., defaults to None
122120
:type login_required: Optional[bool], optional
123-
:param verification_phone_number: If set, this phone number will be used to verify the signer
124-
via two-factor authentication before they are able to sign the document.
125-
Cannot be selected in combination with `login_required`., defaults to None
126-
:type verification_phone_number: Optional[str], optional
127121
:param password: If set, the signer is required to enter the password before they are able
128122
to sign a document. This field is write only., defaults to None
129123
:type password: Optional[str], optional
@@ -147,7 +141,6 @@ def __init__(
147141
redirect_url=redirect_url,
148142
declined_redirect_url=declined_redirect_url,
149143
login_required=login_required,
150-
verification_phone_number=verification_phone_number,
151144
password=password,
152145
signer_group_id=signer_group_id,
153146
suppress_notifications=suppress_notifications,

docs/sign_requests.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,6 @@ client.sign_requests.create_sign_request(
173173
- Set the number of days after which the created signature request will automatically expire if not completed. By default, we do not apply any expiration date on signature requests, and the signature request does not expire.
174174
- external_id `Optional[str]`
175175
- This can be used to reference an ID in an external system that the sign request is related to.
176-
- is_phone_verification_required_to_view `Optional[bool]`
177-
- Forces signers to verify a text message prior to viewing the document. You must specify the phone number of signers to have this setting apply to them.
178176
- template_id `Optional[str]`
179177
- When a signature request is created from a template this field will indicate the id of that template.
180178
- external_system_name `Optional[str]`

test/sign_requests.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ def testCreateGetCancelAndListSignRequest():
7171
],
7272
days_valid=30,
7373
external_id='123',
74-
is_phone_verification_required_to_view=False,
7574
external_system_name='BoxSignIntegration',
7675
)
7776
assert created_sign_request.are_reminders_enabled == True
@@ -83,7 +82,6 @@ def testCreateGetCancelAndListSignRequest():
8382
assert created_sign_request.external_id == '123'
8483
assert created_sign_request.external_system_name == 'BoxSignIntegration'
8584
assert created_sign_request.is_document_preparation_needed == False
86-
assert created_sign_request.is_phone_verification_required_to_view == False
8785
assert created_sign_request.name == 'Sign Request'
8886
assert created_sign_request.redirect_url == 'https://www.box.com'
8987
assert created_sign_request.sign_files.files[0].name == file_to_sign.name

0 commit comments

Comments
 (0)