Skip to content

Commit a55cbc6

Browse files
authored
Fix Travis CI for Python 2 and Pylint (#608)
1 parent 5874933 commit a55cbc6

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

boxsdk/object/file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,7 @@ def get_thumbnail_representation(self, dimensions, extension='png'):
785785
"""
786786
rep_hints = '[{0}?dimensions={1}]'.format(extension, dimensions)
787787
representation = self.get_representation_info(rep_hints)
788-
if len(representation):
788+
if representation:
789789
url = representation[0]['content']['url_template']
790790
url = url.replace('{+asset_path}', '')
791791
response = self._session.get(url, expect_json_response=False)

test/unit/object/test_file.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -901,4 +901,4 @@ def test_get_thumbnail_representation_not_found(
901901
headers={'X-Rep-Hints': '[{}?dimensions={}]'.format(extension, dimensions)},
902902
params={'fields': 'representations'},
903903
)
904-
assert b'' == thumb
904+
assert thumb == b''

test/unit/object/test_search.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
import json
66

7+
from mock import ANY
8+
79
import pytest
810

911
from boxsdk.config import API
@@ -375,7 +377,9 @@ def test_metadata_query(
375377
)
376378
item1 = items.next()
377379
item2 = items.next()
378-
mock_box_session.post.assert_called_once_with(expected_url, data=json.dumps(expected_data), headers=expected_headers)
380+
mock_box_session.post.assert_called_once_with(expected_url, data=ANY, headers=expected_headers)
381+
assert dict(json.loads(mock_box_session.post.call_args[1]['data'])) == expected_data
382+
assert mock_box_session.post.call_args[1]['headers'] == expected_headers
379383
assert item1['type'] == 'file'
380384
assert item1['metadata']['enterprise_67890']['catalogImages']['$parent'] == 'file_50347290'
381385
assert item2['type'] == 'folder'

0 commit comments

Comments
 (0)