Skip to content

Commit de604b1

Browse files
committed
Catch requests Timeout instead of urllib3 TimeoutError
1 parent 32bf37a commit de604b1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

boxsdk/object/events.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# coding: utf-8
22

33
from __future__ import unicode_literals
4-
from requests.packages.urllib3.exceptions import TimeoutError
4+
from requests.exceptions import Timeout
55

66
from boxsdk.object.base_endpoint import BaseEndpoint
77
from boxsdk.util.lru_cache import LRUCache
@@ -123,7 +123,7 @@ def generate_events_with_long_polling(self, stream_position=None):
123123
while True:
124124
try:
125125
long_poll_response = self.long_poll(options, stream_position)
126-
except TimeoutError:
126+
except Timeout:
127127
break
128128
else:
129129
message = long_poll_response.json()['message']

test/unit/object/test_events.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
import json
55
from mock import Mock
66
import pytest
7-
from requests.packages.urllib3.exceptions import TimeoutError
7+
from requests.exceptions import Timeout
88
from boxsdk.network.default_network import DefaultNetworkResponse
99
from boxsdk.object.events import Events
1010
from boxsdk.session.box_session import BoxResponse
@@ -128,7 +128,7 @@ def test_generate_events_with_long_polling(
128128
mock_box_session.options.return_value = options_response
129129
mock_box_session.get.side_effect = [
130130
events_response, # initial call to get now stream position
131-
TimeoutError,
131+
Timeout,
132132
reconnect_long_poll_response,
133133
max_retries_long_poll_response,
134134
new_change_long_poll_response,

0 commit comments

Comments
 (0)