fix: Replace defaultProps with inline defaults

jfox-box · jfox-box · commit 5a3f73a8836d · 2025-12-05T14:10:42.000-08:00
diff --git a/src/components/media/MediaFigure.js.flow b/src/components/media/MediaFigure.js.flow
@@ -22,7 +22,7 @@ const MediaFigure = ({ as: Wrapper, className, children, ...rest }: Props) => (
 // that affects union types
 // https://github.com/facebook/flow/issues/5461
 MediaFigure.defaultProps = {
-    as: 'figure',
+    as: 'div',
 };
 
 export default MediaFigure;
diff --git a/src/components/slide-carousel/SlideCarouselPrimitive.js b/src/components/slide-carousel/SlideCarouselPrimitive.js
@@ -19,10 +19,10 @@ type Props = {
 
 const SlideCarouselPrimitive = ({
     children,
-    className,
+    className = '',
     contentHeight,
     idPrefix = '',
-    onSelection,
+    onSelection = () => {},
     selectedIndex,
     title,
 }: Props) => {
@@ -54,10 +54,4 @@ const SlideCarouselPrimitive = ({
 
 SlideCarouselPrimitive.displayName = 'SlideCarouselPrimitive';
 
-SlideCarouselPrimitive.defaultProps = {
-    className: '',
-    idPrefix: '',
-    onSelection: () => {},
-};
-
 export default SlideCarouselPrimitive;
diff --git a/src/elements/content-sidebar/SidebarContent.js b/src/elements/content-sidebar/SidebarContent.js
@@ -17,7 +17,16 @@ type Props = {
     title?: React.Node,
     subheader?: React.Node,
 };
-const SidebarContent = ({ actions, children, className, elementId, sidebarView, title, subheader, ...rest }: Props) => {
+const SidebarContent = ({
+    actions,
+    children,
+    className,
+    elementId = '',
+    sidebarView = '',
+    title,
+    subheader,
+    ...rest
+}: Props) => {
     const label = `${elementId}${elementId === '' ? '' : '_'}${sidebarView}`;
     const id = `${label}-content`;
 
@@ -42,9 +51,4 @@ const SidebarContent = ({ actions, children, className, elementId, sidebarView,
     );
 };
 
-SidebarContent.defaultProps = {
-    elementId: '',
-    sidebarView: '',
-};
-
 export default SidebarContent;
diff --git a/src/elements/content-sidebar/__tests__/__snapshots__/ActivitySidebar.test.js.snap b/src/elements/content-sidebar/__tests__/__snapshots__/ActivitySidebar.test.js.snap
@@ -23,7 +23,6 @@ exports[`elements/content-sidebar/ActivitySidebar render() should render the act
     </React.Fragment>
   }
   className="bcs-activity"
-  elementId=""
   sidebarView="activity"
   title={
     <FormattedMessage
diff --git a/src/elements/content-sidebar/__tests__/__snapshots__/DetailsSidebar.test.js.snap b/src/elements/content-sidebar/__tests__/__snapshots__/DetailsSidebar.test.js.snap
@@ -3,7 +3,6 @@
 exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsSidebar with access stats 1`] = `
 <SidebarContent
   className="bcs-details"
-  elementId=""
   sidebarView="details"
   title={
     <FormattedMessage
@@ -26,7 +25,6 @@ exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsS
 exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsSidebar with all components 1`] = `
 <SidebarContent
   className="bcs-details"
-  elementId=""
   sidebarView="details"
   title={
     <FormattedMessage
@@ -107,7 +105,6 @@ exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsS
 exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsSidebar with notices 1`] = `
 <SidebarContent
   className="bcs-details"
-  elementId=""
   sidebarView="details"
   title={
     <FormattedMessage
@@ -134,7 +131,6 @@ exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsS
 exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsSidebar with properties 1`] = `
 <SidebarContent
   className="bcs-details"
-  elementId=""
   sidebarView="details"
   title={
     <FormattedMessage
@@ -172,7 +168,6 @@ exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsS
 exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsSidebar with versions 1`] = `
 <SidebarContent
   className="bcs-details"
-  elementId=""
   sidebarView="details"
   title={
     <FormattedMessage
@@ -186,7 +181,6 @@ exports[`elements/content-sidebar/DetailsSidebar render() should render DetailsS
 exports[`elements/content-sidebar/DetailsSidebar render() should render an empty container if there is no file information 1`] = `
 <SidebarContent
   className="bcs-details"
-  elementId=""
   sidebarView="details"
   title={
     <FormattedMessage
diff --git a/src/elements/content-sidebar/__tests__/__snapshots__/MetadataSidebar.test.js.snap b/src/elements/content-sidebar/__tests__/__snapshots__/MetadataSidebar.test.js.snap
@@ -4,7 +4,6 @@ exports[`elements/content-sidebar/Metadata/MetadataSidebar should render Metadat
 <SidebarContent
   actions={null}
   className="bcs-metadata"
-  elementId=""
   sidebarView="metadata"
   title={
     <FormattedMessage
@@ -35,7 +34,6 @@ exports[`elements/content-sidebar/Metadata/MetadataSidebar should render Metadat
 <SidebarContent
   actions={null}
   className="bcs-metadata"
-  elementId=""
   sidebarView="metadata"
   title={
     <FormattedMessage
@@ -71,7 +69,6 @@ exports[`elements/content-sidebar/Metadata/MetadataSidebar should render Metadat
     />
   }
   className="bcs-metadata"
-  elementId=""
   sidebarView="metadata"
   title={
     <FormattedMessage
@@ -102,7 +99,6 @@ exports[`elements/content-sidebar/Metadata/MetadataSidebar should render error w
 <SidebarContent
   actions={null}
   className="bcs-metadata"
-  elementId=""
   sidebarView="metadata"
   title={
     <FormattedMessage
@@ -128,7 +124,6 @@ exports[`elements/content-sidebar/Metadata/MetadataSidebar should render loading
 <SidebarContent
   actions={null}
   className="bcs-metadata"
-  elementId=""
   sidebarView="metadata"
   title={
     <FormattedMessage
@@ -145,7 +140,6 @@ exports[`elements/content-sidebar/Metadata/MetadataSidebar should render loading
 <SidebarContent
   actions={null}
   className="bcs-metadata"
-  elementId=""
   sidebarView="metadata"
   title={
     <FormattedMessage
@@ -162,7 +156,6 @@ exports[`elements/content-sidebar/Metadata/MetadataSidebar should render loading
 <SidebarContent
   actions={null}
   className="bcs-metadata"
-  elementId=""
   sidebarView="metadata"
   title={
     <FormattedMessage
diff --git a/src/elements/content-sidebar/__tests__/__snapshots__/SkillsSidebar.test.js.snap b/src/elements/content-sidebar/__tests__/__snapshots__/SkillsSidebar.test.js.snap
@@ -3,7 +3,6 @@
 exports[`elements/content-sidebar/Skills/SkillsSidebar should render loading indicator component when cards are not available 1`] = `
 <SidebarContent
   className="bcs-skills"
-  elementId=""
   sidebarView="skills"
   title={
     <FormattedMessage
@@ -19,7 +18,6 @@ exports[`elements/content-sidebar/Skills/SkillsSidebar should render loading ind
 exports[`elements/content-sidebar/Skills/SkillsSidebar should render skills sidebar component when cards are available 1`] = `
 <SidebarContent
   className="bcs-skills"
-  elementId=""
   sidebarView="skills"
   title={
     <FormattedMessage
diff --git a/src/features/classification/ClassifiedBadge.js b/src/features/classification/ClassifiedBadge.js
@@ -19,7 +19,13 @@ type Props = {
 
 const ICON_SIZE = 12;
 
-const ClassifiedBadge = ({ color, name, onClick, tooltipPosition = 'bottom-center', tooltipText }: Props) => {
+const ClassifiedBadge = ({
+    color = bdlYellow50,
+    name,
+    onClick,
+    tooltipPosition = 'bottom-center',
+    tooltipText,
+}: Props) => {
     const isClickable = typeof onClick === 'function';
     const isTooltipDisabled = !tooltipText;
     const badge = (
@@ -48,8 +54,4 @@ const ClassifiedBadge = ({ color, name, onClick, tooltipPosition = 'bottom-cente
     );
 };
 
-ClassifiedBadge.defaultProps = {
-    color: bdlYellow50,
-};
-
 export default ClassifiedBadge;
diff --git a/src/features/classification/security-controls/SecurityControlsModal.js b/src/features/classification/security-controls/SecurityControlsModal.js
@@ -28,9 +28,9 @@ const SecurityControlsModal = ({
     definition,
     classificationColor,
     classificationName,
-    isSecurityControlsModalOpen,
+    isSecurityControlsModalOpen = false,
     itemName,
-    modalItems,
+    modalItems = [],
 }: Props) => {
     if (!itemName || !classificationName || !definition) {
         return null;
@@ -66,9 +66,4 @@ const SecurityControlsModal = ({
     );
 };
 
-SecurityControlsModal.defaultProps = {
-    isSecurityControlsModalOpen: false,
-    modalItems: [],
-};
-
 export default SecurityControlsModal;
diff --git a/src/features/classification/security-controls/__tests__/__snapshots__/SecurityControlsModal.test.js.snap b/src/features/classification/security-controls/__tests__/__snapshots__/SecurityControlsModal.test.js.snap
@@ -30,7 +30,6 @@ exports[`features/classification/security-controls/SecurityControlsModal should
     />
   </p>
   <ClassifiedBadge
-    color="#ffeb7f"
     name="internal"
   />
   <Label
diff --git a/src/features/item-details/VersionHistoryLink.js b/src/features/item-details/VersionHistoryLink.js
@@ -15,7 +15,7 @@ type Props = {
     versionCount: number,
 };
 
-const VersionHistoryLink = ({ className, versionCount, onClick, ...rest }: Props) => {
+const VersionHistoryLink = ({ className = '', versionCount, onClick, ...rest }: Props) => {
     const formattedMessageComponent = <FormattedMessage {...messages.savedVersions} values={{ versionCount }} />;
 
     // Only render it as a link if there is an onClick
@@ -30,8 +30,4 @@ const VersionHistoryLink = ({ className, versionCount, onClick, ...rest }: Props
     return <div className={className}>{formattedMessageComponent}</div>;
 };
 
-VersionHistoryLink.defaultProps = {
-    className: '',
-};
-
 export default VersionHistoryLink;
diff --git a/src/features/presence/PresenceAvatar.js b/src/features/presence/PresenceAvatar.js
@@ -7,7 +7,7 @@ import Avatar from '../../components/avatar';
 const PresenceAvatar = ({
     avatarUrl,
     id,
-    isActive,
+    isActive = false,
     name,
     onMouseEnter,
     onMouseLeave,
@@ -44,8 +44,4 @@ PresenceAvatar.propTypes = {
     isDropDownAvatar: PropTypes.bool,
 };
 
-PresenceAvatar.defaultProps = {
-    isActive: false,
-};
-
 export default PresenceAvatar;
diff --git a/src/features/quick-search/QuickSearchMessage.js b/src/features/quick-search/QuickSearchMessage.js
@@ -11,7 +11,7 @@ type Props = {
     isShown: boolean,
 };
 
-const QuickSearchMessage = ({ children, isShown }: Props) => {
+const QuickSearchMessage = ({ children, isShown = false }: Props) => {
     const className = classNames('overlay-wrapper', { 'is-visible': isShown }, 'quick-search-message');
 
     return (
@@ -21,8 +21,4 @@ const QuickSearchMessage = ({ children, isShown }: Props) => {
     );
 };
 
-QuickSearchMessage.defaultProps = {
-    isShown: false,
-};
-
 export default QuickSearchMessage;
diff --git a/src/features/security/SecurityBadge.js b/src/features/security/SecurityBadge.js
@@ -14,15 +14,17 @@ type Props = {
     strokeColor?: string,
 };
 
-const SecurityBadge = ({ className, color, icon, message, ...rest }: Props) => (
+const SecurityBadge = ({
+    className,
+    color,
+    icon = <IconAlertDefault color={bdlYellow50} height={22} width={22} strokeWidth={3} />,
+    message,
+    ...rest
+}: Props) => (
     <h1 className={classNames('bdl-SecurityBadge', className)} style={{ backgroundColor: color }} {...rest}>
         {icon}
         <span className="bdl-SecurityBadge-name">{message}</span>
     </h1>
 );
 
-SecurityBadge.defaultProps = {
-    icon: <IconAlertDefault color={bdlYellow50} height={22} width={22} strokeWidth={3} />,
-};
-
 export default SecurityBadge;
diff --git a/src/features/unified-share-modal/ContactRestrictionNotice.js b/src/features/unified-share-modal/ContactRestrictionNotice.js
@@ -69,9 +69,9 @@ const ContactRestrictionNotice = ({
     intl,
     isFetchingJustificationReasons,
     isRestrictionJustificationEnabled,
-    justificationReasons,
-    onRemoveRestrictedContacts,
-    onSelectJustificationReason,
+    justificationReasons = [],
+    onRemoveRestrictedContacts = noop,
+    onSelectJustificationReason = noop,
     restrictedEmails,
     restrictedGroups,
     selectedContacts,
@@ -168,11 +168,5 @@ const ContactRestrictionNotice = ({
 
 ContactRestrictionNotice.displayName = 'ContactRestrictionNotice';
 
-ContactRestrictionNotice.defaultProps = {
-    justificationReasons: [],
-    onRemoveRestrictedContacts: noop,
-    onSelectJustificationReason: noop,
-};
-
 export { ContactRestrictionNotice as ContactRestrictionNoticeComponent };
 export default injectIntl(ContactRestrictionNotice);
diff --git a/src/features/virtualized-table/DraggableVirtualizedTable.js b/src/features/virtualized-table/DraggableVirtualizedTable.js
@@ -29,9 +29,9 @@ type Props = VirtualizedTableProps & {
 const DraggableVirtualizedTable = ({
     children,
     className,
-    onDragEnd,
+    onDragEnd = noop,
     rowData,
-    shouldShowDragHandle,
+    shouldShowDragHandle = true,
     tableId,
     ...rest
 }: Props) => {
@@ -84,9 +84,4 @@ const DraggableVirtualizedTable = ({
 
 DraggableVirtualizedTable.displayName = 'DraggableVirtualizedTable';
 
-DraggableVirtualizedTable.defaultProps = {
-    onDragEnd: noop,
-    shouldShowDragHandle: true,
-};
-
 export default DraggableVirtualizedTable;

Original file line number	Diff line number	Diff line change
@@ -23,7 +23,6 @@ exports[`elements/content-sidebar/ActivitySidebar render() should render the act
`23`	`23`	`</React.Fragment>`
`24`	`24`	`}`
`25`	`25`	`className="bcs-activity"`
`26`		`- elementId=""`
`27`	`26`	`sidebarView="activity"`
`28`	`27`	`title={`
`29`	`28`	`<FormattedMessage`