fix: nits

Author: reneshen0328

i18n/en-US.properties

@@ -149,9 +149,9 @@ be.contentSharing.noAccessError = You do not have access to this item.
 # Message that appears when the item for the ContentSharing Element cannot be found.
 be.contentSharing.notFoundError = Could not find shared link for this item.
 # Message that appears when collaborators cannot be added to the shared link in the ContentSharing Element.
-be.contentSharing.sendInvitationsError = { count, plural, one { Failed to invite a collaborator. } other { Failed to invite {count} collaborators. }}
+be.contentSharing.sendInvitationsError = {count, plural, one {Failed to invite a collaborator.} other {Failed to invite {count} collaborators.}}
 # Message that appears when collaborators were added to the shared link in the ContentSharing Element.
-be.contentSharing.sendInvitationsSuccess = { count, plural, one { Successfully invited a collaborator. } other { Successfully invited {count} collaborators. }}
+be.contentSharing.sendInvitationsSuccess = {count, plural, one {Successfully invited a collaborator.} other {Successfully invited {count} collaborators.}}
 # Message that appears when collaborators cannot be added to the shared link in the ContentSharing Element.
 be.contentSharing.sendInvitesError = Could not send invites.
 # Message that appears when collaborators were added to the shared link in the ContentSharing Element.

src/elements/content-sharing/hooks/useSharingService.ts

@@ -101,24 +101,26 @@ export const useSharingService = ({
         transformRequest: data => convertCollabsRequest(data, collaborators),
     });
 
-    const sendInvitations = (...args) => {
-        return handleSendInvitations(...args).then(result => {
-            if (!result || args[0].contacts.length === 0) {
+    const sendInvitations = (...request) => {
+        return handleSendInvitations(...request).then(response => {
+            const { contacts: collabRequest } = request[0];
+            if (!response || !collabRequest || collabRequest.length === 0) {
                 return null;
             }
 
+            const successCount = response.length;
+            const errorCount = collabRequest.length - successCount;
+
             const notification = [];
-            if (result.length === 0 || result.length < args[0].contacts.length) {
+            if (errorCount > 0) {
                 notification.push({
-                    text: formatMessage(messages.sendInvitationsError, {
-                        count: args[0].contacts.length - result.length,
-                    }),
+                    text: formatMessage(messages.sendInvitationsError, { count: errorCount }),
                     type: 'error',
                 });
             }
-            if (result.length <= args[0].contacts.length && result.length > 0) {
+            if (successCount > 0) {
                 notification.push({
-                    text: formatMessage(messages.sendInvitationsSuccess, { count: result.length }),
+                    text: formatMessage(messages.sendInvitationsSuccess, { count: successCount }),
                     type: 'success',
                 });
             }

src/elements/content-sharing/messages.js

@@ -61,14 +61,14 @@ const messages = defineMessages({
     },
     sendInvitationsError: {
         defaultMessage:
-            '{ count, plural, one { Failed to invite a collaborator. } other { Failed to invite {count} collaborators. }}',
+            '{count, plural, one {Failed to invite a collaborator.} other {Failed to invite {count} collaborators.}}',
         description:
             'Message that appears when collaborators cannot be added to the shared link in the ContentSharing Element.',
         id: 'be.contentSharing.sendInvitationsError',
     },
     sendInvitationsSuccess: {
         defaultMessage:
-            '{ count, plural, one { Successfully invited a collaborator. } other { Successfully invited {count} collaborators. }}',
+            '{count, plural, one {Successfully invited a collaborator.} other {Successfully invited {count} collaborators.}}',
         description:
             'Message that appears when collaborators were added to the shared link in the ContentSharing Element.',
         id: 'be.contentSharing.sendInvitationsSuccess',