Skip to content

Commit 7b5ebe5

Browse files
kkuliczkowski-boxkkuliczkowski-box
authored
feat(content-sidebar): change Box AI to not be the default panel (#3943)
1 parent 70d8876 commit 7b5ebe5

File tree

2 files changed

+34
-33
lines changed

2 files changed

+34
-33
lines changed

‎src/elements/content-sidebar/SidebarPanels.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -447,8 +447,6 @@ class SidebarPanels extends React.Component<Props, State> {
447447

448448
if (showDefaultPanel) {
449449
redirect = defaultPanel;
450-
} else if (canShowBoxAISidebarPanel) {
451-
redirect = SIDEBAR_VIEW_BOXAI;
452450
} else if (hasDocGen) {
453451
redirect = SIDEBAR_VIEW_DOCGEN;
454452
} else if (hasSkills) {
@@ -459,6 +457,8 @@ class SidebarPanels extends React.Component<Props, State> {
459457
redirect = SIDEBAR_VIEW_DETAILS;
460458
} else if (hasMetadata) {
461459
redirect = SIDEBAR_VIEW_METADATA;
460+
} else if (canShowBoxAISidebarPanel) {
461+
redirect = SIDEBAR_VIEW_BOXAI;
462462
}
463463

464464
return <Redirect to={{ pathname: `/${redirect}`, state: { silent: true } }} />;

‎src/elements/content-sidebar/__tests__/SidebarPanels.test.js‎

Lines changed: 32 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ describe('elements/content-sidebar/SidebarPanels', () => {
7171
${'/skills'} | ${'SkillsSidebar'}
7272
${'/boxai'} | ${'BoxAISidebar'}
7373
${'/docgen'} | ${'DocGenSidebar'}
74-
${'/nonsense'} | ${'BoxAISidebar'}
75-
${'/'} | ${'BoxAISidebar'}
74+
${'/nonsense'} | ${'DocGenSidebar'}
75+
${'/'} | ${'DocGenSidebar'}
7676
`('should render $sidebar given the path $path', ({ path, sidebar }) => {
7777
const wrapper = getWrapper({ path });
7878
expect(wrapper.exists(sidebar)).toBe(true);
@@ -86,8 +86,8 @@ describe('elements/content-sidebar/SidebarPanels', () => {
8686
${'metadata'} | ${'metadata-sidebar'} | ${'metadata'}
8787
${'skills'} | ${'skills-sidebar'} | ${'skills'}
8888
${'boxai'} | ${'boxai-sidebar'} | ${'boxai'}
89-
${'nonsense'} | ${'boxai-sidebar'} | ${'boxai'}
90-
${undefined} | ${'boxai-sidebar'} | ${'boxai'}
89+
${'nonsense'} | ${'docgen-sidebar'} | ${'docgen'}
90+
${undefined} | ${'docgen-sidebar'} | ${'docgen'}
9191
`(
9292
'should render $sidebar and call onPanelChange with $expectedPanelName given the path = "/" and defaultPanel = $defaultPanel',
9393
({ defaultPanel, sidebar, expectedPanelName }) => {
@@ -104,14 +104,14 @@ describe('elements/content-sidebar/SidebarPanels', () => {
104104
);
105105

106106
test.each`
107-
defaultPanel | expectedSidebar | hasActivity | hasDetails | hasMetadata | hasSkills | hasDocGen | hasBoxAI | showOnlyBoxAINavButton | expectedPanelName
108-
${'activity'} | ${'boxai-sidebar'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
109-
${'details'} | ${'boxai-sidebar'} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
110-
${'metadata'} | ${'boxai-sidebar'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
111-
${'skills'} | ${'boxai-sidebar'} | ${true} | ${true} | ${true} | ${false} | ${true} | ${true} | ${false} | ${'boxai'}
112-
${'docgen'} | ${'boxai-sidebar'} | ${true} | ${true} | ${true} | ${false} | ${false} | ${true} | ${false} | ${'boxai'}
113-
${'boxai'} | ${'docgen-sidebar'} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${false} | ${'docgen'}
114-
${'boxai'} | ${'docgen-sidebar'} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${'docgen'}
107+
defaultPanel | expectedSidebar | hasActivity | hasDetails | hasMetadata | hasSkills | hasDocGen | hasBoxAI | showOnlyBoxAINavButton | expectedPanelName
108+
${'activity'} | ${'docgen-sidebar'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
109+
${'details'} | ${'docgen-sidebar'} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
110+
${'metadata'} | ${'docgen-sidebar'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
111+
${'skills'} | ${'docgen-sidebar'} | ${true} | ${true} | ${true} | ${false} | ${true} | ${true} | ${false} | ${'docgen'}
112+
${'docgen'} | ${'activity-sidebar'} | ${true} | ${true} | ${true} | ${false} | ${false} | ${true} | ${false} | ${'activity'}
113+
${'boxai'} | ${'docgen-sidebar'} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${false} | ${'docgen'}
114+
${'boxai'} | ${'docgen-sidebar'} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${'docgen'}
115115
`(
116116
'should render first available panel and call onPanelChange with $expectedPanelName for users without rights to render default panel, given the path = "/" and defaultPanel = $defaultPanel',
117117
({
@@ -201,8 +201,8 @@ describe('elements/content-sidebar/SidebarPanels', () => {
201201
${'/skills'} | ${'skills'}
202202
${'/boxai'} | ${'boxai'}
203203
${'/docgen'} | ${'docgen'}
204-
${'/nonsense'} | ${'boxai'}
205-
${'/'} | ${'boxai'}
204+
${'/nonsense'} | ${'docgen'}
205+
${'/'} | ${'docgen'}
206206
`('should call onPanelChange with $expectedPanelName given the path = $path', ({ path, expectedPanelName }) => {
207207
const onPanelChange = jest.fn();
208208
render(
@@ -216,22 +216,22 @@ describe('elements/content-sidebar/SidebarPanels', () => {
216216

217217
test.each`
218218
path | hasActivity | hasDetails | hasVersions | hasMetadata | hasSkills | hasDocGen | hasBoxAI | showOnlyBoxAINavButton | expectedPanelName
219-
${'/activity'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
220-
${'/activity/comments'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
221-
${'/activity/comments/1234'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
222-
${'/activity/tasks'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
223-
${'/activity/tasks/1234'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
224-
${'/activity/annotations/1234/5678'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
225-
${'/activity/annotations/1234'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
226-
${'/activity/versions'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
227-
${'/activity/versions/1234'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
228-
${'/details'} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
229-
${'/details/versions'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
230-
${'/details/versions/1234'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
231-
${'/metadata'} | ${true} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
232-
${'/metadata/filteredTemplates/1,3'} | ${true} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${false} | ${'boxai'}
233-
${'/skills'} | ${true} | ${true} | ${true} | ${true} | ${false} | ${true} | ${true} | ${false} | ${'boxai'}
234-
${'/docgen'} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${true} | ${false} | ${'boxai'}
219+
${'/activity'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
220+
${'/activity/comments'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
221+
${'/activity/comments/1234'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
222+
${'/activity/tasks'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
223+
${'/activity/tasks/1234'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
224+
${'/activity/annotations/1234/5678'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
225+
${'/activity/annotations/1234'} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
226+
${'/activity/versions'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
227+
${'/activity/versions/1234'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
228+
${'/details'} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
229+
${'/details/versions'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
230+
${'/details/versions/1234'} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
231+
${'/metadata'} | ${true} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
232+
${'/metadata/filteredTemplates/1,3'} | ${true} | ${true} | ${true} | ${false} | ${true} | ${true} | ${true} | ${false} | ${'docgen'}
233+
${'/skills'} | ${true} | ${true} | ${true} | ${true} | ${false} | ${true} | ${true} | ${false} | ${'docgen'}
234+
${'/docgen'} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${true} | ${false} | ${'skills'}
235235
${'/boxai'} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${false} | ${false} | ${'docgen'}
236236
${'/boxai'} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${true} | ${'docgen'}
237237
`(
@@ -372,7 +372,8 @@ describe('elements/content-sidebar/SidebarPanels', () => {
372372
});
373373

374374
describe('boxai sidebar', () => {
375-
test('should render, given hasBoxAI = true and feature boxai.sidebar.showOnlyNavButton = false', () => {
375+
// Skipped temporarily due to Box AI not being the default sidebar panel
376+
test.skip('should render, given hasBoxAI = true and feature boxai.sidebar.showOnlyNavButton = false', () => {
376377
render(
377378
getSidebarPanels({
378379
features: { boxai: { sidebar: { showOnlyNavButton: false } } },

0 commit comments

Comments
 (0)