Skip to content

Commit 906526f

Browse files
test(grid-view): improve test coverage and accessibility
Co-Authored-By: tjiang@box.com <tjiang@box.com>
1 parent b0936b9 commit 906526f

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

src/components/grid-view/__tests__/GridViewSlider.test.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import React from 'react';
2-
import { render, screen } from '../../../test-utils/testing-library';
2+
import { render, screen, fireEvent } from '../../../test-utils/testing-library';
3+
import type { GridViewSliderProps } from '../GridViewSlider';
34
import GridViewSlider from '../GridViewSlider';
45

56
describe('components/grid-view/GridViewSlider', () => {
6-
const renderComponent = (props = {}) => {
7+
const renderComponent = (props: Partial<GridViewSliderProps> = {}) => {
78
const defaultProps = {
89
columnCount: 4,
910
gridMaxColumns: 7,
@@ -30,7 +31,9 @@ describe('components/grid-view/GridViewSlider', () => {
3031
test('should call onChange when slider value changes', () => {
3132
const onChange = jest.fn();
3233
renderComponent({ onChange });
33-
const slider = screen.getByRole('slider');
34+
const slider = screen.getByRole('slider', { name: 'Grid view size' });
3435
expect(slider).toBeInTheDocument();
36+
fireEvent.change(slider, { target: { value: '5' } });
37+
expect(onChange).toHaveBeenCalled();
3538
});
3639
});

src/components/grid-view/__tests__/__snapshots__/GridViewSlider.test.js.snap

Lines changed: 0 additions & 14 deletions
This file was deleted.

0 commit comments

Comments
 (0)