fix(content-sharing): Add shared link permission can edit option

Author: reneshen0328

src/elements/content-sharing/utils/__tests__/convertItemResponse.test.ts

@@ -1,12 +1,13 @@
 import {
     DEFAULT_ITEM_API_RESPONSE,
-    MOCK_ITEM_API_RESPONSE_WITH_SHARED_LINK,
     MOCK_ITEM_API_RESPONSE_WITH_CLASSIFICATION,
-    mockOwnerId,
+    MOCK_ITEM_API_RESPONSE_WITH_SHARED_LINK,
     mockOwnerEmail,
+    mockOwnerId,
     mockOwnerName,
 } from '../__mocks__/ContentSharingV2Mocks';
 import { convertItemResponse } from '../convertItemResponse';
+import { getAllowedPermissionLevels } from '../getAllowedPermissionLevels';
 
 jest.mock('../getAllowedAccessLevels', () => ({
     getAllowedAccessLevels: jest.fn().mockReturnValue(['open', 'company', 'collaborators']),
@@ -96,6 +97,22 @@ describe('convertItemResponse', () => {
             });
         });
 
+        test('should pass extension to getAllowedPermissionLevels', () => {
+            const MOCK_ITEM_WITH_EXTENSION = {
+                ...MOCK_ITEM_API_RESPONSE_WITH_SHARED_LINK,
+                extension: 'pdf',
+            };
+            convertItemResponse(MOCK_ITEM_WITH_EXTENSION);
+            expect(getAllowedPermissionLevels).toHaveBeenCalledWith({
+                access: 'open',
+                canChangeAccessLevel: true,
+                extension: 'pdf',
+                isDownloadSettingAvailable: true,
+                itemType: 'file',
+                permission: 'can_download',
+            });
+        });
+
         test('should convert shared link settings correctly if user cannot change access level', () => {
             const MOCK_ITEM_API_RESPONSE_WITH_SHARED_LINK_WITH_PERMISSIONS = {
                 ...MOCK_ITEM_API_RESPONSE_WITH_SHARED_LINK,

src/elements/content-sharing/utils/__tests__/convertSharingServiceData.test.ts

@@ -3,6 +3,7 @@ import {
     ACCESS_COMPANY,
     ACCESS_OPEN,
     PERMISSION_CAN_DOWNLOAD,
+    PERMISSION_CAN_EDIT,
     PERMISSION_CAN_PREVIEW,
 } from '../../../../constants';
 import { convertISOStringToUTCDate } from '../../../../utils/datetime';
@@ -22,9 +23,19 @@ describe('elements/content-sharing/utils/convertSharingServiceData', () => {
 
     describe('convertSharedLinkPermissions', () => {
         test.each([
-            [PERMISSION_CAN_DOWNLOAD, { [PERMISSION_CAN_DOWNLOAD]: true, [PERMISSION_CAN_PREVIEW]: false }],
-            [PERMISSION_CAN_PREVIEW, { [PERMISSION_CAN_DOWNLOAD]: false, [PERMISSION_CAN_PREVIEW]: true }],
-        ])('should return correct permissions for download permission level', (permissionLevel, expected) => {
+            [
+                PERMISSION_CAN_DOWNLOAD,
+                { [PERMISSION_CAN_DOWNLOAD]: true, [PERMISSION_CAN_EDIT]: false, [PERMISSION_CAN_PREVIEW]: false },
+            ],
+            [
+                PERMISSION_CAN_EDIT,
+                { [PERMISSION_CAN_DOWNLOAD]: true, [PERMISSION_CAN_EDIT]: true, [PERMISSION_CAN_PREVIEW]: false },
+            ],
+            [
+                PERMISSION_CAN_PREVIEW,
+                { [PERMISSION_CAN_DOWNLOAD]: false, [PERMISSION_CAN_EDIT]: false, [PERMISSION_CAN_PREVIEW]: true },
+            ],
+        ])('should return correct permissions for %s permission level', (permissionLevel, expected) => {
             const result = convertSharedLinkPermissions(permissionLevel);
             expect(result).toEqual(expected);
         });

src/elements/content-sharing/utils/__tests__/getAllowedPermissionLevels.test.ts

@@ -1,28 +1,72 @@
-import { PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW } from '../../../../constants';
+import {
+    ACCESS_OPEN,
+    PERMISSION_CAN_DOWNLOAD,
+    PERMISSION_CAN_EDIT,
+    PERMISSION_CAN_PREVIEW,
+    TYPE_FILE,
+} from '../../../../constants';
+
 import { getAllowedPermissionLevels } from '../getAllowedPermissionLevels';
 
 describe('getAllowedPermissionLevels', () => {
-    test('should return both permission levels when all conditions are met', () => {
-        const result = getAllowedPermissionLevels(true, true, PERMISSION_CAN_DOWNLOAD);
-        expect(result).toEqual([PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW]);
+    const defaultParams = {
+        access: ACCESS_OPEN,
+        canChangeAccessLevel: true,
+        extension: 'pdf',
+        isDownloadSettingAvailable: true,
+        itemType: TYPE_FILE,
+        permission: PERMISSION_CAN_DOWNLOAD,
+    };
+
+    test('should return all permission levels when all conditions are met', () => {
+        const result = getAllowedPermissionLevels(defaultParams);
+        expect(result).toEqual([PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW, PERMISSION_CAN_EDIT]);
     });
 
-    test.each([PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW])(
+    test.each([PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW, PERMISSION_CAN_EDIT])(
         'should return only current permission when cannot change access level',
         permission => {
-            const result = getAllowedPermissionLevels(false, true, permission);
+            const result = getAllowedPermissionLevels({
+                ...defaultParams,
+                canChangeAccessLevel: false,
+                permission,
+            });
             expect(result).toEqual([permission]);
         },
     );
 
     test('should exclude download permission when download setting is not available', () => {
-        const result = getAllowedPermissionLevels(true, false, PERMISSION_CAN_DOWNLOAD);
-        expect(result).toEqual([PERMISSION_CAN_PREVIEW]);
+        const result = getAllowedPermissionLevels({
+            ...defaultParams,
+            isDownloadSettingAvailable: false,
+        });
+        expect(result).toEqual([PERMISSION_CAN_PREVIEW, PERMISSION_CAN_EDIT]);
     });
 
     test('should return empty array for unknown permission values when cannot change access level', () => {
-        const unknownPermission = 'unknown_permission';
-        const result = getAllowedPermissionLevels(false, true, unknownPermission);
+        const result = getAllowedPermissionLevels({
+            ...defaultParams,
+            canChangeAccessLevel: false,
+            permission: 'unknown_permission',
+        });
         expect(result).toEqual([]);
     });
+
+    test.each([
+        [true, true, PERMISSION_CAN_PREVIEW],
+        [true, true, PERMISSION_CAN_DOWNLOAD],
+        [false, true, PERMISSION_CAN_PREVIEW],
+    ])(
+        'should exclude edit permission for webdocs when canChangeAccessLevel=%s, isDownloadSettingAvailable=%s, permission=%s',
+        (canChangeAccessLevel, isDownloadSettingAvailable, permission) => {
+            const result = getAllowedPermissionLevels({
+                ...defaultParams,
+                canChangeAccessLevel,
+                extension: 'webdoc',
+                isDownloadSettingAvailable,
+                permission,
+            });
+            expect(result).not.toContain(PERMISSION_CAN_EDIT);
+        },
+    );
 });

src/elements/content-sharing/utils/convertItemResponse.ts

@@ -11,6 +11,7 @@ export const convertItemResponse = (itemApiData: ContentSharingItemAPIResponse):
         allowed_shared_link_access_levels,
         allowed_shared_link_access_levels_disabled_reasons,
         classification,
+        extension,
         id,
         name,
         owned_by: ownedBy,
@@ -67,7 +68,14 @@ export const convertItemResponse = (itemApiData: ContentSharingItemAPIResponse):
             ),
             expiresAt: expirationTimestamp ? new Date(expirationTimestamp).getTime() : undefined, // convert to milliseconds
             permission,
-            permissionLevels: getAllowedPermissionLevels(canChangeAccessLevel, isDownloadSettingAvailable, permission),
+            permissionLevels: getAllowedPermissionLevels({
+                access,
+                canChangeAccessLevel,
+                extension,
+                isDownloadSettingAvailable,
+                itemType: type,
+                permission,
+            }),
             settings: {
                 canChangeDownload,
                 canChangeExpiration,

src/elements/content-sharing/utils/convertSharingServiceData.ts

@@ -1,4 +1,10 @@
-import { ACCESS_COLLAB, ACCESS_OPEN, PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW } from '../../../constants';
+import {
+    ACCESS_COLLAB,
+    ACCESS_OPEN,
+    PERMISSION_CAN_DOWNLOAD,
+    PERMISSION_CAN_EDIT,
+    PERMISSION_CAN_PREVIEW,
+} from '../../../constants';
 import { convertISOStringToUTCDate } from '../../../utils/datetime';
 
 import type { SharedLinkSettings } from '../types';
@@ -18,8 +24,11 @@ export const convertSharedLinkPermissions = (permissionLevel: string) => {
         return {};
     }
 
+    const isEdit = permissionLevel === PERMISSION_CAN_EDIT;
+
     return {
-        [PERMISSION_CAN_DOWNLOAD]: permissionLevel === PERMISSION_CAN_DOWNLOAD,
+        [PERMISSION_CAN_DOWNLOAD]: isEdit || permissionLevel === PERMISSION_CAN_DOWNLOAD,
+        [PERMISSION_CAN_EDIT]: isEdit,
         [PERMISSION_CAN_PREVIEW]: permissionLevel === PERMISSION_CAN_PREVIEW,
     };
 };

src/elements/content-sharing/utils/getAllowedPermissionLevels.ts

@@ -1,11 +1,30 @@
-import { PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW } from '../../../constants';
+import {
+    ACCESS_COMPANY,
+    ACCESS_OPEN,
+    PERMISSION_CAN_DOWNLOAD,
+    PERMISSION_CAN_EDIT,
+    PERMISSION_CAN_PREVIEW,
+    TYPE_FOLDER,
+} from '../../../constants';
 
-export const getAllowedPermissionLevels = (
+type GetAllowedPermissionLevelsParams = {
+    access: string;
+    canChangeAccessLevel: boolean;
+    extension: string;
+    isDownloadSettingAvailable: boolean;
+    itemType: string;
+    permission: string;
+};
+
+export const getAllowedPermissionLevels = ({
+    access,
     canChangeAccessLevel,
+    extension,
     isDownloadSettingAvailable,
+    itemType,
     permission,
-): Array<string> => {
-    let allowedPermissionLevels = [PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW];
+}: GetAllowedPermissionLevelsParams): Array<string> => {
+    let allowedPermissionLevels = [PERMISSION_CAN_DOWNLOAD, PERMISSION_CAN_PREVIEW, PERMISSION_CAN_EDIT];
 
     if (!canChangeAccessLevel) {
         // remove all but current level
@@ -17,5 +36,11 @@ export const getAllowedPermissionLevels = (
         allowedPermissionLevels = allowedPermissionLevels.filter(level => level !== PERMISSION_CAN_DOWNLOAD);
     }
 
+    // Can Edit requires ACCESS_OPEN or ACCESS_COMPANY, and must NOT be a folder
+    const canEditAccessLevels = [ACCESS_OPEN, ACCESS_COMPANY];
+    if (!canEditAccessLevels.includes(access) || itemType === TYPE_FOLDER || extension?.toLowerCase() === 'webdoc') {
+        allowedPermissionLevels = allowedPermissionLevels.filter(level => level !== PERMISSION_CAN_EDIT);
+    }
+
     return allowedPermissionLevels;
 };