Skip to content

Commit c7748cd

Browse files
fix(content-picker): add waitFor blocks around selection class checks
Co-Authored-By: [email protected] <[email protected]>
1 parent e19af46 commit c7748cd

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

src/elements/content-picker/stories/tests/ContentPicker-visual.stories.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -134,10 +134,9 @@ export const hitSelectionLimit = {
134134

135135
// Select first item and verify visual feedback
136136
await userEvent.click(items[1]);
137-
expect(items[1]).toHaveClass('bcp-item-row-selected');
138-
139-
// Verify selection count and button state
140137
await waitFor(() => {
138+
expect(items[1]).toHaveClass('bcp-item-row-selected');
139+
// Verify selection count and button state
141140
const selectedButton = canvas.getByRole('button', {
142141
name: text => text.includes('1') && text.includes('Selected'),
143142
});
@@ -148,10 +147,9 @@ export const hitSelectionLimit = {
148147

149148
// Select second item to hit limit
150149
await userEvent.click(items[2]);
151-
expect(items[2]).toHaveClass('bcp-item-row-selected');
152-
153-
// Verify max selection state
154150
await waitFor(() => {
151+
expect(items[2]).toHaveClass('bcp-item-row-selected');
152+
// Verify max selection state
155153
const selectedButton = canvas.getByRole('button', { name: /2 Selected/i });
156154
expect(selectedButton).toBeInTheDocument();
157155
expect(canvas.getByText('(max)')).toBeInTheDocument();
@@ -495,13 +493,14 @@ export const multiSelectWithKeyboard = {
495493

496494
// Wait for initial load and verify state
497495
await waitFor(() => {
498-
expect(canvas.getByText('An Ordered Folder')).toBeInTheDocument();
496+
const orderedFolder = canvas.getByRole('button', { name: /An Ordered Folder/i });
497+
expect(orderedFolder).toBeInTheDocument();
499498
expect(canvas.getByRole('button', { name: /0 Selected/i })).toBeInTheDocument();
500499
expect(canvas.getByLabelText('Choose')).toBeDisabled();
501500
});
502501

503502
// Navigate into "An Ordered Folder"
504-
const orderedFolder = await canvas.findByText('An Ordered Folder');
503+
const orderedFolder = canvas.getByRole('button', { name: /An Ordered Folder/i });
505504
await userEvent.dblClick(orderedFolder);
506505

507506
// Wait for folder contents to load

0 commit comments

Comments
 (0)