fix: nits

Author: reneshen0328

src/elements/content-sharing/ContentSharing.js

@@ -116,16 +116,18 @@ function ContentSharing({
 
     if (isFeatureEnabled(features, 'contentSharingV2')) {
         return (
-            <ContentSharingV2
-                api={api}
-                itemID={itemID}
-                itemType={itemType}
-                hasProviders={hasProviders}
-                language={language}
-                messages={messages}
-            >
-                {children}
-            </ContentSharingV2>
+            api && (
+                <ContentSharingV2
+                    api={api}
+                    itemID={itemID}
+                    itemType={itemType}
+                    hasProviders={hasProviders}
+                    language={language}
+                    messages={messages}
+                >
+                    {children}
+                </ContentSharingV2>
+            )
         );
     }
 

src/elements/content-sharing/__tests__/ContentSharingV2.test.tsx

@@ -47,7 +47,7 @@ const getWrapper = (props): RenderResult =>
             itemType={MOCK_ITEM.type}
             hasProviders={true}
             {...props}
-        ></ContentSharingV2>,
+        />,
     );
 
 describe('elements/content-sharing/ContentSharingV2', () => {
@@ -127,6 +127,6 @@ describe('elements/content-sharing/ContentSharingV2', () => {
                 },
             );
         });
-        expect(await screen.findByText('BLUE')).toBeVisible();
+        expect(screen.getByText('BLUE')).toBeVisible();
     });
 });

src/elements/content-sharing/stories/ContentSharing.stories.js

@@ -10,6 +10,8 @@ export const withCustomButton = {
     args: {
         displayInModal: true,
         customButton: <Button>&#10047; Launch ContentSharing &#10047;</Button>,
+        itemID: '1990109255716',
+        token: 'bdcf9zdeDEEILZLw1krLmJRJ3R3HNxpu',
     },
 };
 
@@ -20,6 +22,8 @@ export const withContentSharingV2Enabled = {
             ...global.FEATURE_FLAGS,
             contentSharingV2: true,
         },
+        token: 'bdcf9zdeDEEILZLw1krLmJRJ3R3HNxpu',
+        itemID: '1990109255716',
     },
 };
 

src/elements/content-sharing/utils/convertItemResponse.ts

@@ -13,10 +13,12 @@ export const convertItemResponse = (itemAPIData: ContentSharingItemAPIResponse):
         name,
         permissions,
         shared_link,
-        shared_link_features: { password: isPasswordAvailable },
+        shared_link_features,
         type,
     } = itemAPIData;
 
+    const { password: isPasswordAvailable } = shared_link_features;
+
     const {
         can_download: isDownloadSettingAvailable,
         can_invite_collaborator: canInvite,
@@ -67,7 +69,7 @@ export const convertItemResponse = (itemAPIData: ContentSharingItemAPIResponse):
                 canChangeVanityName: false, // vanity URLs cannot be set via the API,
                 isDownloadAvailable: isDownloadSettingAvailable,
                 isDownloadEnabled: isDownloadAllowed,
-                isPasswordAvailable,
+                isPasswordAvailable: isPasswordAvailable ?? false,
                 isPasswordEnabled,
             },
             url,

src/elements/content-sharing/utils/getAllowedAccessLevels.ts

@@ -2,11 +2,5 @@ import { ACCESS_COLLAB, ACCESS_COMPANY, ACCESS_OPEN } from '../../../constants';
 
 export const getAllowedAccessLevels = (levels?: Array<string>): Array<string> | null => {
     if (!levels) return [ACCESS_OPEN, ACCESS_COMPANY, ACCESS_COLLAB];
-
-    const allowedAccessLevels = [];
-    levels.forEach(level => {
-        allowedAccessLevels.push(level);
-    });
-
-    return allowedAccessLevels;
+    return [...levels];
 };