fix: rollback change permission and access callback changes

Author: reneshen0328

src/elements/content-sharing/__tests__/sharingService.test.ts

@@ -46,10 +46,6 @@ describe('elements/content-sharing/sharingService', () => {
         });
 
         test('should call updateSharedLink with correct parameters when changeSharedLinkPermission is called', async () => {
-            mockItemApiInstance.updateSharedLink.mockImplementation((_options, _access, successCallback) => {
-                successCallback({ id: '123', shared_link: null });
-            });
-
             const service = createSharingServiceWrapper();
             const permissionLevel = PERMISSION_CAN_DOWNLOAD;
             const expectedPermissions = {
@@ -62,8 +58,8 @@ describe('elements/content-sharing/sharingService', () => {
             expect(mockItemApiInstance.updateSharedLink).toHaveBeenCalledWith(
                 options,
                 { permissions: expectedPermissions },
-                expect.any(Function),
-                expect.any(Function),
+                mockOnUpdateSharedLink,
+                {},
                 CONTENT_SHARING_SHARED_LINK_UPDATE_PARAMS,
             );
         });
@@ -79,18 +75,14 @@ describe('elements/content-sharing/sharingService', () => {
         test.each(['open', 'company', 'collaborators'])(
             'should call share with correct parameters when changeSharedLinkAccess is called',
             async access => {
-                mockItemApiInstance.share.mockImplementation((_options, _access, successCallback) => {
-                    successCallback({ id: '123', shared_link: null });
-                });
-
                 const service = createSharingServiceWrapper();
                 await service.changeSharedLinkAccess(access);
 
                 expect(mockItemApiInstance.share).toHaveBeenCalledWith(
                     options,
                     access,
-                    expect.any(Function),
-                    expect.any(Function),
+                    mockOnUpdateSharedLink,
+                    {},
                     CONTENT_SHARING_SHARED_LINK_UPDATE_PARAMS,
                 );
             },
@@ -269,28 +261,6 @@ describe('elements/content-sharing/sharingService', () => {
     });
 
     describe('error handling', () => {
-        test('should reject when changeSharedLinkAccess fails', async () => {
-            const mockError = new Error('Failed to change access');
-            mockItemApiInstance.share.mockImplementation((_options, _access, _successCallback, errorCallback) => {
-                errorCallback(mockError);
-            });
-
-            const service = createSharingServiceWrapper();
-            await expect(service.changeSharedLinkAccess('open')).rejects.toEqual(mockError);
-        });
-
-        test('should reject when changeSharedLinkPermission fails', async () => {
-            const mockError = new Error('Failed to change permission');
-            mockItemApiInstance.updateSharedLink.mockImplementation(
-                (_options, _settings, _successCallback, errorCallback) => {
-                    errorCallback(mockError);
-                },
-            );
-
-            const service = createSharingServiceWrapper();
-            await expect(service.changeSharedLinkPermission(PERMISSION_CAN_DOWNLOAD)).rejects.toEqual(mockError);
-        });
-
         test('should reject when createSharedLink fails', async () => {
             const mockError = new Error('Failed to create shared link');
             mockItemApiInstance.share.mockImplementation((_options, _access, _successCallback, errorCallback) => {

src/elements/content-sharing/sharingService.ts

@@ -35,37 +35,23 @@ export const createSharingService = ({
     const { id, permissions } = options;
 
     const changeSharedLinkAccess = async (access: string): Promise<void> => {
-        return new Promise<void>((resolve, reject) => {
-            itemApiInstance.share(
-                { id, permissions },
-                access,
-                data => {
-                    onUpdateSharedLink(data);
-                    resolve();
-                },
-                error => {
-                    reject(error);
-                },
-                CONTENT_SHARING_SHARED_LINK_UPDATE_PARAMS,
-            );
-        });
+        return itemApiInstance.share(
+            { id, permissions },
+            access,
+            onUpdateSharedLink,
+            {},
+            CONTENT_SHARING_SHARED_LINK_UPDATE_PARAMS,
+        );
     };
 
     const changeSharedLinkPermission = async (permissionLevel: string): Promise<void> => {
-        return new Promise<void>((resolve, reject) => {
-            itemApiInstance.updateSharedLink(
-                { id, permissions },
-                { permissions: convertSharedLinkPermissions(permissionLevel) },
-                data => {
-                    onUpdateSharedLink(data);
-                    resolve();
-                },
-                error => {
-                    reject(error);
-                },
-                CONTENT_SHARING_SHARED_LINK_UPDATE_PARAMS,
-            );
-        });
+        return itemApiInstance.updateSharedLink(
+            { id, permissions },
+            { permissions: convertSharedLinkPermissions(permissionLevel) },
+            onUpdateSharedLink,
+            {},
+            CONTENT_SHARING_SHARED_LINK_UPDATE_PARAMS,
+        );
     };
 
     const updateSharedLink = async (sharedLinkSettings: SharedLinkSettings) => {