Skip to content

Commit d3eb830

Browse files
refactor(content-preview): address PR comments
1 parent a761699 commit d3eb830

File tree

2 files changed

+5
-11
lines changed

2 files changed

+5
-11
lines changed

src/elements/content-preview/preview-header/PreviewHeader.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -36,13 +36,12 @@ export interface PreviewHeaderProps {
3636
token: string | null;
3737
}
3838

39-
// Using proper types for AsyncLoad components without dynamic imports
4039
const LoadableContentAnswers = AsyncLoad({
41-
loader: () => Promise.resolve(null),
42-
}) as React.ComponentType<ContentAnswersProps>;
40+
loader: () => import(/* webpackMode: "lazy", webpackChunkName: "content-answers" */ '../../common/content-answers'),
41+
});
4342
const LoadableContentOpenWith = AsyncLoad({
44-
loader: () => Promise.resolve(null),
45-
}) as React.ComponentType<ContentOpenWithProps>;
43+
loader: () => import(/* webpackMode: "lazy", webpackChunkName: "content-open-with" */ '../../content-open-with'),
44+
});
4645

4746
const PreviewHeader = ({
4847
canAnnotate,
@@ -87,7 +86,6 @@ const PreviewHeader = ({
8786
*/}
8887
<div className="bcpr-PreviewHeader-content bp-header bp-base-header">
8988
{logoUrl ? <Logo url={logoUrl} /> : <FileInfo file={file || null} version={selectedVersion} />}
90-
9189
<div className="bcpr-PreviewHeader-controls">
9290
{isPreviewingCurrentVersion && (
9391
<>
Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,3 @@
1-
/**
2-
* @flow
3-
* @file Preview header component
4-
* @author Box
5-
*/
1+
// @flow
62

73
export { default } from './PreviewHeader';

0 commit comments

Comments
 (0)