chore: Fix ESLint warnings (#617)

Author: arjankowski

src/box-command.js

@@ -300,7 +300,9 @@ class BoxCommand extends Command {
 			// Set up the command for bulk run
 			DEBUG.init('Preparing for bulk input');
 			this.isBulk = true;
+			// eslint-disable-next-line unicorn/prefer-structured-clone
 			originalArgs = _.cloneDeep(this.constructor.args);
+			// eslint-disable-next-line unicorn/prefer-structured-clone
 			originalFlags = _.cloneDeep(this.constructor.flags);
 			this.disableRequiredArgsAndFlags();
 		}
@@ -615,7 +617,7 @@ class BoxCommand extends Command {
 		let parsedData;
 		try {
 			let jsonFile = JSON.parse(fileContents);
-			parsedData = jsonFile.hasOwnProperty('entries')
+			parsedData = Object.hasOwn(jsonFile, 'entries')
 				? jsonFile.entries
 				: jsonFile;
 		} catch (error) {
@@ -651,10 +653,7 @@ class BoxCommand extends Command {
 					// Arrays can be one of two things: an array of values for a single key,
 					// or an array of grouped flags/args as objects
 					// First, check if everything in the array is either all object or all non-object
-					let types = value.reduce(
-						(acc, t) => acc.concat(typeof t),
-						[]
-					);
+					let types = value.map((t) => typeof t);
 					if (
 						types.some((t) => t !== 'object') &&
 						types.includes('object')
@@ -1196,11 +1195,10 @@ class BoxCommand extends Command {
 		if (Array.isArray(content)) {
 			// Format each object individually and then flatten in case this an array of arrays,
 			// which happens when a command that outputs a collection gets run in bulk
-			formattedOutputData = (
-				await Promise.all(
-					content.map((o) => this._formatOutputObject(o))
-				)
-			).flat();
+			const formattedOutputResults = await Promise.all(
+				content.map((o) => this._formatOutputObject(o))
+			);
+			formattedOutputData = formattedOutputResults.flat();
 			DEBUG.output(
 				'Formatted %d output entries for display',
 				content.length
@@ -1649,9 +1647,10 @@ class BoxCommand extends Command {
 		if (!fields) {
 			return output;
 		}
-		fields = REQUIRED_FIELDS.concat(
-			fields.split(',').filter((f) => !REQUIRED_FIELDS.includes(f))
-		);
+		fields = [
+			...REQUIRED_FIELDS,
+			...fields.split(',').filter((f) => !REQUIRED_FIELDS.includes(f)),
+		];
 		DEBUG.output('Filtering output with fields: %O', fields);
 		if (Array.isArray(output)) {
 			output = output.map((o) =>
@@ -1723,7 +1722,7 @@ class BoxCommand extends Command {
 				) {
 					let subKeys = this.getNestedKeys(object[key]);
 					subKeys = subKeys.map((x) => `${key}.${x}`);
-					keys = keys.concat(subKeys);
+					keys = [...keys, ...subKeys];
 				} else {
 					keys.push(key);
 				}
@@ -1757,10 +1756,10 @@ class BoxCommand extends Command {
 				);
 
 				// Successively apply the offsets to the current time
-				newDate = argPairs.reduce(
-					(d, args) => offsetDate(d, ...args),
-					new Date()
-				);
+				newDate = new Date();
+				for (const args of argPairs) {
+					newDate = offsetDate(newDate, ...args);
+				}
 			} else if (time === 'now') {
 				newDate = new Date();
 			} else {

src/commands/collaborations/update.js

@@ -15,7 +15,7 @@ class CollaborationsUpdateCommand extends BoxCommand {
 		if (flags.status) {
 			parameters.body.status = flags.status;
 		}
-		if (flags.hasOwnProperty('can-view-path')) {
+		if (Object.hasOwn(flags, 'can-view-path')) {
 			parameters.body.can_view_path = flags['can-view-path'];
 		}
 		if (flags.role) {

src/commands/configure/environments/add.js

@@ -45,7 +45,7 @@ class EnvironmentsAddCommand extends BoxCommand {
 			cacheTokens: true,
 		};
 
-		if (environmentsObject.environments.hasOwnProperty(environmentName)) {
+		if (Object.hasOwn(environmentsObject.environments, environmentName)) {
 			throw new BoxCLIError(
 				'There already is an environment with this name'
 			);

src/commands/configure/environments/delete.js

@@ -27,7 +27,7 @@ class EnvironmentsDeleteCommand extends BoxCommand {
 			name = answers.environment;
 		}
 
-		if (environmentsObject.environments.hasOwnProperty(name)) {
+		if (Object.hasOwn(environmentsObject.environments, name)) {
 			delete environmentsObject.environments[name];
 			if (environmentsObject.default === name) {
 				environmentsObject.default = '';

src/commands/configure/environments/set-current.js

@@ -22,7 +22,7 @@ class EnvironmentsSetCurrentCommand extends BoxCommand {
 			name = answers.environment;
 		}
 
-		if (environmentsObject.environments.hasOwnProperty(name)) {
+		if (Object.hasOwn(environmentsObject.environments, name)) {
 			environmentsObject.default = name;
 			await this.updateEnvironments(environmentsObject);
 			this.info(`The ${name} environment has been set as the default`);

src/commands/configure/environments/update.js

@@ -62,7 +62,7 @@ class EnvironmentsUpdateCommand extends BoxCommand {
 			environment.useDefaultAsUser = true;
 		}
 
-		if (flags.hasOwnProperty('cache-tokens')) {
+		if (Object.hasOwn(flags, 'cache-tokens')) {
 			environment.cacheTokens = flags['cache-tokens'];
 		}
 

src/commands/configure/settings.js

@@ -68,10 +68,10 @@ class ConfigureSettingsCommand extends BoxCommand {
 			}
 			settings.boxReportsFolderPath = reportsPath;
 		}
-		if (flags.hasOwnProperty('output-json')) {
+		if (Object.hasOwn(flags, 'output-json')) {
 			settings.outputJson = flags['output-json'];
 		}
-		if (flags.hasOwnProperty('enable-proxy')) {
+		if (Object.hasOwn(flags, 'enable-proxy')) {
 			settings.enableProxy = flags['enable-proxy'];
 		}
 		if (flags['proxy-url']) {
@@ -83,7 +83,7 @@ class ConfigureSettingsCommand extends BoxCommand {
 		if (flags['proxy-password']) {
 			settings.proxy.password = flags['proxy-password'];
 		}
-		if (flags.hasOwnProperty(['enable-analytics-client'])) {
+		if (Object.hasOwn(flags, 'enable-analytics-client')) {
 			settings.enableAnalyticsClient = flags['enable-analytics-client'];
 		}
 		if (flags['analytics-client-name']) {

src/commands/files/lock.js

@@ -11,7 +11,7 @@ class FilesLockCommand extends BoxCommand {
 		if (flags.expires) {
 			options.expires_at = flags.expires;
 		}
-		if (flags.hasOwnProperty('prevent-download')) {
+		if (Object.hasOwn(flags, 'prevent-download')) {
 			options.is_download_prevented = flags['prevent-download'];
 		}
 

src/commands/files/rename.js

@@ -11,7 +11,7 @@ class FilesRenameCommand extends BoxCommand {
 			name: args.name,
 		};
 
-		if (flags.hasOwnProperty('description')) {
+		if (Object.hasOwn(flags, 'description')) {
 			options.description = flags.description;
 		}
 

src/commands/files/update.js

@@ -12,7 +12,7 @@ class FileUpdateCommand extends BoxCommand {
 		if (flags.name) {
 			updates.name = flags.name;
 		}
-		if (flags.hasOwnProperty('description')) {
+		if (Object.hasOwn(flags, 'description')) {
 			updates.description = flags.description;
 		}
 		if (flags.tags) {