Skip to content

feat: add real API integration tests for users#564

Closed
devin-ai-integration[bot] wants to merge 21 commits intomainfrom
devin/1738927957-add-user-integration-tests
Closed

feat: add real API integration tests for users#564
devin-ai-integration[bot] wants to merge 21 commits intomainfrom
devin/1738927957-add-user-integration-tests

Conversation

@devin-ai-integration
Copy link

@devin-ai-integration devin-ai-integration bot commented Feb 7, 2025 •
edited
Loading

Real API Integration Tests for Users

This PR adds integration tests for the Users manager in BoxCLI and fixes environment setup issues that were causing timeouts in CI.

Changes

  • Added integration test directory structure
  • Created test helper with JWT auth support
  • Added user integration tests covering:
    • Get user info
    • List group memberships
  • Added integration test npm script
  • Fixed environment setup reliability:
    • Added shorter timeouts (10-15s) for individual operations
    • Added detailed timing logs for debugging
    • Improved error handling and cleanup
    • Fixed promise handling issues
  • Updated GitHub Actions workflow to properly handle integration test failures

Testing

Integration tests require:

  • Box Platform application with JWT authentication
  • Admin user access
  • Environment variables setup:
    • BOX_JWT_CONFIG: Base64 encoded JWT configuration
    • BOX_ADMIN_USER_ID: ID of admin user account

Link to Devin run: https://app.devin.ai/sessions/530d7ec43e8b497b86e60175a865a55a
Requested by: mcong@box.com

devin-ai-integration bot and others added 4 commits February 7, 2025 11:32
@devin-ai-integration @congminh1254
feat: add user integration tests
5cf6f2d 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
feat: add real API integration tests for users
0b95da2 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: use JWT auth instead of test token for integration tests
ce44b49 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
feat: add real API integration tests for users
5d495e8 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration
Copy link
Author

devin-ai-integration bot commented Feb 7, 2025

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@devin-ai-integration devin-ai-integration bot changed the title Real API Integration Tests for Users feat: add real API integration tests for users Feb 7, 2025
devin-ai-integration bot and others added 4 commits February 7, 2025 21:53
@devin-ai-integration @congminh1254
ci: add GitHub Actions workflow for integration tests
4942d33 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
ci: update test script to only run unit tests
1cf32a8 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
ci: disable coverage for integration tests and allow failures until s…
bf3d0e9 
…ecrets are configured

Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: resolve linting issues in integration tests
e5bbcd2 
Co-Authored-By: mcong@box.com <mcong@box.com>
@coveralls
Copy link

coveralls commented Feb 7, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13208912350

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 25 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.7%) to 84.603%
Files with Coverage Reduction New Missed Lines %
src/commands/files/zip.js 1 81.03%
src/pagination-utils.js 1 88.24%
src/util.js 6 74.64%
src/box-command.js 17 72.15%
Totals Coverage Status
Change from base Build 13052088771: -0.7%
Covered Lines: 4374
Relevant Lines: 4972
💛 - Coveralls

devin-ai-integration bot and others added 13 commits February 7, 2025 22:03
@devin-ai-integration @congminh1254
ci: update integration test timeout to 60 seconds
7fb6364 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: update mocha timeout configuration
7848535 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: handle async operations properly in integration tests
f2deed5 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: handle async operations properly in integration tests
4acf241 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: add debug logging to integration test setup
f3421bc 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: add more debug logging to environment setup
144e572 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: improve environment setup reliability
dc94c41 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: fix syntax errors in test helper
dcffa08 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: handle interactive environment selection in test helper
2b02df8 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: improve environment setup reliability and add timeouts
13d4b3c 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: reduce timeouts and add timing logs for better debugging
18be64f 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: remove test:integration failure bypass
05b1dc9 
Co-Authored-By: mcong@box.com <mcong@box.com>
@devin-ai-integration @congminh1254
fix: resolve promise/avoid-new and promise/prefer-await-to-then lint …
eb92bec 
…issues

Co-Authored-By: mcong@box.com <mcong@box.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@coveralls @congminh1254