Add JSON recipe literals (reports)

Summary:
Now that JSON recipes support including recipes, we need to take those
literals into account in downstream reports.

Reviewed By: joshuamiller01

Differential Revision: D90605826

fbshipit-source-id: 6aa8fb5a209e9d0572ff4eade8cf1be59902cced

Author: dafyddcrosby

cookbooks/fb_bookworm/files/default/bookworm/lib/bookworm/reports/MissingReferencedRecipes.rb

@@ -35,6 +35,14 @@ def to_h
       end
     end
   end
+  @kb.recipejsons.each do |kbrecipe, metadata|
+    metadata['IncludeRecipeLiterals'].each do |recipe|
+      unless known_recipes.include? recipe
+        missing['recipes'][kbrecipe] ||= []
+        missing['recipes'][kbrecipe].append recipe
+      end
+    end
+  end
   missing
 end
 

cookbooks/fb_bookworm/files/default/bookworm/lib/bookworm/reports/NotReferencedRecipes.rb

@@ -27,6 +27,11 @@ def to_a
       referenced_recipes << recipe
     end
   end
+  @kb.recipejsons.each do |_, metadata|
+    metadata['IncludeRecipeLiterals'].each do |recipe|
+      referenced_recipes << recipe
+    end
+  end
   all_recipes = Set.new(@kb.recipes.keys + @kb.recipejsons.keys)
   # Any recipes which weren't included via roles or include_recipe are not referenced
   (all_recipes - referenced_recipes).sort.to_a

cookbooks/fb_bookworm/files/default/bookworm/spec/reports/MissingReferencedRecipes_spec.rb

@@ -75,4 +75,27 @@
       expect(output).to include('fb_nonexistent::setup')
     end
   end
+
+  describe 'with JSON recipes referencing missing recipes' do
+    let(:roles) { {} }
+    let(:recipes) do
+      {
+        'fb_existing::default' => {
+          'IncludeRecipeLiterals' => [],
+        },
+      }
+    end
+    let(:recipejsons) do
+      {
+        'fb_json::default' => {
+          'IncludeRecipeLiterals' => ['fb_existing::default', 'fb_missing_from_json::setup'],
+        },
+      }
+    end
+
+    it 'returns missing recipes from JSON recipes' do
+      result = report.to_h
+      expect(result['recipes']['fb_json::default']).to eq(['fb_missing_from_json::setup'])
+    end
+  end
 end

cookbooks/fb_bookworm/files/default/bookworm/spec/reports/NotReferencedRecipes_spec.rb

@@ -56,7 +56,9 @@
     end
     let(:recipejsons) do
       {
-        'fb_json_unused::default' => {},
+        'fb_json_unused::default' => {
+          'IncludeRecipeLiterals' => [],
+        },
       }
     end
 
@@ -74,4 +76,26 @@
       ])
     end
   end
+
+  describe 'with JSON recipes referencing other recipes' do
+    let(:roles) { {} }
+    let(:recipes) do
+      {
+        'fb_target::default' => {
+          'IncludeRecipeLiterals' => [],
+        },
+      }
+    end
+    let(:recipejsons) do
+      {
+        'fb_json::default' => {
+          'IncludeRecipeLiterals' => ['fb_target::default'],
+        },
+      }
+    end
+
+    it 'marks recipes referenced by JSON recipes as referenced' do
+      expect(report.to_a).to eq(['fb_json::default'])
+    end
+  end
 end