Tests & drop Laravel 7.0 support for this release as it appears we have breaking changes.

Author: olsgreen

.gitignore

@@ -1,3 +1,5 @@
 vendor
 composer.lock
-.todo
+.todo
+.idea
+.phpunit.result.cache

composer.json

@@ -11,19 +11,20 @@
     ],
     "prefer-stable": true,
     "require": {
-        "illuminate/contracts": "^6.0|^7.0",
-        "illuminate/http": "^6.0|^7.0",
-        "illuminate/database": "^6.0|^7.0",
-        "illuminate/auth": "^6.0|^7.0",
-        "illuminate/routing": "^6.0|^7.0",
-        "illuminate/notifications": "^6.0|^7.0",
-        "illuminate/bus": "^6.0|^7.0",
-        "illuminate/cookie": "^6.0|^7.0",
-        "illuminate/encryption": "^6.0|^7.0",
+        "php": "^7.2.5|^8.0",
+        "illuminate/contracts": "^6.0",
+        "illuminate/http": "^6.0",
+        "illuminate/database": "^6.0",
+        "illuminate/auth": "^6.0",
+        "illuminate/routing": "^6.0",
+        "illuminate/notifications": "^6.0",
+        "illuminate/bus": "^6.0",
+        "illuminate/cookie": "^6.0",
+        "illuminate/encryption": "^6.0",
         "ua-parser/uap-php": "^3.8"
     },
     "require-dev": {
-        "orchestra/testbench": "^4.0|^5.0",
+        "orchestra/testbench": "^4.0",
         "symfony/thanks": "^1.0"
     },
     "autoload": {

phpunit.xml.dist

@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit backupGlobals="false"
+         backupStaticAttributes="false"
+         beStrictAboutTestsThatDoNotTestAnything="false"
+         bootstrap="vendor/autoload.php"
+         colors="true"
+         convertErrorsToExceptions="true"
+         convertNoticesToExceptions="true"
+         convertWarningsToExceptions="true"
+         processIsolation="false"
+         stopOnFailure="false"
+>
+    <testsuites>
+        <testsuite name="Package Test Suite">
+            <directory suffix=".php">./tests/</directory>
+        </testsuite>
+    </testsuites>
+    <filter>
+        <whitelist processUncoveredFilesFromWhitelist="true">
+            <directory suffix=".php">./src</directory>
+            <exclude>
+                <directory>./vendor</directory>
+            </exclude>
+        </whitelist>
+    </filter>
+</phpunit>

tests/Integration/EnforcingMiddlewareTestCase.php

@@ -0,0 +1,75 @@
+<?php
+
+namespace Tests\Integration;
+
+use BoxedCode\Laravel\Auth\Device\Notifications\AuthorizationRequest;
+use Illuminate\Encryption\Encrypter;
+
+class EnforcingMiddlewareTestCase extends TestCase
+{
+    protected $da;
+
+    /**
+     * Setup the test environment.
+     */
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        $this->da = app('auth.device.broker');
+    }
+
+    protected function getEnvironmentSetUp($app)
+    {
+        parent::getEnvironmentSetUp($app);
+
+        // Set the application encryption key.
+        $app['config']->set('app.key', 'base64:'.base64_encode(
+            Encrypter::generateKey($app['config']['app.cipher'])
+        ));
+    }
+
+    public function testDefaultFlow()
+    {
+        \Notification::fake();
+
+        // Trigger auth request as an unverified user.
+        $response = $this->actingAs($this->testUser)->get('/');
+        $response->assertRedirect('http://localhost/auth/device/challenge');
+
+        // Visit the challenge page which will send us the email.
+        $response = $this->actingAs($this->testUser)->get('/auth/device/challenge');
+        $response->assertRedirect('http://localhost/auth/device/challenged');
+
+        // Visit the 'challenged' page which instructs the user to check their mail.
+        $response = $this->actingAs($this->testUser)->get('/auth/device/challenged');
+        $response->assertSee('We haven\'t seen you using this device before');
+
+        $latestAuthorization = $this->testUser->deviceAuthorizations()->latest()->first();
+
+        // Verify the notification was sent.
+        \Notification::assertSentTo($this->testUser, AuthorizationRequest::class, function ($mail) use ($latestAuthorization) {
+            return ($mail->verifyToken === $latestAuthorization->verify_token &&
+                $mail->browser === $latestAuthorization->browser &&
+                $mail->ip === $latestAuthorization->ip);
+        });
+
+        // 'Click' the link in the notification e-mail.
+        $response = $this->actingAs($this->testUser)
+            ->withoutMiddleware([\Illuminate\Cookie\Middleware\EncryptCookies::class])
+            ->get('/auth/device/verify/' . $latestAuthorization->verify_token);
+        $response->assertRedirect('/');
+
+        $authCookie = collect($response->headers->getCookies())
+            ->filter(function ($cookie) {
+                return $cookie->getName() === '_la_dat';
+            })->first();
+
+        // Check we can see the homepage.
+        $response = $this->withUnencryptedCookie($authCookie->getName(), $authCookie->getValue())
+            ->actingAs($this->testUser)->get('/');
+
+        $response->assertStatus(200);
+        $response->assertSeeText('Hello Test User!');
+    }
+}

tests/Integration/Support/Controller.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace Tests\Integration\Support;
+
+use BoxedCode\Laravel\Auth\Device\Http\Traits\DeviceAuthorization;
+use Illuminate\Foundation\Auth\AuthenticatesUsers;
+use Illuminate\Http\Request;
+use Illuminate\Routing\Controller as BaseController;
+
+class Controller extends BaseController
+{
+    use DeviceAuthorization;
+    use AuthenticatesUsers;
+
+    public function home(Request $request)
+    {
+        return 'Hello '.$request->user()->name.'!';
+    }
+}

tests/Integration/Support/User.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Tests\Integration\Support;
+
+use Illuminate\Foundation\Auth\User as BaseUser;
+
+class User extends BaseUser implements \BoxedCode\Laravel\Auth\Device\Contracts\HasDeviceAuthorizations
+{
+    use \BoxedCode\Laravel\Auth\Device\DeviceAuthorizations,
+        \Illuminate\Notifications\Notifiable;
+
+    protected $table = 'users';
+
+    protected $fillable = ['name', 'email', 'password'];
+
+    public function canAuthorizeDevice(): bool
+    {
+        return true;
+    }
+}

tests/Integration/TestCase.php

@@ -0,0 +1,75 @@
+<?php
+
+namespace Tests\Integration;
+
+use Tests\Integration\Support\User;
+
+abstract class TestCase extends \Orchestra\Testbench\TestCase
+{
+    public $testUser;
+
+    /**
+     * Get package providers.  At a minimum this is the package being tested, but also
+     * would include packages upon which our package depends, e.g. Cartalyst/Sentry
+     * In a normal app environment these would be added to the 'providers' array in
+     * the config/app.php file.
+     *
+     * @param \Illuminate\Foundation\Application $app
+     *
+     * @return array
+     */
+    protected function getPackageProviders($app)
+    {
+        return [
+            \BoxedCode\Laravel\Auth\Device\DeviceAuthServiceProvider::class
+        ];
+    }
+
+    /**
+     * Setup the test environment.
+     */
+    protected function setUp(): void
+    {
+        parent::setUp();
+
+        // Run the migrations.
+        $this->loadLaravelMigrations(['--database' => 'testing']);
+        $this->artisan('migrate', ['--database' => 'testing']);
+
+        // Create a test user.
+        $this->testUser = User::create([
+            'name'     => 'Test User',
+            'email'    => '[email protected]',
+            'password' => 'password',
+        ]);
+
+        \Route::get('/', '\Tests\Integration\Support\Controller@home')->middleware([
+            'auth',
+            \BoxedCode\Laravel\Auth\Device\Http\Middleware\RequireDeviceAuthorization::class,
+        ]);
+
+        \Route::get('/logout', '\Tests\Integration\Support\Controller@logout')->name('logout');
+    }
+
+    /**
+     * Define environment setup.
+     *
+     * @param \Illuminate\Foundation\Application $app
+     *
+     * @return void
+     */
+    protected function getEnvironmentSetUp($app)
+    {
+        // Setup default database to use sqlite :memory:
+        $app['config']->set('database.default', 'testing');
+        $app['config']->set('database.connections.testing', [
+            'driver'   => 'sqlite',
+            'database' => ':memory:',
+            'prefix'   => '',
+        ]);
+
+        // Set default user model.
+        $app['config']->set('auth.providers.users.model', User::class);
+        //$app['config']->set()
+    }
+}