test(storage): test prune backups string representation

Signed-off-by: James Neill <[email protected]>

Author: jmsnll

proxmox/storage/storage_types_test.go

@@ -0,0 +1,147 @@
+package storage
+
+import (
+	"encoding/json"
+	"testing"
+
+	"github.com/bpg/terraform-provider-proxmox/proxmox/types"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func intPtr(i int) *int {
+	return &i
+}
+
+func customInt64Ptr(i int64) *types.CustomInt64 {
+	c := types.CustomInt64(i)
+	return &c
+}
+
+// TestDataStoreWithBackups_String tests backup settings are encoded correctly into a string.
+func TestDataStoreWithBackups_String(t *testing.T) {
+	testCases := []struct {
+		name     string
+		input    DataStoreWithBackups
+		expected string
+	}{
+		{
+			name:     "Empty struct",
+			input:    DataStoreWithBackups{},
+			expected: "",
+		},
+		{
+			name:     "KeepLast only",
+			input:    DataStoreWithBackups{KeepLast: intPtr(5)},
+			expected: "keep-last=5",
+		},
+		{
+			name:     "KeepHourly only",
+			input:    DataStoreWithBackups{KeepHourly: intPtr(24)},
+			expected: "keep-hourly=24",
+		},
+		{
+			name:     "KeepDaily only",
+			input:    DataStoreWithBackups{KeepDaily: intPtr(7)},
+			expected: "keep-daily=7",
+		},
+		{
+			name:     "KeepWeekly only",
+			input:    DataStoreWithBackups{KeepWeekly: intPtr(4)},
+			expected: "keep-weekly=4",
+		},
+		{
+			name:     "KeepMonthly only",
+			input:    DataStoreWithBackups{KeepMonthly: intPtr(12)},
+			expected: "keep-monthly=12",
+		},
+		{
+			name:     "KeepYearly only",
+			input:    DataStoreWithBackups{KeepYearly: intPtr(3)},
+			expected: "keep-yearly=3",
+		},
+		{
+			name: "Multiple values",
+			input: DataStoreWithBackups{
+				KeepDaily:  intPtr(30),
+				KeepWeekly: intPtr(8),
+				KeepYearly: intPtr(10),
+			},
+			expected: "keep-daily=30,keep-weekly=8,keep-yearly=10",
+		},
+		{
+			name: "All values set",
+			input: DataStoreWithBackups{
+				KeepLast:    intPtr(1),
+				KeepHourly:  intPtr(2),
+				KeepDaily:   intPtr(3),
+				KeepWeekly:  intPtr(4),
+				KeepMonthly: intPtr(5),
+				KeepYearly:  intPtr(6),
+			},
+			expected: "keep-last=1,keep-hourly=2,keep-daily=3,keep-weekly=4,keep-monthly=5,keep-yearly=6",
+		},
+		{
+			name:     "MaxProtectedBackups should be ignored",
+			input:    DataStoreWithBackups{MaxProtectedBackups: customInt64Ptr(10)},
+			expected: "",
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			result := tc.input.String()
+			assert.Equal(t, tc.expected, result)
+		})
+	}
+}
+
+// TestDataStoreWithBackups_MarshalJSON tests the MarshalJSON() method.
+func TestDataStoreWithBackups_MarshalJSON(t *testing.T) {
+	testCases := []struct {
+		name     string
+		input    DataStoreWithBackups
+		expected string
+	}{
+		{
+			name:     "Empty struct",
+			input:    DataStoreWithBackups{},
+			expected: `{}`,
+		},
+		{
+			name:     "Only MaxProtectedBackups",
+			input:    DataStoreWithBackups{MaxProtectedBackups: customInt64Ptr(10)},
+			expected: `{"max-protected-backups":10}`,
+		},
+		{
+			name:     "Only prune-backups (single)",
+			input:    DataStoreWithBackups{KeepDaily: intPtr(7)},
+			expected: `{"prune-backups":"keep-daily=7"}`,
+		},
+		{
+			name: "Only prune-backups (multiple)",
+			input: DataStoreWithBackups{
+				KeepWeekly:  intPtr(4),
+				KeepMonthly: intPtr(12),
+			},
+			expected: `{"prune-backups":"keep-weekly=4,keep-monthly=12"}`,
+		},
+		{
+			name: "Both MaxProtectedBackups and prune-backups",
+			input: DataStoreWithBackups{
+				MaxProtectedBackups: customInt64Ptr(5),
+				KeepLast:            intPtr(3),
+				KeepYearly:          intPtr(1),
+			},
+			expected: `{"max-protected-backups":5,"prune-backups":"keep-last=3,keep-yearly=1"}`,
+		},
+	}
+
+	for _, tc := range testCases {
+		t.Run(tc.name, func(t *testing.T) {
+			result, err := json.Marshal(tc.input)
+			require.NoError(t, err)
+			assert.JSONEq(t, tc.expected, string(result))
+		})
+	}
+}