Skip to content

Commit 00fe926

Browse files
committed
remove sbt-explicit-dependencies because it gives false positives for ScalaJS libraries
1 parent 5645f74 commit 00fe926

File tree

3 files changed

+2
-5
lines changed

3 files changed

+2
-5
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ jobs:
5252
- name: Check that workflows are up to date
5353
run: sbt ++${{ matrix.scala }} githubWorkflowCheck
5454

55-
- name: Build and test project
56-
run: sbt ++${{ matrix.scala }} undeclaredCompileDependenciesTest unusedCompileDependenciesTest test
55+
- name: Build project
56+
run: sbt ++${{ matrix.scala }} test
5757

5858
- name: Compress target directories
5959
run: tar cf targets.tar target core/js/target core/jvm/target project/target

build.sbt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ inThisBuild(List(
2929
githubWorkflowJavaVersions := Seq("adopt@1.8", "adopt@1.11"),
3030
githubWorkflowTargetTags ++= Seq("v*"),
3131
githubWorkflowPublishTargetBranches := Seq(RefPredicate.StartsWith(Ref.Tag("v"))),
32-
githubWorkflowBuild := Seq(WorkflowStep.Sbt(List("undeclaredCompileDependenciesTest", "unusedCompileDependenciesTest", "test"), name = Some("Build and test project"))),
3332
githubWorkflowPublish := Seq(
3433
WorkflowStep.Sbt(
3534
List("ci-release"),
@@ -49,7 +48,6 @@ lazy val `java-time-literals` = crossProject(JSPlatform, JVMPlatform)
4948
.in(file("core"))
5049
.settings(Seq(
5150
description := "Parse string literals into `java.time` instances at compile time",
52-
unusedCompileDependenciesFilter -= moduleFilter("org.scala-lang", "scala-reflect"),
5351
libraryDependencies ++= {
5452
val scalaReflect: immutable.Seq[ModuleID] =
5553
if (scalaVersion.value.startsWith("3")) Nil

project/plugins.sbt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
addSbtPlugin("com.geirsson" % "sbt-ci-release" % "1.5.7")
22
addSbtPlugin("io.github.davidgregory084" % "sbt-tpolecat" % "0.1.17")
3-
addSbtPlugin("com.github.cb372" % "sbt-explicit-dependencies" % "0.2.16")
43
addSbtPlugin("com.codecommit" % "sbt-github-actions" % "0.10.1")
54
addSbtPlugin("org.scala-js" % "sbt-scalajs" % "1.5.1")
65
addSbtPlugin("org.portable-scala" % "sbt-scalajs-crossproject" % "1.0.0")

0 commit comments

Comments
 (0)