Skip to content

Commit 79a9983

Browse files
committed
improve profile handling, killed warnings
1 parent 696ac76 commit 79a9983

File tree

6 files changed

+9
-7
lines changed

6 files changed

+9
-7
lines changed

.github/workflows/development.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,6 @@ jobs:
4545
- name: Build with Maven
4646
run: ./mvnw clean verify -U -B -ntp -T4
4747

48-
# itest
49-
- name: Run itest
50-
run: ./mvnw -Pitest -ntp -U -B -T4
51-
52-
5348
# - name: Upload coverage to Codecov
5449
# if: github.event_name == 'push' && github.actor != 'dependabot[bot]'
5550
# uses: codecov/codecov-action@v1.0.2

.github/workflows/master.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545

4646
# Publish release
4747
- name: Deploy a new release version to Maven Central
48-
run: ./mvnw clean deploy -B -ntp -DskipTests -DskipExamples -Prelease -Dgpg.keyname="${{ secrets.GPG_KEYNAME }}"
48+
run: ./mvnw clean deploy -B -ntp -DskipTests -DskipITests -DskipExamples -Prelease -Dgpg.keyname="${{ secrets.GPG_KEYNAME }}"
4949
env:
5050
OSS_CENTRAL_USERNAME: ${{ secrets.SONATYPE_USERNAME }}
5151
OSS_CENTRAL_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }}

pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,11 @@
105105
</profile>
106106

107107
<profile>
108+
<activation>
109+
<property>
110+
<name>!skipITests</name>
111+
</property>
112+
</activation>
108113
<id>itest</id>
109114
<modules>
110115
<module>itest</module>

spring-boot-idempotency-registry-jpa/src/main/kotlin/dev/bpmcrafters/processengine/worker/idempotency/MapConverter.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ class MapConverter : AttributeConverter<Map<String, Any?>, ByteArray> {
2424
if (dbData == null) {
2525
return null
2626
}
27+
@Suppress("UNCHECKED_CAST")
2728
return ObjectInputStream(ByteArrayInputStream(dbData)).readObject() as Map<String, Any?>
2829
}
2930

spring-boot-starter/src/main/kotlin/dev/bpmcrafters/processengine/worker/registrar/ProcessEngineStarterRegistrar.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ class ProcessEngineStarterRegistrar(
168168
}
169169
if (autoCompleteTask && !completeBeforeCommit) {
170170
logger.trace { "PROCESS-ENGINE-WORKER-016: auto completing task ${taskInformation.taskId} after commit" }
171-
completeTask(taskInformation, txResult)
171+
completeTask(taskInformation, requireNotNull(txResult))
172172
processEngineWorkerMetrics.taskCompleted(topic)
173173
}
174174
} else {

spring-boot-starter/src/test/kotlin/dev/bpmcrafters/processengine/worker/registrar/ProcessEngineIdempotencyTest.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ class ProcessEngineIdempotencyTest {
4747
idempotencyRegistry
4848
)
4949

50+
@Suppress("UNCHECKED_CAST")
5051
@Test
5152
fun `should not invoke annotated method again for same task`() {
5253
// Given a worker method and a counting action

0 commit comments

Comments
 (0)