fix: disallow output mapping for terminate event

Related to camunda/camunda-modeler#4096

Author: barmac

src/provider/zeebe/utils/InputOutputUtil.js

@@ -80,7 +80,9 @@ export function areInputParametersSupported(element) {
 
 export function areOutputParametersSupported(element) {
 
-  if (is(element, 'bpmn:EndEvent') && getErrorEventDefinition(element)) {
+  if (is(element, 'bpmn:EndEvent') && (
+    getErrorEventDefinition(element) || getTerminateEventDefinition(element)
+  )) {
     return false;
   }
 
@@ -95,6 +97,10 @@ export function areOutputParametersSupported(element) {
   ]);
 }
 
+function getTerminateEventDefinition(element) {
+  return getEventDefinition(element, 'bpmn:TerminateEventDefinition');
+}
+
 export function createIOMapping(properties, parent, bpmnFactory) {
   return createElement('zeebe:IoMapping', properties, parent, bpmnFactory);
 }

test/spec/provider/zeebe/OutputProps.bpmn

@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:zeebe="http://camunda.org/schema/zeebe/1.0" id="Definitions_1md541i" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="5.10.0">
+<bpmn:definitions xmlns:bpmn="http://www.omg.org/spec/BPMN/20100524/MODEL" xmlns:bpmndi="http://www.omg.org/spec/BPMN/20100524/DI" xmlns:dc="http://www.omg.org/spec/DD/20100524/DC" xmlns:zeebe="http://camunda.org/schema/zeebe/1.0" id="Definitions_1md541i" targetNamespace="http://bpmn.io/schema/bpmn" exporter="Camunda Modeler" exporterVersion="5.20.0">
   <bpmn:process id="Process_1" isExecutable="true">
     <bpmn:serviceTask id="ServiceTask_1" name="ServiceTask_1">
       <bpmn:extensionElements>
@@ -33,21 +33,28 @@
         </zeebe:ioMapping>
       </bpmn:extensionElements>
     </bpmn:serviceTask>
+    <bpmn:endEvent id="TerminateEvent">
+      <bpmn:terminateEventDefinition id="TerminateEventDefinition_0278au4" />
+    </bpmn:endEvent>
   </bpmn:process>
   <bpmndi:BPMNDiagram id="BPMNDiagram_1">
     <bpmndi:BPMNPlane id="BPMNPlane_1" bpmnElement="Process_1">
       <bpmndi:BPMNShape id="ServiceTask_0rud1s3_di" bpmnElement="ServiceTask_1">
         <dc:Bounds x="160" y="60" width="100" height="80" />
         <bpmndi:BPMNLabel />
       </bpmndi:BPMNShape>
-      <bpmndi:BPMNShape id="Activity_1jxbsb5_di" bpmnElement="ServiceTask_2">
-        <dc:Bounds x="280" y="60" width="100" height="80" />
+      <bpmndi:BPMNShape id="Activity_0tyoei0_di" bpmnElement="Task_1">
+        <dc:Bounds x="160" y="260" width="100" height="80" />
         <bpmndi:BPMNLabel />
       </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="Activity_10ckisu_di" bpmnElement="ServiceTask_NoExtensionElements">
         <dc:Bounds x="160" y="160" width="100" height="80" />
         <bpmndi:BPMNLabel />
       </bpmndi:BPMNShape>
+      <bpmndi:BPMNShape id="Activity_1jxbsb5_di" bpmnElement="ServiceTask_2">
+        <dc:Bounds x="280" y="60" width="100" height="80" />
+        <bpmndi:BPMNLabel />
+      </bpmndi:BPMNShape>
       <bpmndi:BPMNShape id="Activity_18i7pky_di" bpmnElement="ServiceTask_NoIoMapping">
         <dc:Bounds x="280" y="160" width="100" height="80" />
         <bpmndi:BPMNLabel />
@@ -56,9 +63,8 @@
         <dc:Bounds x="400" y="160" width="100" height="80" />
         <bpmndi:BPMNLabel />
       </bpmndi:BPMNShape>
-      <bpmndi:BPMNShape id="Activity_0tyoei0_di" bpmnElement="Task_1">
-        <dc:Bounds x="160" y="260" width="100" height="80" />
-        <bpmndi:BPMNLabel />
+      <bpmndi:BPMNShape id="Event_1mzhhj5_di" bpmnElement="TerminateEvent">
+        <dc:Bounds x="362" y="382" width="36" height="36" />
       </bpmndi:BPMNShape>
     </bpmndi:BPMNPlane>
   </bpmndi:BPMNDiagram>

test/spec/provider/zeebe/OutputProps.spec.js

@@ -296,6 +296,25 @@ describe('provider/zeebe - OutputProps', function() {
 
   });
 
+
+  describe('bpmn:EndEvent#output', function() {
+
+    it('should NOT display for terminate event', inject(async function(elementRegistry, selection) {
+
+      // given
+      const task = elementRegistry.get('TerminateEvent');
+
+      await act(() => {
+        selection.select(task);
+      });
+
+      // when
+      const outputGroup = getGroup(container, 'outputs');
+
+      // then
+      expect(outputGroup).to.not.exist;
+    }));
+  });
 });