Skip to content

Commit 2c91cbe

Browse files
barmacnikku
authored andcommitted
chore: remove legacy check
We don't need it since we require more recent diagram-js version.
1 parent 4d44a79 commit 2c91cbe

File tree

3 files changed

+2
-32
lines changed

3 files changed

+2
-32
lines changed

src/render/BpmnPropertiesPanel.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -250,9 +250,7 @@ export default function BpmnPropertiesPanel(props) {
250250
// helpers //////////////////////////
251251

252252
function isImplicitRoot(element) {
253-
254-
// Backwards compatibility for diagram-js<7.4.0, see https://github.com/bpmn-io/bpmn-properties-panel/pull/102
255-
return element && (element.isImplicit || element.id === '__implicitroot');
253+
return element && element.isImplicit;
256254
}
257255

258256
function findElement(elements, element) {

src/render/BpmnPropertiesPanelRenderer.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -201,9 +201,7 @@ BpmnPropertiesPanelRenderer.$inject = [ 'config.propertiesPanel', 'injector', 'e
201201
// helpers ///////////////////////
202202

203203
function isImplicitRoot(element) {
204-
205-
// Backwards compatibility for diagram-js<7.4.0, see https://github.com/bpmn-io/bpmn-properties-panel/pull/102
206-
return element && (element.isImplicit || element.id === '__implicitroot');
204+
return element && element.isImplicit;
207205
}
208206

209207
/**

test/spec/BpmnPropertiesPanelRenderer.spec.js

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -401,32 +401,6 @@ describe('<BpmnPropertiesPanelRenderer>', function() {
401401
});
402402

403403

404-
it('should ignore implicit root - legacy', async function() {
405-
406-
// given
407-
const diagramXml = require('test/fixtures/simple.bpmn').default;
408-
409-
// when
410-
const { modeler } = await createModeler(diagramXml, {
411-
shouldImport: false,
412-
propertiesPanel: {}
413-
});
414-
415-
const implicitRootElement = {
416-
id: '__implicitroot',
417-
children: []
418-
};
419-
420-
// when
421-
const propertiesPanel = modeler.get('propertiesPanel');
422-
propertiesPanel.attachTo(propertiesContainer);
423-
propertiesPanel._render(implicitRootElement);
424-
425-
// then
426-
expect(domQuery('.bio-properties-panel', propertiesContainer)).to.not.exist;
427-
});
428-
429-
430404
describe('providers', function() {
431405

432406
const diagramXML = require('test/fixtures/simple.bpmn').default;

0 commit comments

Comments
 (0)