chore(camunda-platform): drop compareFn

No longer necessary as we don't intend to sort anymore.

Author: nikku

src/provider/camunda-platform/properties/FormField.js

@@ -592,21 +592,10 @@ function PropertiesList(props) {
     element={ element }
     autoFocusEntry={ true }
     id={ id }
-    compareFn={ createAlphanumericCompare('id') }
     label={ translate('Properties') }
     items={ propertyEntries }
     component={ Property }
     onAdd={ addProperty }
     onRemove={ removeProperty }
   />;
 }
-
-// helper //////////////////
-
-function createAlphanumericCompare(field) {
-  return function(entry, anotherEntry) {
-    const [ key = '', anotherKey = '' ] = [ entry[field], anotherEntry[field] ];
-
-    return key === anotherKey ? 0 : key > anotherKey ? 1 : -1;
-  };
-}

src/provider/camunda-platform/properties/ListProps.js

@@ -70,16 +70,9 @@ export function ListProps(props) {
     });
   }
 
-  function compareFn(item, anotherItem) {
-    const [ value = '', anotherValue = '' ] = [ item.value, anotherItem.value ];
-
-    return value === anotherValue ? 0 : value > anotherValue ? 1 : -1;
-  }
-
   return ListEntry({
     element,
     autoFocusEntry: true,
-    compareFn,
     id: idPrefix + '-list',
     items,
     label: translate('List values'),

src/provider/camunda-platform/properties/ListenerProps.js

@@ -472,7 +472,6 @@ function Fields(props) {
     component={ Field }
     onAdd={ addField }
     onRemove={ removeField }
-    compareFn={ compareName }
     autoFocusEntry={ `[data-entry-id="${id}-field-${fields.length - 1}"] input` }
   />;
 }
@@ -559,12 +558,6 @@ function getPrefixedId(prefix, id) {
   return `${prefix}-${id}`;
 }
 
-function compareName(field, anotherField) {
-  const [ name = '', anotherName = '' ] = [ field.name, anotherField.name ];
-
-  return name === anotherName ? 0 : name > anotherName ? 1 : -1;
-}
-
 function getListenersContainer(element) {
   const businessObject = getBusinessObject(element);
 

src/provider/camunda-platform/properties/MapProps.js

@@ -78,16 +78,9 @@ export function MapProps(props) {
     });
   }
 
-  function compareFn(entry, anotherEntry) {
-    const [ key = '', anotherKey = '' ] = [ entry.key, anotherEntry.key ];
-
-    return key === anotherKey ? 0 : key > anotherKey ? 1 : -1;
-  }
-
   return ListEntry({
     element,
     autoFocusEntry: true,
-    compareFn,
     id: idPrefix + '-map',
     items: entries,
     label: translate('Map entries'),

test/spec/provider/camunda-platform/FormField.spec.js

@@ -866,7 +866,7 @@ describe('provider/camunda-platform - FormField', function() {
         // then
         const properties = getFormFieldProperties(task, 0);
         const propertyEntries = domQueryAll('div[data-entry-id=UserTask_1-formField-0-formFieldProperties] li', container);
-        const label = domQuery('.bio-properties-panel-collapsible-entry-header-title', propertyEntries[1]);
+        const label = domQuery('.bio-properties-panel-collapsible-entry-header-title', propertyEntries[0]);
 
         expect(properties.get('values')[0].id).to.equal(label.innerHTML);
       }));
@@ -883,7 +883,7 @@ describe('provider/camunda-platform - FormField', function() {
 
         // then
         const propertyEntries = domQueryAll('div[data-entry-id=UserTask_1-formField-0-formFieldProperties] li', container);
-        const label = domQuery('.bio-properties-panel-collapsible-entry-header-title', propertyEntries[0]);
+        const label = domQuery('.bio-properties-panel-collapsible-entry-header-title', propertyEntries[1]);
 
         expect(label.innerHTML).to.equal('<empty>');
       }));
@@ -911,9 +911,9 @@ describe('provider/camunda-platform - FormField', function() {
           container)).map(e => e.innerHTML);
 
         expect(propertiesEntries).to.eql([
+          'Property3',
           'Property1',
-          'Property2',
-          'Property3' ]);
+          'Property2' ]);
       }));
 
     });

test/spec/provider/camunda-platform/FormFieldProperty.spec.js

@@ -72,7 +72,7 @@ describe('provider/camunda-platform - FormFieldProperty', function() {
         selection.select(task);
       });
 
-      const idInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-1-id', container);
+      const idInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-0-id', container);
       const properties = getFormFieldProperties(task, 0);
 
       // then
@@ -90,7 +90,7 @@ describe('provider/camunda-platform - FormFieldProperty', function() {
         selection.select(task);
       });
 
-      const idInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-1-id', container);
+      const idInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-0-id', container);
       const properties = getFormFieldProperties(task, 0);
 
       // when
@@ -113,7 +113,7 @@ describe('provider/camunda-platform - FormFieldProperty', function() {
           selection.select(task);
         });
 
-        const idInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-1-id', container);
+        const idInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-0-id', container);
 
         changeInput(idInput, 'newVal');
 
@@ -140,7 +140,7 @@ describe('provider/camunda-platform - FormFieldProperty', function() {
         selection.select(task);
       });
 
-      const valueInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-1-value', container);
+      const valueInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-0-value', container);
       const properties = getFormFieldProperties(task, 0);
 
       // then
@@ -158,7 +158,7 @@ describe('provider/camunda-platform - FormFieldProperty', function() {
         selection.select(task);
       });
 
-      const valueInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-1-value', container);
+      const valueInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-0-value', container);
       const properties = getFormFieldProperties(task, 0);
 
       // when
@@ -181,7 +181,7 @@ describe('provider/camunda-platform - FormFieldProperty', function() {
           selection.select(task);
         });
 
-        const valueInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-1-value', container);
+        const valueInput = domQuery('#bio-properties-panel-UserTask_1-formField-0-formFieldProperties-property-0-value', container);
 
         changeInput(valueInput, 'newVal');