Skip to content

Commit 9afb582

Browse files
feat: change Header value input and Field Injection value input to text areas (#1065)
deps: update @bpmn-io/properties-panel to 3.22.3 Related camunda/camunda-modeler#2982
1 parent 6b49485 commit 9afb582

File tree

6 files changed

+25
-23
lines changed

6 files changed

+25
-23
lines changed

package-lock.json

Lines changed: 11 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
"@babel/plugin-transform-react-jsx": "^7.24.7",
6262
"@bpmn-io/element-template-chooser": "^1.0.0",
6363
"@bpmn-io/element-templates-icons-renderer": "^0.3.0",
64-
"@bpmn-io/properties-panel": "^3.21.0",
64+
"@bpmn-io/properties-panel": "^3.22.3",
6565
"@bpmn-io/variable-resolver": "^1.2.2",
6666
"@rollup/plugin-alias": "^5.1.0",
6767
"@rollup/plugin-babel": "^6.0.4",

src/provider/camunda-platform/properties/FieldInjection.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { TextFieldEntry, SelectEntry } from '@bpmn-io/properties-panel';
1+
import { TextFieldEntry, SelectEntry, TextAreaEntry } from '@bpmn-io/properties-panel';
22

33
import {
44
useService
@@ -156,13 +156,14 @@ function ValueProperty(props) {
156156
return field.string || field.stringValue || field.expression;
157157
};
158158

159-
return TextFieldEntry({
159+
return TextAreaEntry({
160160
element: field,
161161
id: idPrefix + '-value',
162162
label: translate('Value'),
163163
getValue,
164164
setValue,
165-
debounce
165+
debounce,
166+
autoResize: true
166167
});
167168
}
168169

src/provider/zeebe/properties/Header.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { TextFieldEntry } from '@bpmn-io/properties-panel';
1+
import { TextFieldEntry, TextAreaEntry } from '@bpmn-io/properties-panel';
22

33
import {
44
useService
@@ -87,12 +87,13 @@ function ValueProperty(props) {
8787
return header.value;
8888
};
8989

90-
return TextFieldEntry({
90+
return TextAreaEntry({
9191
element: header,
9292
id: idPrefix + '-value',
9393
label: translate('Value'),
9494
getValue,
9595
setValue,
96-
debounce
96+
debounce,
97+
autoResize: true
9798
});
9899
}

test/spec/provider/camunda-platform/FieldInjectionProps.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ describe('provider/camunda-platform - FieldInjectionProps', function() {
7878

7979
// when
8080
const executionListenerGroup = domQuery('[data-group-id="group-CamundaPlatform__ExecutionListener"]', container);
81-
const valueInputField = domQuery('input[name*="value"]', executionListenerGroup);
81+
const valueInputField = domQuery('textarea[name*="value"]', executionListenerGroup);
8282

8383
changeInput(valueInputField, 'newValue');
8484

test/spec/provider/zeebe/Header.spec.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ describe('provider/bpmn - Header', function() {
155155

156156
// when
157157
const headerGroup = getGroup(container, 'headers');
158-
const valueInput = domQuery('input[name=ServiceTask_empty-header-0-value]', headerGroup);
158+
const valueInput = domQuery('textarea[name=ServiceTask_empty-header-0-value]', headerGroup);
159159

160160
// then
161161
expect(valueInput).to.not.exist;
@@ -173,7 +173,7 @@ describe('provider/bpmn - Header', function() {
173173

174174
// when
175175
const headerGroup = getGroup(container, 'headers');
176-
const valueInput = domQuery('input[name=ServiceTask_1-header-0-value]', headerGroup);
176+
const valueInput = domQuery('textarea[name=ServiceTask_1-header-0-value]', headerGroup);
177177

178178
// then
179179
expect(valueInput.value).to.eql(getHeader(serviceTask, 0).get('value'));
@@ -191,7 +191,7 @@ describe('provider/bpmn - Header', function() {
191191

192192
// when
193193
const headerGroup = getGroup(container, 'headers');
194-
const valueInput = domQuery('input[name=ServiceTask_1-header-0-value]', headerGroup);
194+
const valueInput = domQuery('textarea[name=ServiceTask_1-header-0-value]', headerGroup);
195195
changeInput(valueInput, 'newValue');
196196

197197
// then
@@ -209,7 +209,7 @@ describe('provider/bpmn - Header', function() {
209209
await act(() => {
210210
selection.select(serviceTask);
211211
});
212-
const valueInput = domQuery('input[name=ServiceTask_1-header-0-value]', container);
212+
const valueInput = domQuery('textarea[name=ServiceTask_1-header-0-value]', container);
213213
changeInput(valueInput, 'newValue');
214214

215215
// when

0 commit comments

Comments
 (0)