fix: fixed issue when undo of pasted collapsed sub-process throws JS Errors

Related to #2269

Author: AlekseyManetov

lib/features/modeling/behavior/SubProcessPlaneBehavior.js

@@ -111,17 +111,26 @@ export default function SubProcessPlaneBehavior(
   }, true);
 
 
-  this.postExecuted('shape.create', function(context) {
-    var shape = context.shape,
-        rootElement = context.newRootElement;
+  this.postExecuted('elements.create', function(context) {
+    var elements = context.elements;
 
-    if (!rootElement || !shape.children) {
-      return;
-    }
+    forEach(elements, function(element) {
+      if (!isCollapsedSubProcess(element)) {
+        return;
+      }
+
+      var rootElement = elementRegistry.get(getPlaneIdFromShape(element));
 
-    self._showRecursively(shape.children);
+      if (!rootElement || !element.children || !element.children.length) {
+        return;
+      }
 
-    self._moveChildrenToShape(shape.children.slice(), rootElement);
+      var children = getSubProcessChildren(element);
+
+      self._showRecursively(children);
+
+      self._moveChildrenToShape(children, rootElement);
+    });
   }, true);
 
 
@@ -359,11 +368,7 @@ export default function SubProcessPlaneBehavior(
       // since we can't keep both after collapsing
       self._disconnectSharedAnnotations(shape);
 
-      // annotations and external labels live at process level by design;
-      // include them when moving children to the plane
-      var children = shape.children.slice()
-        .concat(collectAnnotationElements(shape.children))
-        .concat(getExternalLabels(shape));
+      var children = getSubProcessChildren(shape);
 
       self._moveChildrenToShape(children, rootElement);
 
@@ -652,6 +657,21 @@ function collectAnnotationElements(elements) {
   return result;
 }
 
+/**
+ * Collect all children of a collapsed subprocess that need to be moved
+ * to or from its plane, including annotations and external labels that
+ * live at the process level by design(ref: https://github.com/camunda/camunda-modeler/issues/5163#issuecomment-3946571271)
+ *
+ * @param {Element} element
+ *
+ * @return {Element[]}
+ */
+function getSubProcessChildren(element) {
+  return element.children.slice()
+    .concat(collectAnnotationElements(element.children))
+    .concat(getExternalLabels(element));
+}
+
 /**
  * Returns external labels of the given element's children and their descendants
  *
@@ -677,3 +697,4 @@ function getExternalLabels(element) {
 
   return result;
 }
+