Skip to content

Commit fe57ca2

Browse files
rohanSSBJbarmac
authored andcommitted
snapping: remove unreachable lane child traversal
1 parent 80c91e6 commit fe57ca2

File tree

1 file changed

+2
-21
lines changed

1 file changed

+2
-21
lines changed

lib/features/snapping/BpmnCreateMoveSnapping.js

Lines changed: 2 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { isExpanded } from '../../util/DiUtil';
1313

1414
import { is } from '../../util/ModelUtil';
1515

16-
import { collectLanes } from '../modeling/util/LaneUtil';
16+
1717

1818
import {
1919
asTRBL,
@@ -210,31 +210,12 @@ BpmnCreateMoveSnapping.prototype.addSnapTargetPoints = function(snapPoints, shap
210210
* @return {Shape[]}
211211
*/
212212
BpmnCreateMoveSnapping.prototype.getSnapTargets = function(shape, target) {
213-
var snapTargets = CreateMoveSnapping.prototype.getSnapTargets.call(this, shape, target)
213+
return CreateMoveSnapping.prototype.getSnapTargets.call(this, shape, target)
214214
.filter(function(snapTarget) {
215215

216216
// do not snap to lanes
217217
return !is(snapTarget, 'bpmn:Lane');
218218
});
219-
220-
// In participants with lanes, flow nodes are children of the participant,
221-
// but lanes are also children. The base implementation returns all children,
222-
// and we've filtered out lanes above. However, we should also include
223-
// children from nested lanes (for sublanes) if any exist.
224-
if (is(target, 'bpmn:Participant')) {
225-
var lanes = collectLanes(target, []);
226-
227-
// Add children from lanes (handles nested sublanes if any)
228-
forEach(lanes, function(lane) {
229-
forEach(lane.children || [], function(child) {
230-
if (!is(child, 'bpmn:Lane') && !child.hidden && child !== shape && snapTargets.indexOf(child) === -1) {
231-
snapTargets.push(child);
232-
}
233-
});
234-
});
235-
}
236-
237-
return snapTargets;
238219
};
239220

240221
// helpers //////////

0 commit comments

Comments
 (0)