Fixed lowercase filename issues #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks, I really appreciate the effort to improve this tool. I still have many plans, but alas, little time at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First off, what a cool toolkit! I've noticed a few minor issues, which I'll try to fix where possible.
This one is about an inconsitency in the usage of lowercase filenames. Essentially it does away with all automatic lowercasing, which I think makes everything more consistent.
It should be noted that the filename (actually the suffix) appears to determine the component name, so perhaps this should not be also recorded inside the .comp file itself. (This may cause further inconsistencies or unexpected behavior.)