Simple overloaded constructor for loading components

[tgoorden]

An error that is easy to run into, is mistakingly adding components to the flowsheet later on in the code (e.g. after you've already processed some streams). This will inevitably result in hard to understand errors.

To avoid this, perhaps an easy 'fix' is to provide an overloaded constructor like this:

function Flowsheet(components::Vector{AbstractString})
    fs = Flowsheet()
    readcomponentlist!(fs, "./components", components)
end

[braamvandyk]

This is why I added refreshcomplist(), which will add zero flows to all streams for new components, but yes, if you don't call this it will cause issues. Maybe the better options is to automatically call this when adding components if streams already exist. I'll dig into this.

Thanks for the feedback. Things like this are harder to pick up on if you have been sitting inside the code for too long.

[tgoorden]

No worries, I am really grateful you made this, so just trying to give back.

One other thing I've noticed is that the code is probably “too strongly typed” in a few areas. For instance, you cannot use interpolated strings (e.g. "$(foo)_bar") in the macro's and Symbols are even more of an issue. Allowing Symbols also gives the compiler more optimization options, I think.

(I've bypassed many macro's for this particular reason.)

[braamvandyk]

Calling refreshcomplist() is fairly easy to do in the macro and functions that add components, but if you add them directly to the complist via fs.comps["xyz"] = ... you are still going to break something. I want to modify setindex!() but will first have to figure out how to let the CompList know who owns it without causing a circular reference. Any ideas would be welcome. I'll spend some time this week playing with options.

[braamvandyk]

Right, this went better than expected. I just pushed an update that calls refreshcomplist() automatically upon adding a component (by adding a parent filed to the ComponentList' and calling the reresh in setindex!()` for the Dict), so existing streams get the zero flows added to them as soon as you add a component, no matter how you choose to add the component.

I also removed the component names from the *.comp files. Components now will include the filename as their names when read from file, else just the name they were created with, so you can distinguish between newly created and previously saved components. The latter was a bit of a happy accident. I'll leave it as-is unless it breaks something else (which I haven't seen in my quick tests).

I'll go look at the interpolated strings / symbols when I get another gap to work on this. I created a separate issue for that.

I'll leave this open for some more testing, but you are free to close it if you are happy before I get around to running more tests myself.

Happy flowsheeting!

[braamvandyk]

Fixed by 0882419