fix: Upgrade brainbits coding standard, fix code style issues

Author: Stephan Wentz

composer.json

@@ -23,7 +23,7 @@
         "phpstan/phpstan": "^1.0"
     },
     "require-dev": {
-        "brainbits/phpcs-standard": "^4.0",
+        "brainbits/phpcs-standard": "^7.0",
         "php-coveralls/php-coveralls": "^2.0",
         "phpstan/phpstan-php-parser": "^1.0",
         "phpstan/phpstan-phpunit": "^1.0",

src/CoversClassExistsRule.php

@@ -22,21 +22,14 @@
 use function sha1;
 use function sprintf;
 
-// phpcs:disable SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
-
-/**
- * @implements Rule<Class_>
- */
+/** @implements Rule<Class_> */
 final class CoversClassExistsRule implements Rule
 {
-    /** @var Broker */
-    private $broker;
     /** @var bool[] */
-    private $alreadyParsedDocComments = [];
+    private array $alreadyParsedDocComments = [];
 
-    public function __construct(Broker $broker)
+    public function __construct(private Broker $broker)
     {
-        $this->broker = $broker;
     }
 
     public function getNodeType(): string
@@ -57,9 +50,7 @@ public function processNode(Node $node, Scope $scope): array
         return array_merge($messagesAttribute, $messagesAnnotation);
     }
 
-    /**
-     * @return RuleError[] errors
-     */
+    /** @return RuleError[] errors */
     public function processNodeAttribute(Class_ $node, Scope $scope): array
     {
         $messages = [];
@@ -108,9 +99,7 @@ public function processNodeAttribute(Class_ $node, Scope $scope): array
         return $messages;
     }
 
-    /**
-     * @return RuleError[] errors
-     */
+    /** @return RuleError[] errors */
     public function processNodeAnnotation(Class_ $node, Scope $scope): array
     {
         $messages   = [];
@@ -124,7 +113,7 @@ public function processNodeAnnotation(Class_ $node, Scope $scope): array
             $scope->getFile(),
             $docComment->getStartLine(),
             $docComment->getStartFilePos(),
-            $docComment->getText()
+            $docComment->getText(),
         ));
         if (isset($this->alreadyParsedDocComments[$hash])) {
             return $messages;

src/CoversClassPresentRule.php

@@ -21,9 +21,7 @@
 
 // phpcs:disable SlevomatCodingStandard.TypeHints.PropertyTypeHint.MissingNativeTypeHint
 
-/**
- * @implements Rule<Class_>
- */
+/** @implements Rule<Class_> */
 final class CoversClassPresentRule implements Rule
 {
     private const TEST_CLASS_ENDING_STRING = 'Test';
@@ -110,9 +108,7 @@ public function processNodeAttribute(Class_ $node, Scope $scope): bool
         return false;
     }
 
-    /**
-     * @return array<string>
-     */
+    /** @return array<string> */
     private function getAnnotationLines(Node $node, Scope $scope): array
     {
         $docComment = $node->getDocComment();
@@ -126,8 +122,8 @@ private function getAnnotationLines(Node $node, Scope $scope): array
                 $scope->getFile(),
                 $docComment->getStartLine(),
                 $docComment->getStartFilePos(),
-                $docComment->getText()
-            )
+                $docComment->getText(),
+            ),
         );
 
         if (array_key_exists($hash, $this->alreadyParsedDocComments)) {