fix: fix comments

Author: braindigitalis

include/dpp/application.h

@@ -118,7 +118,10 @@ class DPP_EXPORT application {
 	application& fill_from_json(nlohmann::json* j);
 };
 
-/** A group of bans
+/** A group of applications.
+ * This is not currently ever sent by Discord API but the DPP standard setup for
+ * objects that can be received by REST has the possibility for this, so this exists.
+ * Don't ever expect to see one at present.
  */
 typedef std::unordered_map<snowflake, application> application_map;
 

include/dpp/discord.h

@@ -235,6 +235,26 @@ namespace dpp {
 			uint64_t to_msecs();
 		};
 
+		/**
+		 * @brief Convert floats to RGB for sending in embeds
+		 * 
+		 * @param red red value, between 0 and 1 inclusive
+		 * @param green green value, between 0 and 1 inclusive
+		 * @param blue blue value, between 0 and 1 inclusive
+		 * @return uint32_t returned integer colour value
+		 */
+		uint32_t rgb(float red, float green, float blue);
+
+		/**
+		 * @brief Convert ints to RGB for sending in embeds
+		 * 
+		 * @param red red value, between 0 and 255 inclusive
+		 * @param green green value, between 0 and 255 inclusive
+		 * @param blue blue value, between 0 and 255 inclusive
+		 * @return uint32_t returned integer colour value
+		 */
+		uint32_t rgb(int red, int green, int blue);
+
 		/**
 		 * @brief Output hex values of a section of memory for debugging
 		 * 

src/dpp/utility.cpp

@@ -188,6 +188,15 @@ namespace dpp {
 			}
 		}
 
+		uint32_t rgb(float red, float green, float blue) {
+			return (((uint32_t)(red * 255)) << 16) | (((uint32_t)(green * 255)) << 8) | ((uint32_t)(blue * 255));
+		}
+
+		/* NOTE: Parameters here are `int` instead of `uint32_t` or `uint8_t` to prevent ambiguity error with rgb(float, float, float) */
+		uint32_t rgb(int red, int green, int blue) {
+			return ((uint32_t)red << 16) | ((uint32_t)green << 8) | (uint32_t)blue;
+		}
+
 		void exec(const std::string& cmd, std::vector<std::string> parameters, cmd_result_t callback) {
 			auto t = std::thread([cmd, parameters, callback]() {
 				std::array<char, 128> buffer;