sleeping with interrupts off is a generally bad idea

Author: braindigitalis

modules/e1000/e1000.c

@@ -373,7 +373,8 @@ bool e1000_start(pci_dev_t *pci_device) {
 	e1000_write_command(REG_CTRL, 0x20 | ECTRL_SLU);
 
 	if (e1000_device_id == E1000_82541PI) {
-		sleep(10); // Delay required after CTRL write on 82541PI
+		// Delay required after CTRL write on 82541PI
+		for (int j = 0; j < 10000; ++j) io_wait();
 	}
 
 	e1000_check_link();

src/timer.c

@@ -43,7 +43,7 @@ void sleep(uint64_t milliseconds)
 	uint64_t start = ticks;
 	uint64_t end = start + milliseconds;
 	while (ticks < end) {
-		__asm__ volatile("hlt");
+		__asm__ volatile("pause");
 	}
 }