Squiz/FunctionDeclarationArgumentSpacing: improve SpacingBetween fixer

The fixer for the `SpacingBetween` error code would only handle one whitespace token at a time, which is inefficient and could also lead to more complex fixer conflicts.

This commit changes the fixer to handle all whitespace between the parentheses in one go.

For the code sample added as a test, this means the difference between the fixer needing 7 loops (including two skipped loops due to possible conflicts) versus 2 loops.

<details>
  <summary>Old:</summary>

```
        => Fixing file: 1/1 violations remaining
        Squiz.Functions.FunctionDeclarationArgumentSpacing:133 replaced token 6 (T_WHITESPACE on line 3) "\n\n" => "\n"
        => Fixing file: 1/1 violations remaining [made 1 pass]...
        * fixed 1 violations, starting loop 2 *
        Squiz.Functions.FunctionDeclarationArgumentSpacing:133 replaced token 6 (T_WHITESPACE on line 3) "\n\n" => "\n"
        => Fixing file: 1/1 violations remaining [made 2 passes]...
        * fixed 1 violations, starting loop 3 *
        **** Squiz.Functions.FunctionDeclarationArgumentSpacing:133 has possible conflict with another sniff on loop 1; caused by the following change ****
        **** replaced token 6 (T_WHITESPACE on line 3) "\n    " => "    " ****
        **** ignoring all changes until next loop ****
        => Fixing file: 0/1 violations remaining [made 3 passes]...
        * fixed 0 violations, starting loop 4 *
        Squiz.Functions.FunctionDeclarationArgumentSpacing:133 replaced token 6 (T_WHITESPACE on line 3) "\n    " => "    "
        => Fixing file: 1/1 violations remaining [made 4 passes]...
        * fixed 1 violations, starting loop 5 *
        **** Squiz.Functions.FunctionDeclarationArgumentSpacing:133 has possible conflict with another sniff on loop 3; caused by the following change ****
        **** replaced token 6 (T_WHITESPACE on line 3) "    )" => ")" ****
        **** ignoring all changes until next loop ****
        => Fixing file: 0/1 violations remaining [made 5 passes]...
        * fixed 0 violations, starting loop 6 *
        Squiz.Functions.FunctionDeclarationArgumentSpacing:133 replaced token 6 (T_WHITESPACE on line 3) "    )" => ")"
        => Fixing file: 1/1 violations remaining [made 6 passes]...
        * fixed 1 violations, starting loop 7 *
        => Fixing file: 0/1 violations remaining [made 7 passes]...
```
</details>

<details>
  <summary>New:</summary>

```
        => Fixing file: 1/1 violations remaining
        => Changeset started by Squiz.Functions.FunctionDeclarationArgumentSpacing:133
                Q: Squiz.Functions.FunctionDeclarationArgumentSpacing:135 replaced token 6 (T_WHITESPACE on line 3) "\n\n" => "\n"
                Q: Squiz.Functions.FunctionDeclarationArgumentSpacing:135 replaced token 7 (T_WHITESPACE on line 4) "\n\n" => "\n"
                Q: Squiz.Functions.FunctionDeclarationArgumentSpacing:135 replaced token 8 (T_WHITESPACE on line 5) "\n    " => "    "
                Q: Squiz.Functions.FunctionDeclarationArgumentSpacing:135 replaced token 9 (T_WHITESPACE on line 6) "    )" => ")"
                A: Squiz.Functions.FunctionDeclarationArgumentSpacing:137 replaced token 6 (T_WHITESPACE on line 3) "\n\n" => "\n"
                A: Squiz.Functions.FunctionDeclarationArgumentSpacing:137 replaced token 7 (T_WHITESPACE on line 4) "\n\n" => "\n"
                A: Squiz.Functions.FunctionDeclarationArgumentSpacing:137 replaced token 8 (T_WHITESPACE on line 5) "\n    " => "    "
                A: Squiz.Functions.FunctionDeclarationArgumentSpacing:137 replaced token 9 (T_WHITESPACE on line 6) "    )" => ")"
        => Changeset ended: 4 changes applied
        => Fixing file: 4/1 violations remaining [made 1 pass]...
        * fixed 4 violations, starting loop 2 *
        => Fixing file: 0/1 violations remaining [made 2 passes]...
```
</details>

Author: jrfnl

src/Standards/Squiz/Sniffs/Functions/FunctionDeclarationArgumentSpacingSniff.php

@@ -131,13 +131,18 @@ public function processBracket($phpcsFile, $openBracket)
                     $data  = [$found];
                     $fix   = $phpcsFile->addFixableError($error, $openBracket, 'SpacingBetween', $data);
                     if ($fix === true) {
-                        $phpcsFile->fixer->replaceToken(($openBracket + 1), '');
+                        $phpcsFile->fixer->beginChangeset();
+                        for ($i = ($openBracket + 1); $tokens[$i]['code'] === T_WHITESPACE; $i++) {
+                            $phpcsFile->fixer->replaceToken($i, '');
+                        }
+
+                        $phpcsFile->fixer->endChangeset();
                     }
                 }
 
                 // No params, so we don't check normal spacing rules.
                 return;
-            }
+            }//end if
         }//end if
 
         foreach ($params as $paramNumber => $param) {

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc

@@ -113,3 +113,8 @@ fn ($a,$b = null) => $a($b);
 function multipleWhitespaceTokensAfterType(int
 
     $number) {}
+
+function spacingBetweenParenthesesShouldBeFixedInOneGo(
+
+
+    ) {}

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.inc.fixed

@@ -111,3 +111,5 @@ $a = function ($var1, $var2=false) use (
 fn ($a, $b=null) => $a($b);
 
 function multipleWhitespaceTokensAfterType(int $number) {}
+
+function spacingBetweenParenthesesShouldBeFixedInOneGo() {}

src/Standards/Squiz/Tests/Functions/FunctionDeclarationArgumentSpacingUnitTest.php

@@ -69,6 +69,7 @@ public function getErrorList()
             107 => 2,
             111 => 3,
             113 => 1,
+            117 => 1,
         ];
 
     }//end getErrorList()