Remove instructions for setting firmware version from Ganglion BLE GAP scan callback

philippitts · philippitts · commit 69928729aee4 · 2026-01-21T20:07:50.000-08:00
diff --git a/src/board_controller/openbci/ganglion_bglib/callbacks.cpp b/src/board_controller/openbci/ganglion_bglib/callbacks.cpp
@@ -75,13 +75,11 @@ void ble_evt_gap_scan_response (const struct ble_msg_gap_scan_response_evt_t *ms
         if (memcmp (msg->sender.addr, (uint8 *)GanglionLib::connect_addr.addr, sizeof (bd_addr)) ==
             0)
         {
-            GanglionLib::firmware = msg->data.data[0] == 20 && msg->data.data[13] == '3' ? 3 : 2;
             GanglionLib::exit_code = (int)GanglionLib::STATUS_OK;
         }
         else if (strstr (name, "anglion") != NULL) // strcasestr is unavailable for windows
         {
             memcpy ((void *)GanglionLib::connect_addr.addr, msg->sender.addr, sizeof (bd_addr));
-            GanglionLib::firmware = msg->data.data[0] == 20 && msg->data.data[13] == '3' ? 3 : 2;
             GanglionLib::exit_code = (int)GanglionLib::STATUS_OK;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -75,13 +75,11 @@ void ble_evt_gap_scan_response (const struct ble_msg_gap_scan_response_evt_t *ms`
`75`	`75`	`if (memcmp (msg->sender.addr, (uint8 *)GanglionLib::connect_addr.addr, sizeof (bd_addr)) ==`
`76`	`76`	`0)`
`77`	`77`	`{`
`78`		`- GanglionLib::firmware = msg->data.data[0] == 20 && msg->data.data[13] == '3' ? 3 : 2;`
`79`	`78`	`GanglionLib::exit_code = (int)GanglionLib::STATUS_OK;`
`80`	`79`	`}`
`81`	`80`	`else if (strstr (name, "anglion") != NULL) // strcasestr is unavailable for windows`
`82`	`81`	`{`
`83`	`82`	`memcpy ((void *)GanglionLib::connect_addr.addr, msg->sender.addr, sizeof (bd_addr));`
`84`		`- GanglionLib::firmware = msg->data.data[0] == 20 && msg->data.data[13] == '3' ? 3 : 2;`
`85`	`83`	`GanglionLib::exit_code = (int)GanglionLib::STATUS_OK;`
`86`	`84`	`}`
`87`	`85`	`}`