Skip to content

Commit b414616

Browse files
shansitadsshansitads
authored
Merge pull request #66 from brainhack-vandy/enhancement/team-links
Enhancement/team links
2 parents beac751 + 4b41b3c commit b414616

File tree

4 files changed

+57
-15
lines changed

4 files changed

+57
-15
lines changed

‎src/components/Team/Team.js‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ const TeamSection = ({ title, members, showDivider = false }) => (
2323
description={member.description}
2424
imgPath={member.imgPath}
2525
ghLink={member.ghLink}
26+
websiteLink={member.websiteLink}
2627
team={member.team}
2728
/>
2829
</Col>

‎src/components/Team/TeamCard.js‎

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,23 @@
11
import React from "react";
22
import Card from "react-bootstrap/Card";
33
import { BsGithub } from "react-icons/bs";
4+
import { FaLink } from "react-icons/fa";
45
import './team.css';
56

67
function TeamCard(props) {
78
const hasGitHub = props.ghLink && props.ghLink.trim() !== "" && props.ghLink !== "https://github.com";
9+
const hasWebsite = props.websiteLink && props.websiteLink.trim() !== "";
810

911
return (
1012
<Card className="team-card-view">
1113
<Card.Img variant="top" src={props.imgPath} alt="card-img" className="teamcard-img-top" loading="eager" />
12-
<Card.Body>
14+
<Card.Body className="flex flex-col h-full">
1315
<Card.Title className="team-card-title">
1416
{props.title}
17+
</Card.Title>
18+
{props.team && <div className="team-member-role">{props.team}</div>}
19+
<Card.Text className="team-card-description">{props.description}</Card.Text>
20+
<div className="mt-auto flex justify-center gap-8">
1521
{hasGitHub && (
1622
<a
1723
href={props.ghLink}
@@ -23,9 +29,18 @@ function TeamCard(props) {
2329
<BsGithub className="github-icon" />
2430
</a>
2531
)}
26-
</Card.Title>
27-
{props.team && <div className="team-member-role">{props.team}</div>}
28-
<Card.Text className="team-card-description">{props.description}</Card.Text>
32+
{hasWebsite && (
33+
<a
34+
href={props.websiteLink}
35+
target="_blank"
36+
rel="noopener noreferrer"
37+
className="website-link"
38+
aria-label={`${props.title}'s website`}
39+
>
40+
<FaLink className="website-icon" />
41+
</a>
42+
)}
43+
</div>
2944
</Card.Body>
3045
</Card>
3146
);

‎src/components/Team/team.css‎

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,22 +88,31 @@
8888
transform: scale(1.05) !important;
8989
}
9090

91-
.github-link {
91+
.github-link,
92+
.website-link {
9293
display: inline-block;
93-
margin-left: 10px;
94+
margin: 0 10px;
9495
color: var(--imp-text-color) !important;
9596
transition: color 0.3s ease !important;
9697
}
9798

98-
.github-link:hover {
99+
.github-link:hover,
100+
.website-link:hover {
99101
color: #b19cd9 !important;
100102
}
101103

102-
.github-icon {
103-
font-size: 1.2em;
104+
.github-icon,
105+
.website-icon {
106+
font-size: 1.5em;
104107
vertical-align: middle;
105108
}
106109

110+
.team-card-view .card-body {
111+
display: flex;
112+
flex-direction: column;
113+
height: 100%;
114+
}
115+
107116
/* Media queries for responsive image sizes */
108117
@media (max-width: 768px) {
109118
.teamcard-img-top {

‎src/components/Team/teamData.js‎

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,42 +6,54 @@ const teamData = {
66
description: "Undergraduate Student",
77
team: "Hackathon Chair",
88
imgPath: "assets/team/Richard_Song.svg",
9+
ghLink: "https://github.com/richardwsong",
10+
websiteLink: "https://www.linkedin.com/in/richard-song-837015198/"
911
},
1012
{
1113
title: "Roza G. Bayrak",
1214
description: "Senior Research Engineer",
1315
team: "General Chair",
1416
imgPath: "assets/team/Roza_Bayrak.svg",
17+
ghLink: "https://github.com/rgbayrak",
18+
websiteLink: "https://rgbayrak.github.io/"
1519
},
1620
{
1721
title: "Catie Chang",
1822
description: "Assistant Professor",
1923
team: "Faculty Advisor",
2024
imgPath: "assets/team/Catie_Chang.svg",
25+
ghLink: "https://github.com/cately",
26+
websiteLink: "https://www.cchanglab.net/"
2127
},
2228
{
2329
title: "Kim Rogge-Obando",
2430
description: "Graduate Student",
2531
imgPath: "assets/team/Kim_Rogge-Obando.svg",
26-
team: "Project Team Lead"
32+
team: "Project Team Lead",
33+
websiteLink: "https://www.linkedin.com/in/kim-rogge-obando/",
2734
},
2835
{
2936
title: "Sarah Goodale",
3037
description: "Postdoctoral Researcher",
3138
imgPath: "assets/team/Sarah_Goodale.svg",
32-
team: "Operations Team Lead"
39+
team: "Operations Team Lead",
40+
ghLink: "https://github.com/goodalse2019",
41+
websiteLink: "https://www.linkedin.com/in/goodale-sarah/"
3342
},
3443
{
3544
title: "Shansita D. Sharma",
3645
description: "Undergraduate Student",
3746
imgPath: "assets/team/Shansita_DS.svg",
38-
team: "Dev Team Lead"
47+
team: "Dev Team Lead",
48+
ghLink: "https://github.co/shansitads",
49+
websiteLink: "https://shansitads.github.io/profile"
3950
},
4051
{
4152
title: "Terra Lee",
4253
description: "Undergraduate Student",
4354
imgPath: "assets/team/Terra_Lee.svg",
44-
team: "Marketing Team Lead"
55+
team: "Marketing Team Lead",
56+
websiteLink: "https://www.linkedin.com/in/terra-hyunbin-lee/"
4557
},
4658
{
4759
title: "Lucy Wu",
@@ -53,12 +65,16 @@ const teamData = {
5365
title: "David Zaha",
5466
description: "Undergraduate Student",
5567
imgPath: "assets/team/David_Zaha.svg",
56-
team: "Development"
68+
team: "Development",
69+
ghLink: "https://github.com/dgzct11",
70+
websiteLink: "https://www.linkedin.com/in/davidzaha/"
5771
},
5872
{
5973
title: "Sefika Ozturk",
6074
description: "Undergraduate Student",
6175
imgPath: "assets/team/Sefika_Ozturk.svg",
76+
ghLink: "https://github.com/sefikaozturk",
77+
websiteLink: "https://www.linkedin.com/in/sefikaozturk/",
6278
team: "Operations"
6379
},
6480
{
@@ -77,7 +93,8 @@ const teamData = {
7793
title: "Mashiur Khan",
7894
description: "Undergraduate Student",
7995
imgPath: "assets/team/placeholder2.svg",
80-
team: "Development"
96+
team: "Development",
97+
ghLink: "https://github.com/mashcodes10"
8198
},
8299
{
83100
title: "Crystal Jiang",

0 commit comments

Comments
 (0)